I have the same.. but I'm not sure whether the link from /sbin/sh is automatically there. So I have checked the LPQ stock image and found out that /system/bin/sh is a part of it. I changed the references to it. Could you try that please?
Thanks for the feedback! I hadn't thought of the commands like touch and chown that are executed by the script. I have also other versions of these. So now I changed it to always use the versions from /system/bin. I got the same errors then and corrected them. Also, the versions are now updated when you install.
I will update the first post with the new installer. You will probably need to reinstall, because the permissions could not be set correctly.
Battery impact should be close to zero. Xposed does not require any services or additional wakelocks. Also it does no polling (frequent checks for a certain state). There is a small initialization phase, afterwards it gets only called when one of the hooked methods is about to be executed. So it does not prevent deep sleep because it gets only triggered by apps/services running anyway.
This of course depends on how the modules are implemented. The red clock example hooks a specialized method that is only called when the clock text is updated (once a minute). If it instead hooked a very generic method like setText, it would be called more often and it would have to execute more new code to find out if it has to do something.
The same applies to performance. If the developer is specific with the method hooks and the ratio of original to additional code is sensible, the impact will be low.
These are mainly thoughts as I could not test battery impact over a longer period yet (too much develop and restarts etc). But I did not feel a performance impact from the clock example, so the framework should be fine.
Just a quick (maybe dumb) question/idea:
Would a module build with PDroid work with this?
I think PDroid changes some framework stuff and so we could have an easy way to intigrate it's privacy fetaures into our android rom (without using this "smali" patch thing on every rom update-zip we install)
XDA Developers was founded by developers, for developers. It is now a valuable resource for people who want to make the most of their mobile devices, from customizing the look and feel to adding new functionality. Are you a developer?