FORUMS
Remove All Ads from XDA

[CLARIFICATION] Xperia Lollipop & "Fix Lollipop Memory Leak"

1,073 posts
Thanks Meter: 2,684
 
Post Reply Email Thread
Hey there, the XperiFirm dev here.

I've seen people that use the official Lollipop on their Xperia devices, yet they also use the "Fix Lollipop Memory Leak" Xposed module.
Let's make something clear: Xperia Lollipop does NOT have that memory leak.
Sony made sure to include the memory leak fix built in (the exact fix that the Xposed module offers) for their Lollipop releases. The Xposed module is pointless.
Basically the Xposed module replaces the AOSP function with exactly the same function but with this additional "release()" line. As you can see in the attached screenshot, Xperia already has this line included.

Hope that stops you from using the highly unstable alpha of Xposed Framework for a module that is totally useless for your Xperia device.

services.jar
smali/com/android/server/display/ColorFade.smali
Line 318
Attached Thumbnails
Click image for larger version

Name:	Untitled.png
Views:	9748
Size:	92.6 KB
ID:	3271281  
The Following 77 Users Say Thank You to IgorEisberg For This Useful Post: [ View ] Gift IgorEisberg Ad-Free
 
 
19th April 2015, 10:33 PM |#2  
josephnero's Avatar
Senior Member
Flag Sanford NC
Thanks Meter: 625
 
More
that's what i've been trying to make some members understand
The Following User Says Thank You to josephnero For This Useful Post: [ View ] Gift josephnero Ad-Free
20th April 2015, 10:37 AM |#3  
Zeyn Karim's Avatar
Senior Member
Flag Johannesburg
Thanks Meter: 30
 
More
Thank you guy's for the info! i'm uninstalling the module now
20th April 2015, 11:06 AM |#4  
Member
Flag Ljubljana
Thanks Meter: 16
 
More
thats why i never use xposed modules...it can be unstable and lower ur perfomance of the phone.
20th April 2015, 12:42 PM |#5  
Pandemic's Avatar
Senior Member
Cyber City On Cybertron
Thanks Meter: 20,754
 
Donate to Me
More
See thats why Sony dont rushed with Lollipop
The Following 2 Users Say Thank You to Pandemic For This Useful Post: [ View ] Gift Pandemic Ad-Free
20th April 2015, 01:41 PM |#6  
IgorEisberg's Avatar
OP Senior Member
Thanks Meter: 2,684
 
Donate to Me
More
Quote:
Originally Posted by Pandemic

See thats why Sony dont rushed with Lollipop

Good thing they didn't, I am very satisfied with Lollipop on my Z1, it's smooth, I get 700-800 free RAM, and absolutely NO lag...
Quote:
Originally Posted by cocagenda2

thats why i never use xposed modules...it can be unstable and lower ur perfomance of the phone.

... and that's when the picture changes: when I use Xposed (on a properly deodexed and highly stable ROM I made myself) my phones lags awfully, it heats up quickly, and the battery gets drained in a few hours. (no bootloops though)
I'd skip Xposed until the stable version gets released.
The Following User Says Thank You to IgorEisberg For This Useful Post: [ View ] Gift IgorEisberg Ad-Free
20th April 2015, 02:15 PM |#7  
Pandemic's Avatar
Senior Member
Cyber City On Cybertron
Thanks Meter: 20,754
 
Donate to Me
More
Quote:
Originally Posted by IaguCool

Good thing they didn't, I am very satisfied with Lollipop on my Z1, it's smooth, I get 700-800 free RAM, and absolutely NO lag...

... and that's when the picture changes: when I use Xposed (on a properly deodexed and highly stable ROM I made myself) my phones lags awfully, it heats up quickly, and the battery gets drained in a few hours. (no bootloops though)
I'd skip Xposed until the stable version gets released.

+1
exactly, it runs very smooth, fluid and fast on my Z2 either
No lag at all ^^
20th April 2015, 11:07 PM |#8  
a.hamameh96's Avatar
Senior Member
Flag Sinsheim
Thanks Meter: 161
 
More
Awesome that's why they were late
Thanks for your great info mate you answered my question
21st April 2015, 06:36 AM |#9  
Senior Member
Thanks Meter: 110
 
More
Thanks for the explanation, I was wondering about the same. Although I do not agree that Xposed is highly unstable. It doesn't cause any lags, battery drain or any instability to my phone (odexed Z2 .726). Usability of Xposed for LP is close to KK experience.
26th April 2015, 09:55 PM |#10  
mionica's Avatar
Senior Member
Flag Dublin
Thanks Meter: 452
 
Donate to Me
More
Exclamation
EDIT #2: I've found the root cause of the problem: see here.

Quote:
Originally Posted by IaguCool

Hey there, the XperiFirm dev here.

I've seen people that use the official Lollipop on their Xperia devices, yet they also use the "Fix Lollipop Memory Leak" Xposed module.
Let's make something clear: Xperia Lollipop does NOT have a memory leak.
Sony made sure to include the memory leak fix built in (the exact fix that the Xposed module offers) for their Lollipop releases. The Xposed module is pointless.
Basically the Xposed module replaces the AOSP function with exactly the same function but with this additional "release()" line. As you can see in the attached screenshot, Xperia already has this line included.

Hope that stops you from using the highly unstable alpha of Xposed Framework for a module that is totally useless for your Xperia device.

EDIT: please just ignore the rest of the post, I misunderstood the Fix Lollipop Memory Leak bit.


The purpose of xposed-sonyfix is not to fix a memory leak, but to prevent bootloops on the 2nd and subsequent boots with the framework installed. I have no idea whether that's still required with xposed-sdk21-arm-20150426.zip, but it was sure as hell a problem with xposed-arm-20150308.zip.

With stock Z3 LP firmware and xposed-arm-20150308.zip - even without the xposed apk! - one needed to wipe /cache before every boot, and wait until all the apps were compiled again. Not too convenient.
@ondrejvaroscak discovered that if the open file limits were increased during boot, the bootloop didn't happen anymore; and another dude did a .zip (actually 3 ) that increased the file limits on boot.
At that stage, I stepped in, with the goal to provide a complete solution that would 1) get rid of the bootloop, and 2) when boot had finished, attempt to restore the on-init default values to zygote's process tree.

All the discussion about leaks is pure speculation. Here I summarized that - the relevant bits are
Quote:
Originally Posted by mionica

And there's one more thing. We like to blame Xposed (or at least you seem to ), but we don't have a clue whether it's Xposed or Android itself. This just occured to me - they recently released 5.1.1, which reportedly fixed some memory leaks that have been in since 5.0.0 - I wonder if memory's all that 5.0.2's leaking... What about handles? What if Xposed LP only works on other platforms because the kernel devels of those devices had figured **** might hit the fan, so they increased the kernel limits to accomodate a leaky Android?... What if Sony's stock app_process does some crazy Sony-specific things to avoid said leaks, or clean up after them, which Xposed's doesn't?... That wouldn't break SU, which only hooks the file entry, but would break Xposed, which replaces app_process altogether...

and
Quote:
Originally Posted by mionica

...and yeah, that's obviously the thing to do. If we talk to the Xposed devs and say, "it doesn't work on our device", I think a "so what?" answer would be actually appropriate. That's why I haven't approached them do date; when I do, I mean to be able to say, "this is what seems to be wrong, this is my analysis, here are my logs; can I help you (help me ) in any other way?"

That said, bootloops are a fact with stock LP firmware, on the stock kernel, and xposed-arm-20150308.zip. I'm actually cleaning the phone ATM in order to have a clean testbed for checking whether xposed-sdk21-arm-20150426.zip is different in this respect.

This is not a blame game. It's sound engineering on my behalf, attempting to fix an observed, and rather inconvenient, problem - which yes, is either caused by, or triggered by, running Xposed Framework (binary version 20150308), on Sony LP devices with a lot of .apk's installed - I expect if either one of these 3 conditions isn't met, the problem doesn't occur. It can't be observed, for instance, on debloated ROMs.
The Following 3 Users Say Thank You to mionica For This Useful Post: [ View ] Gift mionica Ad-Free
27th April 2015, 07:08 PM |#11  
mo120697's Avatar
Senior Member
Flag Ludwigsburg
Thanks Meter: 239
 
More
Quote:
Originally Posted by IaguCool

Hey there, the XperiFirm dev here.

I've seen people that use the official Lollipop on their Xperia devices, yet they also use the "Fix Lollipop Memory Leak" Xposed module.
Let's make something clear: Xperia Lollipop does NOT have a memory leak.
Sony made sure to include the memory leak fix built in (the exact fix that the Xposed module offers) for their Lollipop releases. The Xposed module is pointless.
Basically the Xposed module replaces the AOSP function with exactly the same function but with this additional "release()" line. As you can see in the attached screenshot, Xperia already has this line included.

Hope that stops you from using the highly unstable alpha of Xposed Framework for a module that is totally useless for your Xperia device.

nice to hear, but tell my why xperia home gets reloaded sometimes after browsing etc. and why gets music, spotify kicked out?
Post Reply Subscribe to Thread
Previous Thread Next Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes