Originally Posted by pinpong
Originally Posted by Kjetal
This is the kernel where it is said every day for 4 days to come he do?
Oh, i know , the Recovery Touch is the problem
What is this bull**** attitude? A mere day since it was released and already acting like children from part of the "developer" and his henchman?
The question was a legitimate query from superleeds27's part; functionally
, this is just NEAK with several governors pasted in. If you want to refute that fact then do it without the drama.
And as for the kernel itself:
- Wheatley. First of all, it's not there because he forgot to put it into his makefile.
Secondly, we've already discussed in the Phoenix kernel thread that Wheatley is a governor created for the Galaxy Nexus running on an OMAP4 chip which has different idle states and transition times compared to the Exynos on the GS2, which this governor specifically is based around. It's at best useless, and at worst worsening on our device.
- Scary. As bad as a copy-paste as I've seen, not even bothering to change the OMAP frequencies to match ours;
Also, conservative and interactive governors need to be adjusted to take into account the crazy 16-step frequency table which you implemented, which you didn't.
#define DEFAULT_SLEEP_MAX_FREQ 245760
#define DEFAULT_SLEEP_MIN_FREQ 122880
#define DEFAULT_SLEEP_PREV_FREQ 122880
#define DEFAULT_PREV_MAX 1024000
- I don't know what you are doing when copy/pasting but you are doing it wrong; there's loads of patch code left over in your actual source code from the original commits.
Example: you took your commit right out of myfluxi's repository but didn't use git for it but rather just copy/pasted it or I don't know what. It explains your weird "O.o" commits where you actually remove the lines from the patch-code. Not to mention you don't even credit myfluxi for a 1:1 copy of code. Or for that matter, any of your commits.
- Sakuractive is actually an interesting find coming from a Japanese developer. While it's in itself not bad and even a good idea; you don't credit him even though you copied his explanation from the Kconfig. The Samsung authored "pegasusq" which is included in the Update4 source drop does exactly the same thing and written by engineers, so you might question which one is better.
At best, this kernel deserves to be in the Android Development forum in its current state, and pinpong needs to practice and learn more on his own before releasing anything with bells and whistles attached to it.