Looks good to me.
A few comments/questions:
- what is the use-case for "handset-stereo-dmic-ef"?
- your default gains seem overly hot to me, you will quickly run into clipping/saturation issues.
- I really like the idea of being able to modify device acdb identifiers via an xml file.
This means no more messing with the audio HAL required to select a different identifier for the CAMCORDER device.
- from your mixer_paths.xml file it appears that you are defaulting to stereo recording when the camcorder is being used.
On hammerhead, there is some structured noise audible in the auxiliary microphone channel (left). I'm not sure where it comes
from, but it seems louder during a camcorder recording and somewhat softer (and different in nature) during an audio-only
recording. I did correlate some of the noise to mpdecision as it manipulates the processor cores. I am able to lower the noise somewhat by locking all four cores to 1.19GHz. At this point my best guess is that the analog microphone traces run close to some high-speed data signals that feed into the MSM. Long story short, you may not want to default to stereo recording as some folks may object to the noise.
Can you push your changes to github? This would make tracking, understanding and cherry-picking much easier. Uploading blobs is confident for the end user, but not for everyone else. You just had to clone the hammerhead devicetree and audio HAL from https://android.googlesource.com/device/lge/hammerhead/ and https://android.googlesource.com/pla...re/qcom/audio/ and probably https://android.googlesource.com/pla...frameworks/av/ as well.