[FIX] Updated: How to fix deodexed System Framework (slow Browser)

brightidea · Aug 8, 2011

Update 14th Aug 2011: JesusFreke has released a new version of baksmali (v1.2.7) which seems to have fixed the bug above
You may download it from here http://blog.jesusfreke.com/2011/08/smalibaksmali-127.html - Thank you JesusFreke for a great tool and support

Please feel free to report any bugs or issues with this tool here or on his blog.

-------------

Good news to all modders out there - I finally found the bug for real this time - unfortunately, it's in baksmali.jar" .. The fault occurs when it attempts to ~~build~~ deodex framework.~~jar~~odex ~~from~~ into smali files
specifically this file "android/view/SurfaceView.smali"

I believe baksmali (v1.2.6) just fails to realize that the class variable it wants to access belongs to the super (parent) class .. instead it simply accesses the local class variable.

But I have a ~~work-around~~ fix to the bug ~~(guranteed to work as long as the order of class fields mLeft and mTop are the same in android/view/SurfaceView.smali as android/webkit/WebViewCore$ShowRectData.smali)~~

The solution:
1. replace

Code:

.method private super_mLeft()I
    .registers 2

    .prologue
    .line 911
    iget v0, p0, Landroid/view/SurfaceView;->mLeft:I

    return v0
.end method

with

Code:

.method private super_mLeft()I
    .registers 2

    .prologue
    .line 911
    iget v0, p0, [strike]Landroid/webkit/WebView;[/strike][COLOR="Red"]Landroid/view/View;[/COLOR]->mLeft:I

    return v0
.end method

2. and this

Code:

.method private super_mTop()I
    .registers 2

    .prologue
    .line 914
    iget v0, p0, Landroid/view/SurfaceView;->mTop:I

    return v0
.end method

with

Code:

.method private super_mTop()I
    .registers 2

    .prologue
    .line 914
    iget v0, p0, [strike]Landroid/webkit/WebView;[/strike][COLOR="Red"]Landroid/view/View;[/COLOR]->mTop:I

    return v0
.end method

3. and

Code:

   iget-object v0, v0, Landroid/view/SurfaceView;->mLocation:[I

    move-object v5, v0

    const/4 v6, 0x0

    move-object/from16 v0, p0

    iget v0, v0, Landroid/view/SurfaceView;->mLeft:I

    move v7, v0

    add-int v7, v7, p4

    aput v7, v5, v6

with

Code:

   iget-object v0, v0, Landroid/view/SurfaceView;->mLocation:[I

    move-object v5, v0

    const/4 v6, 0x0

    move-object/from16 v0, p0

    iget v0, v0, [strike]Landroid/webkit/WebView;[/strike][COLOR="Red"]Landroid/view/View;[/COLOR]->mLeft:I

    move v7, v0

    add-int v7, v7, p4

    aput v7, v5, v6

4. and last peice

Code:

    iget-object v0, v0, Landroid/view/SurfaceView;->mLocation:[I

    move-object v5, v0

    const/4 v6, 0x1

    move-object/from16 v0, p0

    iget v0, v0, Landroid/view/SurfaceView;->mTop:I

    move v7, v0

    add-int v7, v7, p5

    aput v7, v5, v6

    .line 439

with

Code:

    iget-object v0, v0, Landroid/view/SurfaceView;->mLocation:[I

    move-object v5, v0

    const/4 v6, 0x1

    move-object/from16 v0, p0

    iget v0, v0, [strike]Landroid/webkit/WebView;[/strike][COLOR="Red"]Landroid/view/View;[/COLOR]->mTop:I

    move v7, v0

    add-int v7, v7, p5

    aput v7, v5, v6

    .line 439

*NOTE* please keep my nickname in references for this solution.

Happy Modding,

- Brightidea

ringrover · Aug 8, 2011

Thanks

But how we change the code

mostyle · Aug 8, 2011

Assuming you have a deodex'd rom, baksmali browser.apk make the listed change and re-smali the code.

If you asking how to bakssmali etc, thats more drawn out..

BMWpokerAce · Aug 8, 2011

I cant wait to try this, later this evening

I m just wondering how, just this one line can fix the laggy browser?
But anyway if this realy works, i m happy.

Thank you for sharing your work.

criskelo · Aug 8, 2011

I think these misguided
the problem is in the framework.jar
example:
if you use a rom with the folder system / framework ODEX
and system / app deodex
The browser deodex not lose acceleration
but if you, deodex framework.jar, lose acceleration

BMWpokerAce · Aug 8, 2011

criskelo said:
I think these misguided
the problem is in the framework.jar
example:
if you use a rom with the folder system / framework ODEX
and system / app deodex
The browser deodex not lose acceleration
but if you, deodex framework.jar, lose acceleration

So if i understand u right, this mod makes no sense with deodexed ROM?

mostyle · Aug 8, 2011

He's saying that the fix wont work. It isn't an issue in the smali code of the Browser but rather an issue in the deodexed framework.

Also, the OP edited the original post:

I have found out that this approach is not the "real" solution to the bug. So, I am back in the lab trying to figure it out. Meanwhile, you may still use it as to my knowledge it doesn't do any harm.

GanGs_KiD · Aug 8, 2011

OMG

You are the MAN

It works ....works .....works

Thank you

Edit: it worked for 5 min's and now keep FC

brightidea · Aug 9, 2011

criskelo said:
I think these misguided
the problem is in the framework.jar
example:
if you use a rom with the folder system / framework ODEX
and system / app deodex
The browser deodex not lose acceleration
but if you, deodex framework.jar, lose acceleration

You're partly right - I found problems in the deodexed Browser that I am going to share after I fix the bugs in framework.

I am currently digging it up - hope to find the glitch soon.

brightidea · Aug 9, 2011

GanGs_KiD said:
OMG

You are the MAN

It works ....works .....works

Thank you

Edit: it worked for 5 min's and now keep FC

Sorry to disappoint - but I am still working on the fix.

- Brightidea.

criskelo · Aug 10, 2011

brightidea said:
You're partly right - I found problems in the deodexed Browser that I am going to share after I fix the bugs in framework.

I am currently digging it up - hope to find the glitch soon.

Do not know if it was understood
I say look in framework.jar

The problem is framework.jar

brightidea · Aug 10, 2011

criskelo said:
Do not know if it was understood
I say look in framework.jar

The problem is framework.jar

I found the bug for real this time - unfortunately, it's in smali.jar ..

and you were right. The fault occurs when it attempts to build framework.jar from smali files
specifically this file "android/view/SurfaceView.smali"

But I have a work-around (guranteed to work as long as the order of class fields mLeft and mTop are the same in android/view/SurfaceView.smali as android/webkit/WebViewCore$ShowRectData.smali)

Go to the first post in the thread to get the solution.

- Brightidea

intronauta · Aug 11, 2011

HAHA you did it!!

Works like a charm!

Maybe would be interesting to report this issue to jesusfreeke

very good job.

why isn't thist threat in "Original Android development" subforum????

un9a7y · Aug 11, 2011

Wow ..

U R the man ;D

criskelo · Aug 11, 2011

brightidea said:
I found the bug for real this time - unfortunately, it's in smali.jar ..
and you were right. The fault occurs when it attempts to build framework.jar from smali files
specifically this file "android/view/SurfaceView.smali"

But I have a work-around (guranteed to work as long as the order of class fields mLeft and mTop are the same in android/view/SurfaceView.smali as android/webkit/WebViewCore$ShowRectData.smali)

Go to the first post in the thread to get the solution.

- Brightidea

Well actually works

Azdian · Aug 11, 2011

Perfect!
great job brightidea!

kalpik · Aug 11, 2011

Wohoo! You're the man! Waiting for this to be incorporated in all the ROMs

Hacre · Aug 11, 2011

Well done.

antiochasylum · Aug 11, 2011

Hacre said:
Well done.

Hacre being nice...whoa. epic post.

Epic fix as well!

Sent from my 119.2 linpack SGS2

madmack · Aug 11, 2011

brightidea.. you're a genius ! thank you sir

[FIX] Updated: How to fix deodexed System Framework (slow Browser)

Senior Member

Senior Member

Senior Member

Senior Member

Inactive Recognized Developer

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Inactive Recognized Developer

Senior Member

Senior Member

Senior Member

Inactive Recognized Developer

Senior Member

Inactive Recognized Contributor

Retired Senior Recognized Developer

Recognized Contributor

Senior Member

Similar threads

Top Liked Posts