[ROM] [UNOFFICIAL] [LINARO 4.8.3] [4.4.4] [APP2SD] Carbon ROM [Update 20140817]

Search This thread

xenon92

Inactive Recognized Developer
May 20, 2013
762
3,469
shubhangrathore.com
OnePlus 9 Pro
Black-on-Trans.png


CarbonRom is an aftermarket firmware based on the Android Open Source Project. We are dedicated to fast, stable, and feature-filled roms, honesty and communication with our users, and openness with our code. We like frequent builds, with the very latest and greatest hardware support and fixes. We strive to not only provide you with the best rom we can build, but also to give back to the Android community and our fellow developers. For us, this is about creating something we can be proud of and hope you will enjoy.

Please feel free to look at, build, and use our code on CarbonDev GitHub.

Follow Carbon ROM's Gerrit and Carbon ROM's Changelog to keep yourself updated with feature additions.

We would like to thank CyanogenMod for their device trees, framework/settings mods and their code that was incorporated into this project. We also extend our gratitude to the devs whose code that we have incorporated. Proper authorship has been maintained and can be viewed on our repository.

Special thanks also go to Slim Rom for some of their features, PA, AOKP, and anyone else we may have borrowed commits from that hasn't been mentioned here. If you feel you have been unfairly left out, please - let us know.

While we make every effort to test these builds as much as possible, we are not responsible for anything that may happen to your device, family, pets, or perception of reality. We ask that you do your part to know your device and know how to recover from problems before you flash! If you have questions, ask your fellow users.




WHAT IS WORKING?
  • WiFi
  • Bluetooth
  • RIL (Calls, Mobile Data, SMS)
  • Sensors
  • GPS
  • Camera
  • Everything else not listed under "Known Issues" section




KNOWN ISSUES
  • Inbuilt screen video recorder doesn't work.
  • Only primary SIM slot works. There won't be any dual-SIM support from me. I have tried and I wasn't able to make it work successfully. If anyone else wants to contribute, ROM as well as patches are open source. Build with dual-SIM support and share with the community.

(Bugs reported by users will be updated here after they are confirmed. I may ask for a logcat to fix the bugs.)





NOTES

- Make sure you have backed up your EFS before flashing the ROM. Link in installation instructions.

- If you are not able to connect to your service network provider and can't make calls etc, try flashing the modem from your region specific firmware through ODIN. Search the threads in Galaxy Grand forums and you'll find instructions there.




Patches
(for developers only. I have already included these patches in the ROM)

Patch to frameworks/base to fix SystemUI FC on tapping settings gear for autobrightness: https://gist.github.com/xenon92/8194442
(merged in the Carbon ROM's source - https://github.com/CarbonDev/android_frameworks_base/commit/78abbb53ba07c818af69a4e3fdec1457a7cd6d2b)
Patch to frameworks/base to fix duplicate day in notification pulldown header: https://gist.github.com/xenon92/8442995 (merged - https://github.com/CarbonDev/android_frameworks_base/commit/f9a8306a97514d936bfdffa5157f2bc6f1676c0e)
Patch to kernel to enable compilation with linaro toolchain: https://gist.github.com/xenon92/8382861
Patch to frameworks/native to fix screenshots and app previews: http://review.cyanogenmod.org/53162/ (merged)
Patch to frameworks/base to fix haptic vibration feedback: https://gist.github.com/xenon92/af8df0708c39a24a9dc5

---

The following issues were fixed on Grand thanx to @pawitp and his following patches.

Patch to hardware/broadcom/libbt for bluetooth to work: https://gist.github.com/pawitp/7891380.
Patch to frameworks/native to workaround hwc issues: https://gist.github.com/pawitp/7891444.
Patch to frameworks/av to fix audio/video issues: https://gist.github.com/pawitp/7945188
Patch to packages/apps/Camera2 to fix panorama: http://review.cyanogenmod.org/#/c/55785/ (merged)
Patch to external/chromium_org to workaround hwc issues: https://gist.github.com/pawitp/7910708





Installation Instructions

Please keep in mind if a special instruction is needed it will be noted in the Changelog
  • Make a backup of your EFS. Read more HERE
  • Make sure you are either on any KitKat ROM (CM11, SlimKat, etc) or on 4.2.2 TW based ROM and NOT on 4.1.2 TW based ROM
  • Download the latest build
  • Download Gapps
  • Recommended - Full wipe and factory reset
  • Flash ROM using latest ClockworkMod recovery
  • Flash Gapps
  • Reboot.
  • Enjoy!



Update Instructions

  • Download the latest build
  • Flash it using ClockworkMod recovery
  • Wipe cache
  • Wipe dalvik cache
  • Reboot
  • Enjoy!


You may check FAQ Thread maintained by @chotu222 to get help.





DOWNLOADS


Carbon ROM

Old ROM files can be found HERE


(Please don't make mirror links of the ROM)


PA Gapps


Latest Recovery



SOURCES
Carbon ROM source can be found on Carbon ROM's Github.
Kernel source can be found on my Github.
Device tree for Carbon ROM 4.4+ can be found on my Github.


Credits
Team Carbon
CyanogenMod Team
pawitp
Kishan14, LuK1337 for haptic vibration on softkeys​

XDA:DevDB Information
Carbon ROM, ROM for the Samsung Galaxy Grand Duos i9082

Contributors
xenon92
ROM OS Version: 4.4.x KitKat
ROM Kernel: Linux 3.0.x
Based On: AOSP

Version Information
Status: Stable
Current Stable Version: 20140817
Stable Release Date: 2014-08-18

Created 2014-03-21
Last Updated 2014-08-18
 

Attachments

  • DTGVEKZ.png
    DTGVEKZ.png
    160 KB · Views: 19,427
  • M2TwltU.png
    M2TwltU.png
    21.4 KB · Views: 15,313
  • 8Y4nGxF.png
    8Y4nGxF.png
    59.9 KB · Views: 18,162
  • P4Ur3BK.png
    P4Ur3BK.png
    58.5 KB · Views: 16,915
  • J8UcjAF.png
    J8UcjAF.png
    70.9 KB · Views: 16,301
  • 0Xb1rtx.png
    0Xb1rtx.png
    45.6 KB · Views: 16,721
  • Screenshot_2014-06-20-18-51-10.png
    Screenshot_2014-06-20-18-51-10.png
    62 KB · Views: 11,826
  • Screenshot_2014-06-20-18-52-44.png
    Screenshot_2014-06-20-18-52-44.png
    65.9 KB · Views: 13,966
Last edited:

xenon92

Inactive Recognized Developer
May 20, 2013
762
3,469
shubhangrathore.com
OnePlus 9 Pro
CHANGELOG
(feature additions are by Carbon Team)



20140817


- SlimKat's Heads Up
- Merged pawitp's changes
- Switched to basketbuild.com for ROM uploads
- Other changes as per the changelog for Carbon nightlies. (changelog)


---x---x---x---


20140806


- Fix haptic vibration feedback on softkeys
- Other changes as per the changelog for Carbon nightlies. (changelog)


---x---x---x---


20140712


- Fixed bug - active call getting muted when new incoming call comes as call waiting
- Other changes as per the changelog for Carbon nightlies. (changelog)


---x---x---x---


20140620


- Android 4.4.4
- i9082 - allow apps to be moved to SD card
- Other changes as per the changelog for Carbon nightlies. (changelog)


---x---x---x---


20140615


- Android 4.4.3
- Hover from Paranoid Android
- i9082 - Fix USB tethering (thanx to pawitp)
- i9082 - Advertise Bluetooth LE capability to apps (thanx to pawitp)
- Other changes as per the changelog for Carbon nightlies. (changelog)


---x---x---x---


20140523

CLEAN FLASH IS RECOMMENDED AS I HAVE CHANGED OPTIMIZATION FLAGS.

- i9082 - Removed "Device Tunables" in Carbon Fibres
- i9082 - Fixed graphical corruption in Google Play Store (read more about it HERE)
- i9082 - Link Time Optimization (read more about it HERE)
- Other changes as per the changelog for Carbon nightlies. (changelog)


---x---x---x---


20140521

CLEAN FLASH IS RECOMMENDED.

- i9082 - Set default DPI as 180
- Compiled KERNEL and ROM using Linaro 4.8.3 toolchain
- O3 optimization flag
- Used all optimization flags from JustArchi's commit
- Other changes as per the changelog for Carbon nightlies


---x---x---x---


20140515

- i9082: Add multi-user support
- i9082: Fixed low call volume issue (thanx to pawitp)
- i9082: Add Content-Adaptive Backlight Control (CABC) settings support (thanx to pawitp)
- i9082: Removed the following apps from the ROM - OmniSwitch, CarbonDelta, ROMStats, VoicePlus, a few live wallpapers

Following feature additions by Carbon team -

- Floating window
- New theme engine
- Peek from PA
- Recents RAM circle
- Audio themes
- Bug fixes and feature additions by Carbon team
(check changelog for details)



---x---x---x---


20140407

- i9082: Fixed ART (I have fixed it on an experimental basis)
- i9082: Fix GPS satellite status display (thanx to pawitp)
- Bug fixes and feature additions by Carbon team
(check changelog for details)


---x---x---x---


20140405

ATTENTION: Swich to dalvik runtime before flashing. ART not supported in this build.

- i9082: Fix FC when video recording
- Bug fixes and feature additions from Carbon team (too many to list)
(check changelog for details)


---x---x---x---


20140314

- Added option to disable camera shutter sound (this is illegal in some states, make sure you are following your local laws regarding this feature)
- Added option to set screen timeout to “never” in quick tiles
- Added Smart Pulldown for the statusbar. This adds the ability to directly open the Quick Settings panel when there are no notifications present in the notification panel.
- Added the ability to set day and week on the data usage graph instead of only months.
- Added ability to flip phone to mute/reject a call
- Fix Dark Carbon aesthetics and color mismatches for dialer and in-call UI
- Bug fixes and feature additions from Carbon team
(check changelog for details)


---x---x---x---


20140307

- Addition of Dark Carbon
- Addition of Slim's new Power Menu
- Added Facebook contact sync
- Bug fixes and feature additions from Carbon team
(check changelog for details)


---x---x---x---




20140218

- Enabled KSM by default
- Bug fixes and feature additions from Carbon team
(check changelog for details)


---x---x---x---


20140127

- Fixed low in-call volume bug (no need to press volume down and then volume up now)
- Reverted bootanimation to the correct resolution zip of 800x480
- Fixed bootanimation stuttering - bootanimation is smoother now
- A lot of Active Display bug fixes by Carbon team
- Bug fixes and feature additions from Carbon team
(check changelog for details)


---x---x---x---


20140115

- Fix duplicate "day of the week" in the notification pulldown header
- Bug fixes and feature additions from Carbon team
(check changelog for details)


---x---x---x---


20140113

- Compiled using linaro toolchain - both ROM and kernel (even better performance and battery backup)
- Fixed bootanimation
- Fixed in-call mute button (thanx to @pawitp)
- Bug fixes and feature additions from Carbon team
(check changelog for details)


---x---x---x---


20140107

- Update to kernel 3.0.101 by pawitp
- Active display added by Carbon team
- Bug fixes and feature additions from Carbon team
(check changelog for details)


---x---x---x---


20131231

- Fix SystemUI FC on tapping settings gear for autobrightness


---x---x---x---


20131229

- Addition of new features - most noticeable is 'non-intrusive incoming call UI'
- Bug fixes from Carbon Team
- Fixed manual network search (thanx to @pawitp)


---x---x---x---


20131217

- Fixed hwcomposer lib and libtvservice_binder lib linking - ROM is visibly booting now
- Fixed screen rotation animation bug
- Fixed bluetooth
- Fixed audio artifacts
- Fixed strange bar in landscape mode
- Fixed panorama
(thanx to @pawitp for all the above fixes)

- Fixed screenshots and black app previews in recent apps


---x---x---x---


20131212

Initial build


 
Last edited:

Sulaimanshariff

Senior Member
Aug 1, 2013
1,137
379
mysore
Another awesome rom from my fav developer lve yew for all your efforts bro waiting for both the roms to be a lil stable DEFINITELY NO ETA'S!!! :thumbup:

Sent from my GT-I9082 using XDA Premium 4 mobile app
 

anantalawliet

Senior Member
Nov 9, 2013
231
59
25
Bali , Denpasar
For the one who install this rom and saying bootloop you're wrong :D , it is actually booting but the screen just show a boot animation and never goes to the screen :D

Sent from my GT-I9082 using xda app-developers app
 

xenon92

Inactive Recognized Developer
May 20, 2013
762
3,469
shubhangrathore.com
OnePlus 9 Pro
New build uploaded. 20131217
Screenshots updated in Post #2.

- Fixed hwcomposer lib and libtvservice_binder lib linking - ROM is visibly booting now
- Fixed screen rotation animation bug
- Fixed bluetooth
- Fixed audio artifacts
- Fixed strange bar in landscape mode
- Fixed panorama
(thanx to @pawitp for all the above fixes)

- Fixed screenshots and black app previews in recent apps

Halo hasn't been implemented by Carbon Team yet.
 

Top Liked Posts

  • There are no posts matching your filters.
  • 73
    Black-on-Trans.png


    CarbonRom is an aftermarket firmware based on the Android Open Source Project. We are dedicated to fast, stable, and feature-filled roms, honesty and communication with our users, and openness with our code. We like frequent builds, with the very latest and greatest hardware support and fixes. We strive to not only provide you with the best rom we can build, but also to give back to the Android community and our fellow developers. For us, this is about creating something we can be proud of and hope you will enjoy.

    Please feel free to look at, build, and use our code on CarbonDev GitHub.

    Follow Carbon ROM's Gerrit and Carbon ROM's Changelog to keep yourself updated with feature additions.

    We would like to thank CyanogenMod for their device trees, framework/settings mods and their code that was incorporated into this project. We also extend our gratitude to the devs whose code that we have incorporated. Proper authorship has been maintained and can be viewed on our repository.

    Special thanks also go to Slim Rom for some of their features, PA, AOKP, and anyone else we may have borrowed commits from that hasn't been mentioned here. If you feel you have been unfairly left out, please - let us know.

    While we make every effort to test these builds as much as possible, we are not responsible for anything that may happen to your device, family, pets, or perception of reality. We ask that you do your part to know your device and know how to recover from problems before you flash! If you have questions, ask your fellow users.




    WHAT IS WORKING?
    • WiFi
    • Bluetooth
    • RIL (Calls, Mobile Data, SMS)
    • Sensors
    • GPS
    • Camera
    • Everything else not listed under "Known Issues" section




    KNOWN ISSUES
    • Inbuilt screen video recorder doesn't work.
    • Only primary SIM slot works. There won't be any dual-SIM support from me. I have tried and I wasn't able to make it work successfully. If anyone else wants to contribute, ROM as well as patches are open source. Build with dual-SIM support and share with the community.

    (Bugs reported by users will be updated here after they are confirmed. I may ask for a logcat to fix the bugs.)





    NOTES

    - Make sure you have backed up your EFS before flashing the ROM. Link in installation instructions.

    - If you are not able to connect to your service network provider and can't make calls etc, try flashing the modem from your region specific firmware through ODIN. Search the threads in Galaxy Grand forums and you'll find instructions there.




    Patches
    (for developers only. I have already included these patches in the ROM)

    Patch to frameworks/base to fix SystemUI FC on tapping settings gear for autobrightness: https://gist.github.com/xenon92/8194442
    (merged in the Carbon ROM's source - https://github.com/CarbonDev/android_frameworks_base/commit/78abbb53ba07c818af69a4e3fdec1457a7cd6d2b)
    Patch to frameworks/base to fix duplicate day in notification pulldown header: https://gist.github.com/xenon92/8442995 (merged - https://github.com/CarbonDev/android_frameworks_base/commit/f9a8306a97514d936bfdffa5157f2bc6f1676c0e)
    Patch to kernel to enable compilation with linaro toolchain: https://gist.github.com/xenon92/8382861
    Patch to frameworks/native to fix screenshots and app previews: http://review.cyanogenmod.org/53162/ (merged)
    Patch to frameworks/base to fix haptic vibration feedback: https://gist.github.com/xenon92/af8df0708c39a24a9dc5

    ---

    The following issues were fixed on Grand thanx to @pawitp and his following patches.

    Patch to hardware/broadcom/libbt for bluetooth to work: https://gist.github.com/pawitp/7891380.
    Patch to frameworks/native to workaround hwc issues: https://gist.github.com/pawitp/7891444.
    Patch to frameworks/av to fix audio/video issues: https://gist.github.com/pawitp/7945188
    Patch to packages/apps/Camera2 to fix panorama: http://review.cyanogenmod.org/#/c/55785/ (merged)
    Patch to external/chromium_org to workaround hwc issues: https://gist.github.com/pawitp/7910708





    Installation Instructions

    Please keep in mind if a special instruction is needed it will be noted in the Changelog
    • Make a backup of your EFS. Read more HERE
    • Make sure you are either on any KitKat ROM (CM11, SlimKat, etc) or on 4.2.2 TW based ROM and NOT on 4.1.2 TW based ROM
    • Download the latest build
    • Download Gapps
    • Recommended - Full wipe and factory reset
    • Flash ROM using latest ClockworkMod recovery
    • Flash Gapps
    • Reboot.
    • Enjoy!



    Update Instructions

    • Download the latest build
    • Flash it using ClockworkMod recovery
    • Wipe cache
    • Wipe dalvik cache
    • Reboot
    • Enjoy!


    You may check FAQ Thread maintained by @chotu222 to get help.





    DOWNLOADS


    Carbon ROM

    Old ROM files can be found HERE


    (Please don't make mirror links of the ROM)


    PA Gapps


    Latest Recovery



    SOURCES
    Carbon ROM source can be found on Carbon ROM's Github.
    Kernel source can be found on my Github.
    Device tree for Carbon ROM 4.4+ can be found on my Github.


    Credits
    Team Carbon
    CyanogenMod Team
    pawitp
    Kishan14, LuK1337 for haptic vibration on softkeys​

    XDA:DevDB Information
    Carbon ROM, ROM for the Samsung Galaxy Grand Duos i9082

    Contributors
    xenon92
    ROM OS Version: 4.4.x KitKat
    ROM Kernel: Linux 3.0.x
    Based On: AOSP

    Version Information
    Status: Stable
    Current Stable Version: 20140817
    Stable Release Date: 2014-08-18

    Created 2014-03-21
    Last Updated 2014-08-18
    36
    SCREENSHOTS





    DTGVEKZ.png
    M2TwltU.png




    8Y4nGxF.png
    P4Ur3BK.png




    J8UcjAF.png
    0Xb1rtx.png




    UJ3sZVQ.png

    25
    CHANGELOG
    (feature additions are by Carbon Team)



    20140817


    - SlimKat's Heads Up
    - Merged pawitp's changes
    - Switched to basketbuild.com for ROM uploads
    - Other changes as per the changelog for Carbon nightlies. (changelog)


    ---x---x---x---


    20140806


    - Fix haptic vibration feedback on softkeys
    - Other changes as per the changelog for Carbon nightlies. (changelog)


    ---x---x---x---


    20140712


    - Fixed bug - active call getting muted when new incoming call comes as call waiting
    - Other changes as per the changelog for Carbon nightlies. (changelog)


    ---x---x---x---


    20140620


    - Android 4.4.4
    - i9082 - allow apps to be moved to SD card
    - Other changes as per the changelog for Carbon nightlies. (changelog)


    ---x---x---x---


    20140615


    - Android 4.4.3
    - Hover from Paranoid Android
    - i9082 - Fix USB tethering (thanx to pawitp)
    - i9082 - Advertise Bluetooth LE capability to apps (thanx to pawitp)
    - Other changes as per the changelog for Carbon nightlies. (changelog)


    ---x---x---x---


    20140523

    CLEAN FLASH IS RECOMMENDED AS I HAVE CHANGED OPTIMIZATION FLAGS.

    - i9082 - Removed "Device Tunables" in Carbon Fibres
    - i9082 - Fixed graphical corruption in Google Play Store (read more about it HERE)
    - i9082 - Link Time Optimization (read more about it HERE)
    - Other changes as per the changelog for Carbon nightlies. (changelog)


    ---x---x---x---


    20140521

    CLEAN FLASH IS RECOMMENDED.

    - i9082 - Set default DPI as 180
    - Compiled KERNEL and ROM using Linaro 4.8.3 toolchain
    - O3 optimization flag
    - Used all optimization flags from JustArchi's commit
    - Other changes as per the changelog for Carbon nightlies


    ---x---x---x---


    20140515

    - i9082: Add multi-user support
    - i9082: Fixed low call volume issue (thanx to pawitp)
    - i9082: Add Content-Adaptive Backlight Control (CABC) settings support (thanx to pawitp)
    - i9082: Removed the following apps from the ROM - OmniSwitch, CarbonDelta, ROMStats, VoicePlus, a few live wallpapers

    Following feature additions by Carbon team -

    - Floating window
    - New theme engine
    - Peek from PA
    - Recents RAM circle
    - Audio themes
    - Bug fixes and feature additions by Carbon team
    (check changelog for details)



    ---x---x---x---


    20140407

    - i9082: Fixed ART (I have fixed it on an experimental basis)
    - i9082: Fix GPS satellite status display (thanx to pawitp)
    - Bug fixes and feature additions by Carbon team
    (check changelog for details)


    ---x---x---x---


    20140405

    ATTENTION: Swich to dalvik runtime before flashing. ART not supported in this build.

    - i9082: Fix FC when video recording
    - Bug fixes and feature additions from Carbon team (too many to list)
    (check changelog for details)


    ---x---x---x---


    20140314

    - Added option to disable camera shutter sound (this is illegal in some states, make sure you are following your local laws regarding this feature)
    - Added option to set screen timeout to “never” in quick tiles
    - Added Smart Pulldown for the statusbar. This adds the ability to directly open the Quick Settings panel when there are no notifications present in the notification panel.
    - Added the ability to set day and week on the data usage graph instead of only months.
    - Added ability to flip phone to mute/reject a call
    - Fix Dark Carbon aesthetics and color mismatches for dialer and in-call UI
    - Bug fixes and feature additions from Carbon team
    (check changelog for details)


    ---x---x---x---


    20140307

    - Addition of Dark Carbon
    - Addition of Slim's new Power Menu
    - Added Facebook contact sync
    - Bug fixes and feature additions from Carbon team
    (check changelog for details)


    ---x---x---x---




    20140218

    - Enabled KSM by default
    - Bug fixes and feature additions from Carbon team
    (check changelog for details)


    ---x---x---x---


    20140127

    - Fixed low in-call volume bug (no need to press volume down and then volume up now)
    - Reverted bootanimation to the correct resolution zip of 800x480
    - Fixed bootanimation stuttering - bootanimation is smoother now
    - A lot of Active Display bug fixes by Carbon team
    - Bug fixes and feature additions from Carbon team
    (check changelog for details)


    ---x---x---x---


    20140115

    - Fix duplicate "day of the week" in the notification pulldown header
    - Bug fixes and feature additions from Carbon team
    (check changelog for details)


    ---x---x---x---


    20140113

    - Compiled using linaro toolchain - both ROM and kernel (even better performance and battery backup)
    - Fixed bootanimation
    - Fixed in-call mute button (thanx to @pawitp)
    - Bug fixes and feature additions from Carbon team
    (check changelog for details)


    ---x---x---x---


    20140107

    - Update to kernel 3.0.101 by pawitp
    - Active display added by Carbon team
    - Bug fixes and feature additions from Carbon team
    (check changelog for details)


    ---x---x---x---


    20131231

    - Fix SystemUI FC on tapping settings gear for autobrightness


    ---x---x---x---


    20131229

    - Addition of new features - most noticeable is 'non-intrusive incoming call UI'
    - Bug fixes from Carbon Team
    - Fixed manual network search (thanx to @pawitp)


    ---x---x---x---


    20131217

    - Fixed hwcomposer lib and libtvservice_binder lib linking - ROM is visibly booting now
    - Fixed screen rotation animation bug
    - Fixed bluetooth
    - Fixed audio artifacts
    - Fixed strange bar in landscape mode
    - Fixed panorama
    (thanx to @pawitp for all the above fixes)

    - Fixed screenshots and black app previews in recent apps


    ---x---x---x---


    20131212

    Initial build


    16
    Carbon ROM updated. 20140620.

    - Android 4.4.4
    - i9082 - allow apps to be moved to SD card
    - Other changes as per the changelog for Carbon nightlies. (changelog)
    14
    New build uploaded. 20140127.

    - Reverted bootanimation to the correct resolution zip of 800x480
    - Fixed bootanimation stuttering - bootanimation is smoother now
    - A lot of Active Display bug fixes by Carbon team
    - Bug fixes and feature additions from Carbon team
    (check changelog for details)

    There is a possible fix included in the ROM for the bug where you have to press volume down and then volume up button to get normal volume in-call. I haven't tested it. Please test the calls for a few days. I'll update known issues and changelog after it is confirmed fixed by you guys.