anyone else have the problem with the bluetooth icon? after installing this mod, the bluetooth connected icon doesn't come on, it just keeps showing the regular 'bluetooth on' icon. anyone have any ideas?
again i'm running samsung galaxy s2 hercules (tmobile usa) 2.3.6 based rom, with touchwiz.
thanks
frescoraja

Originally Posted by frescoraja

anyone else have the problem with the bluetooth icon? after installing this mod, the bluetooth connected icon doesn't come on, it just keeps showing the regular 'bluetooth on' icon. anyone have any ideas?
again i'm running samsung galaxy s2 hercules (tmobile usa) 2.3.6 based rom, with touchwiz.
thanks
frescoraja

It's more because of the incomplete decompilation and recompilation. The only fix is to wait brut.all new version of apktool.jar..

Well, this is very clever.

Is there anyway to do this on 2.1?

Originally Posted by hansip87

It's more because of the incomplete decompilation and recompilation. The only fix is to wait brut.all new version of apktool.jar..

actually i fixed the bluetooth icon problem. it was in framework.jar, the IStatusBarService$Stub.smali class. there are some lines at the end of the original code that don't appear in your tutorial, so i didn't know exactly what to do with them.. but now i figured it out!

now the only problem i have is with the browser notifications.. if i download something, i get the notification "Download complete" like normal, but if i swipe it away, it will keep coming back at random times until i press "clear" button or tap to remove it. ... .not a big deal, just some people have noticed it and want me to fix it. any ideas on what might be causing it, i'm all ears!
thanks
frescoraja

Originally Posted by frescoraja

actually i fixed the bluetooth icon problem. it was in framework.jar, the IStatusBarService$Stub.smali class. there are some lines at the end of the original code that don't appear in your tutorial, so i didn't know exactly what to do with them.. but now i figured it out!

now the only problem i have is with the browser notifications.. if i download something, i get the notification "Download complete" like normal, but if i swipe it away, it will keep coming back at random times until i press "clear" button or tap to remove it. ... .not a big deal, just some people have noticed it and want me to fix it. any ideas on what might be causing it, i'm all ears!
thanks
frescoraja

Umm.. What lines did you found? I didn't realize it

Well.. Seems like it's fixable if you fix the services object. The stub class is the placeholder of the true services class inside services.jar but I don't have the code for that. Maybe someone can go in and take a look at the code to make it similar with notificationclearall function.

sent from my white ray using XDA App

Originally Posted by hansip87

Umm.. What lines did you found? I didn't realize it

Well.. Seems like it's fixable if you fix the services object. The stub class is the placeholder of the true services class inside services.jar but I don't have the code for that. Maybe someone can go in and take a look at the code to make it similar with notificationclearall function.

sent from my white ray using XDA App

so here is what the original framework.jar IStatusBarService$Stub.smali class looked like (at the end of the file, like in step 2.1 step 4 in your tutorial)

the bold green parts are the lines that don't appear in your tutorial:

    .line 235
    :goto_19a
    const/4 v0, 0x1

    goto/16 :goto_7

    .line 233
    :cond_19d
    const/4 v0, 0x0

    invoke-virtual {p3, v0}, Landroid/os/Parcel;->writeInt(I)V

    goto :goto_19a

    .line 40
    :sswitch_data_1a2
    .sparse-switch
        0x1 -> :sswitch_f
        0x2 -> :sswitch_1c
        0x3 -> :sswitch_29
        0x4 -> :sswitch_42
        0x5 -> :sswitch_5f
        0x6 -> :sswitch_7b
        0x7 -> :sswitch_8d
        0x8 -> :sswitch_9b
        0x9 -> :sswitch_a9
        0xa -> :sswitch_b7
        0xb -> :sswitch_e1
        0xc -> :sswitch_11b
        0xd -> :sswitch_129
        0xe -> :sswitch_143
        0xf -> :sswitch_16a
        0x10 -> :sswitch_178
        0x5f4e5446 -> :sswitch_8
    .end sparse-switch
.end method

Originally, I took the bold lines from your tutorial that you're supposed to add and put them AFTER the green bold part. that is when i got the bluetooth icon error. Now, I put your code BEFORE the green bold part, and it fixed the bluetooth connected icon error. but, as i said, there is still a problem with the browser notifications disappearing permanently. the orange part is showing another small difference in the code from yours, the switch id was 1a2 in my original code, not 124 like yours, but i don't think this is causing any problems.

so this is how it looks now:

    .line 235
    :goto_19a
    const/4 v0, 0x1

    goto/16 :goto_7
	
    .end local v1           #_arg0:Ljava/lang/String;
    .end local v2           #_arg1:Ljava/lang/String;
    .end local v3           #_arg2:I
    :sswitch_1a2
    const-string v0, "com.android.internal.statusbar.IStatusBarService"

    invoke-virtual {p2, v0}, Landroid/os/Parcel;->enforceInterface(Ljava/lang/String;)V

    invoke-virtual {p2}, Landroid/os/Parcel;->readString()Ljava/lang/String;

    move-result-object v1

    .restart local v1       #_arg0:Ljava/lang/String;
    invoke-virtual {p2}, Landroid/os/Parcel;->readString()Ljava/lang/String;

    move-result-object v2

    .restart local v2       #_arg1:Ljava/lang/String;
    invoke-virtual {p2}, Landroid/os/Parcel;->readInt()I

    move-result v3

    .restart local v3       #_arg2:I
    invoke-virtual {p0, v1, v2, v3}, Lcom/android/internal/statusbar/IStatusBarService$Stub;->onNotificationClear(Ljava/lang/String;Ljava/lang/String;I)V

    invoke-virtual {p3}, Landroid/os/Parcel;->writeNoException()V
	
    const/4 v0, 0x1

    goto/16 :goto_7

    .line 233
    :cond_19d
    const/4 v0, 0x0

    invoke-virtual {p3, v0}, Landroid/os/Parcel;->writeInt(I)V

    goto :goto_19a

    .line 40
    :sswitch_data_13e
    .sparse-switch
        0x1 -> :sswitch_f
        0x2 -> :sswitch_1c
        0x3 -> :sswitch_29
        0x4 -> :sswitch_42
        0x5 -> :sswitch_5f
        0x6 -> :sswitch_7b
        0x7 -> :sswitch_8d
        0x8 -> :sswitch_9b
        0x9 -> :sswitch_a9
        0xa -> :sswitch_b7
        0xb -> :sswitch_e1
        0xc -> :sswitch_11b
        0xd -> :sswitch_129
        0xe -> :sswitch_143
        0xf -> :sswitch_16a
        0x10 -> :sswitch_178
        0x11 -> :sswitch_1a2
        0x5f4e5446 -> :sswitch_8
    .end sparse-switch
.end method

again sorry for cluttering your thread. i can remove it if you want. just curious if anything pops out at you as questionable.

thanks for looking

frescoraja

Originally Posted by frescoraja

so here is what the original framework.jar IStatusBarService$Stub.smali class looked like (at the end of the file, like in step 2.1 step 4 in your tutorial)

the bold green parts are the lines that don't appear in your tutorial:

    .line 235
    :goto_19a
    const/4 v0, 0x1

    goto/16 :goto_7

    .line 233
    :cond_19d
    const/4 v0, 0x0

    invoke-virtual {p3, v0}, Landroid/os/Parcel;->writeInt(I)V

    goto :goto_19a

    .line 40
    :sswitch_data_1a2
    .sparse-switch
        0x1 -> :sswitch_f
        0x2 -> :sswitch_1c
        0x3 -> :sswitch_29
        0x4 -> :sswitch_42
        0x5 -> :sswitch_5f
        0x6 -> :sswitch_7b
        0x7 -> :sswitch_8d
        0x8 -> :sswitch_9b
        0x9 -> :sswitch_a9
        0xa -> :sswitch_b7
        0xb -> :sswitch_e1
        0xc -> :sswitch_11b
        0xd -> :sswitch_129
        0xe -> :sswitch_143
        0xf -> :sswitch_16a
        0x10 -> :sswitch_178
        0x5f4e5446 -> :sswitch_8
    .end sparse-switch
.end method

Originally, I took the bold lines from your tutorial that you're supposed to add and put them AFTER the green bold part. that is when i got the bluetooth icon error. Now, I put your code BEFORE the green bold part, and it fixed the bluetooth connected icon error. but, as i said, there is still a problem with the browser notifications disappearing permanently. the orange part is showing another small difference in the code from yours, the switch id was 1a2 in my original code, not 124 like yours, but i don't think this is causing any problems.

so this is how it looks now:

    .line 235
    :goto_19a
    const/4 v0, 0x1

    goto/16 :goto_7
	
    .end local v1           #_arg0:Ljava/lang/String;
    .end local v2           #_arg1:Ljava/lang/String;
    .end local v3           #_arg2:I
    :sswitch_1a2
    const-string v0, "com.android.internal.statusbar.IStatusBarService"

    invoke-virtual {p2, v0}, Landroid/os/Parcel;->enforceInterface(Ljava/lang/String;)V

    invoke-virtual {p2}, Landroid/os/Parcel;->readString()Ljava/lang/String;

    move-result-object v1

    .restart local v1       #_arg0:Ljava/lang/String;
    invoke-virtual {p2}, Landroid/os/Parcel;->readString()Ljava/lang/String;

    move-result-object v2

    .restart local v2       #_arg1:Ljava/lang/String;
    invoke-virtual {p2}, Landroid/os/Parcel;->readInt()I

    move-result v3

    .restart local v3       #_arg2:I
    invoke-virtual {p0, v1, v2, v3}, Lcom/android/internal/statusbar/IStatusBarService$Stub;->onNotificationClear(Ljava/lang/String;Ljava/lang/String;I)V

    invoke-virtual {p3}, Landroid/os/Parcel;->writeNoException()V
	
    const/4 v0, 0x1

    goto/16 :goto_7

    .line 233
    :cond_19d
    const/4 v0, 0x0

    invoke-virtual {p3, v0}, Landroid/os/Parcel;->writeInt(I)V

    goto :goto_19a

    .line 40
    :sswitch_data_13e
    .sparse-switch
        0x1 -> :sswitch_f
        0x2 -> :sswitch_1c
        0x3 -> :sswitch_29
        0x4 -> :sswitch_42
        0x5 -> :sswitch_5f
        0x6 -> :sswitch_7b
        0x7 -> :sswitch_8d
        0x8 -> :sswitch_9b
        0x9 -> :sswitch_a9
        0xa -> :sswitch_b7
        0xb -> :sswitch_e1
        0xc -> :sswitch_11b
        0xd -> :sswitch_129
        0xe -> :sswitch_143
        0xf -> :sswitch_16a
        0x10 -> :sswitch_178
        0x11 -> :sswitch_1a2
        0x5f4e5446 -> :sswitch_8
    .end sparse-switch
.end method

again sorry for cluttering your thread. i can remove it if you want. just curious if anything pops out at you as questionable.

thanks for looking

frescoraja

Thanks for the info Well then again, it's vendor specific coding i suppose.. and if you look at the code, before the :cond_xxx there's always a goto before it so either you puti it before or after shouldn't affect the end result because in both cases, both will go to somewhere else, not following what's the next line after that.

I'm watching this thread close seeing as I have the same issue after applying this mod on my inspire 4g

Originally Posted by hansip87

Thanks for the info Well then again, it's vendor specific coding i suppose.. and if you look at the code, before the :cond_xxx there's always a goto before it so either you puti it before or after shouldn't affect the end result because in both cases, both will go to somewhere else, not following what's the next line after that.

i know, i don't get why it made a difference either. i can't think of anything else to try now though. i do know so far, that the bug exists for notifications from the stock web browser and dolphin web browser , but it doesn't happen when opera browser is used.

oh well, an ICS rom from a trusted developer just dropped so i probably won't be spending much more time on this.

thanks for all the help and this tutorial

Help

---

Well i have been trying this on for a month. I can get the framework to compile but not the systemui. I get errors in the statusbarservice.smali file.

I have attached the edited files. Can someone please help me ?