If I were eligible for an upgrade now . . . I probably wouldn't. For the most part, I agree with the previous response.
Aside from the Nexus 5, the major "flagships" (HTC One series, Samsung Galaxy S) are mid-cycle and we are now closer to release date of the "next" cycle (likely in May) then the the existing one. What you have now are mid-cycle odd ball devices like the One Max and One Mini, which just seem like devices released to fill the space in the schedule until the next "real" flagship.
Although I won't completely agree with some of the previous opinions on Samsung. I haven't been a big fan either, but I finally caved in last April and bought the Note 8 (since HTC is simply not in the tablet market any more, and the Note 8 really was the best option in the smaller tablet form factor). While I will agree the physical design is not as nice as HTC, its still pretty good, and on par with just about any other manufacturer out there. Yes its shiny plastic; but its also thin and svelte. And TouchWiz is not nearly as obtrusive at this point, as I thought it might be (although it certainly doesn't add much, either), and I've quite enjoyed my usage of the Note 8.
I'm not up for an upgrade until May. But even if I were, I'd still probably wait and see what the next generation has in store.
Please click the "Thanks" button if you found a post helpful!
Phone: HTC One X (AT&T version) Rooted, Bootloader Unlocked, S-Off
Tablet: Samsung Galaxy Note 8 (WiFi only) Rooted