[RANT][NEXUS & GPE] Flashable Root Scripts Should Root And Stop There!
The title pretty much says it all. It annoys the crap out of me how so many simplified root scripts can't just root the device and stop there. The system partition is not the appropriate place for anything but the absolute necessities. For people who make root scripts, I'd like to take this opportunity to remind you that, as of Android 4.3 and higher, there are exactly four files required to live on /system in order to root a device (assuming you're using SuperSU as your root app of choice, since it's the most popular by a mile):
That's it. No busybox, no Superuser.apk installed in /system, no deleting apps that you just assume nobody would ever want, no nothing. Those four files. That's it! How hard is this? Oh, and if an install-recovery.sh script already exists, then rename it to install-recovery-2.sh so it still runs. Don't just overwrite it because you assume nobody in their right mind would want to knowingly keep stock recovery.
When you start deleting stuff off of people's system partition, it makes the probability of failure for future OTA updates very high. This same thing holds true when you install busybox into /system/bin. Don't. Do. That. On that same note, don't install Superuser.apk on the system partition. Let people install it themselves from the Play Store. Just provide that as a step in your instructions. One less thing being added to one's system partition is a good thing. Rooting should be as minimal and non-disruptive as humanly possible. Once those four files are there and permissions are set appropriately, you have root and can do whatever you want.
Let busybox, system app deletions, stock recovery install scripts, etc. all be up to the individual user rather than you trying to impose something on them
Every OTA update for every Nexus and Google Experience device since the Motorola Droid at http://www.randomphantasmagoria.com/firmware
LG G3 (LG-LS990 / Sprint)
:: LS990ZV4 (Android 4.4.2 / KVT49L)
Samsung Galaxy Tab 4 8.0 (SM-T337A / AT&T)
:: T337AUCU1ANF4 (Android 4.4.2 / KOT49H)
Samsung Galaxy Note Pro 12.2 (SM-P907A / AT&T)
:: P907AUCU1AND7 (Android 4.4.2 / KOT49H)