[MOD][HOW-TO] Add Flashlight quick toggle [4.3|4.4]

The Sickness · Apr 13, 2014

LOL....I just noticed that the flashlight IS NOT in the notifications panel......but the toggle works. Man this is tripping me out. Is this correct?

Code:

    .line 666
    iget-object v0, p0, Lcom/android/settings/NotificationPanelMenu;->mConvertPanelItemstring:Ljava/util/HashMap;

    const-string v1, "Flashlight"

    const-string v2, "notification_panel_flashlight"

    const-string v1, "Flashlight"

    const-string v2, "notification_panel_flashlight"

Im just trying to figure out WHY the tile isnt showing up in notification panel.....

CNexus · Apr 13, 2014

No, that's not correct. You literally just need to copy the code that I provide.

decalman · Apr 13, 2014

The Sickness said:
LOL....I just noticed that the flashlight IS NOT in the notifications panel......but the toggle works. Man this is tripping me out. Is this correct?

On SecSettings/smali/com/android/settings i was adding the lines all the way at the bottom. i searched for

Code:

.method private makeConvertPanelName

and at the end of that section i added the needed lines

and on SecSettings/res/values/strings.xml i was also adding the needed lines all the way at the end. i looked for where the strings started to look like

Code:

<string name="notification_panel_

and i place the line here

My Tapatalk Signature

SAMERKAD · Apr 14, 2014

@CNexus how to add Smart network toggle and network restriction Toggle ? to 4.4.2 Stock ROM? rooted though on Note 3 N9005

The Sickness · Apr 14, 2014

CNexus said:
No, that's not correct. You literally just need to copy the code that I provide.

Problem was I used out dated smali mod. I updated it and I'm all good.
Thanks for your help and support.

My Kat Is Insane
Deviant Development Team Member

CNexus · Apr 14, 2014

The Sickness said:
Problem was I used out dated smali mod. I updated it and I'm all good.
Thanks for your help and support.

My Kat Is Insane
Deviant Development Team Member

:thumbup:

Netuser · Apr 17, 2014

@CNexus Thanks for this great guide, i learn some stuff

I need a little bit of your help please, I don't want to have those 2 underline bars under the icon, what part of the code should I edit/delete to get rid of it please ?

The fat one i can get rid of it by deleting and image file in my drawable folder (but maybe this image serve other purpose so I want to keep it if possible) but the thin line in 2nd screenshot is some where in your code, and I cant find it how to get rid of it

See attach screenshot:

Thanks a lot for your help

lijianjunyonghu · Apr 17, 2014

CNexus said:
:thumbup:

Can you help me? Kitkat 4.4.2 N7100:crying:

CNexus · Apr 17, 2014

Netuser said:
@CNexus Thanks for this great guide, i learn some stuff

I need a little bit of your help please, I don't want to have those 2 underline bars under the icon, what part of the code should I edit/delete to get rid of it please ?

The fat one i can get rid of it by deleting and image file in my drawable folder (but maybe this image serve other purpose so I want to keep it if possible) but the thin line in 2nd screenshot is some where in your code, and I cant find it how to get rid of it

See attach screenshot:

Thanks a lot for your help

QuickSettingButton.smali you need to set that view to GONE (0x8) using a call to setVisibility

I forget what the field that holds that view is called but it'll be something like this

Code:

iget-object v0, p0, Lcom/android/systemui/policy/quicksetting/QuickSettingButton;->FIELD_NAME_HERE:Landroid/view/View;
const v1, 0x8
invoke-virtual {v0, v1}, Landroid/view/View;->setVisibility(I)V

Netuser · Apr 18, 2014

CNexus said:
QuickSettingButton.smali you need to set that view to GONE (0x8) using a call to setVisibility

I forget what the field that holds that view is called but it'll be something like this

Code:

iget-object v0, p0, Lcom/android/systemui/policy/quicksetting/QuickSettingButton;->FIELD_NAME_HERE:Landroid/view/View; const v1, 0x8 invoke-virtual {v0, v1}, Landroid/view/View;->setVisibility(I)V

Thanks for the reply

I am sorry I know nothing about smali or java

What should i do with this code ? And how become other icons don't have underline but only the flash light ?

can you please give a little more noob instructions

Thanks

Netuser · Apr 18, 2014

@CNexus

I searched by image id and find this in Quicksetting button that refer to that image which is the Thicker underline : Can i comment or edit any part to make it not load the underline ? What about the thinner underline which is not part of any image, dont know from where it is coming

Code:

    .line 285
    iget-object v0, p0, Lcom/android/systemui/statusbar/policy/quicksetting/QuickSettingButton;->mBtnLED:Landroid/widget/ImageView;

    const v1, 0x7f0201a1

    invoke-virtual {v0, v1}, Landroid/widget/ImageView;->setImageResource(I)V

CNexus · Apr 18, 2014

Place this code immediately after the setImageResource line

Code:

const v1, 0x8
invoke-virtual {v0, v1}, Landroid/view/View;->setVisibility(I)V

Netuser · Apr 18, 2014

CNexus said:
Place this code immediately after the setImageResource line

Code:

const v1, 0x8 invoke-virtual {v0, v1}, Landroid/view/View;->setVisibility(I)V

Thanks

Ok I will try it now, But i posted the wrong code

that was for dim image

Here is the On and Off bottom bar image id that are all together :

Code:

.method public setActivateStatus(I)V
    .locals 4
    .parameter "activateStatus"

    .prologue
    const v3, 0x7f02022a

    const v2, 0x7f02022b

    .line 245
    iput p1, p0, Lcom/android/systemui/statusbar/policy/quicksetting/QuickSettingButton;->mActivateStatus:I

    .line 247
    iget v0, p0, Lcom/android/systemui/statusbar/policy/quicksetting/QuickSettingButton;->mTextID:I

    if-eqz v0, :cond_0

---------- Post added at 10:51 PM ---------- Previous post was at 10:31 PM ----------

@CNexus YESSS You are Amazing

it worked here is the code I put as you told but after v2 and v3 But now I still have that 2nd thin line left

How to get rid of that now (screenshot added, think line gone thin one is still here )?

Code:

    invoke-virtual {v0, v2}, Landroid/widget/ImageView;->setImageResource(I)V
	
	const v2, 0x8
	invoke-virtual {v0, v2}, Landroid/view/View;->setVisibility(I)V

Also I have another question, all my other toggle are not shown by ON and Off image but only 1 image called round at the end of image for exemple : tw_quick_panel_icon_airplane_round.png

Then if I turn on it will show these above mention image on a background image which is : tw_quick_panel_quick_setting_button_round_bg_on.png or if it is turn on it will show it on tw_quick_panel_quick_setting_button_round_bg_off.png

Is it possible to modify your code to do same with Flashlight meaning I have 1 image called tw_quick_panel_icon_flashlight_round.png that will show on aboive mentioned BG On and Off image instead of different On off image ? : or I am forced to use On and Off image ?

Thanks so much for all your help. I am also learning so much with all these edit

Netuser · Apr 18, 2014

@CNexus sorry to bump this, do you have any idea how to do those 2 things ?

-Remove thin underline
-Use 1 icon with flash light with On and Off background image change.

Do you need me to post any files that can help you how it is done for other toggles ?

Thanks again for all your help

CNexus · Apr 18, 2014

Netuser said:
@CNexus sorry to bump this, do you have any idea how to do those 2 things ?

-Remove thin underline
-Use 1 icon with flash light with On and Off background image change.

Do you need me to post any files that can help you how it is done for other toggles ?

Thanks again for all your help

I'm not sure...since it doesn't work like that on my device that is

I hesitate to do things that I can't test myself unless it's really simple, and this looks to require some more digging...maybe ask for help from one of your local forum devs?

Netuser · Apr 19, 2014

CNexus said:
I'm not sure...since it doesn't work like that on my device that is

I hesitate to do things that I can't test myself unless it's really simple, and this looks to require some more digging...maybe ask for help from one of your local forum devs?

Ok thanks

Will see for that part with the developer of the Rom I hope he can help me.

And what about the Thin line how can get rid of it ? Where it is coming from As I see many other who posted there Screenshot with just icons and no underline in those icons. Do you have any idea ? I also tried with plain Stock systemui and I am getting same result with that underline :S

icedventimocha · May 1, 2014

Great guide. Got the SystemUI.apk edited successfully, but when I build SecSettings.apk it will not smali file. I just copied and pasted the lines provided in the OP, not sure what I'm doing wrong. Tried with 2 versions of apktool several times with no success. Any ideas would be tits. Verizon Galaxy Note II on 4.3 touchwiz.

EDIT:Nevermind, had to have been doing something basic wrong. I guess 112th times a charm lol.

Sent from my Galaxy Note II

android.zealot.fervor · May 2, 2014

CNexus said:
Here are my working modded files: https://www.dropbox.com/s/3606fetj8ujwbhi/toggle_mod_files.zip

And here's my framework-res and twframework so you can actually decompile those files: https://www.dropbox.com/s/jdauix49e79tz3s/framework_mk3_cnex.zip

Glad you figured it out :thumbup:
Do you know what the problem was or did it just work one of those times?

Your files are romoved. Can you reupload them please ?
Thanks

1brainsurgeon · May 2, 2014

Thanks again cnexus for eliminating the need to use a 3rd party apk. Gotta have my flashlight easily accessible. It gets dark, especially on garbage-to-the-curb nights.

CNexus · May 2, 2014

android.zealot.fervor said:
Your files are romoved. Can you reupload them please ?
Thanks

What for? The method has been updated and it's extremely easy now, add to strings.xml and then copy/paste the smali for the toggle

[MOD][HOW-TO] Add Flashlight quick toggle [4.3|4.4]

Retired Recognized Developer

Senior Member

Senior Member

Senior Member

Retired Recognized Developer

Senior Member

Senior Member

Attachments

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Attachments

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Attachments

Senior Member

Similar threads

Top Liked Posts