Oh.. Sorry for that guy.. Thats really sad..
.. I liked your mods..
Edit: and yes.. Please share the source of the mod.. (I'm building my own roms and that would be pretty nice.. I even want to ask for this cause im using optimized compiler flags which don't affect your (pre)built framework.. 2nd thing is that the rom i'm building has other framework sources than official cm)..
My galaxy player works fine it is just usb data does not work. I will still be doing mods but it will be for another tablet, most likely the nook hd since the galaxy tab 3 does not have cm yet because of the closed source marvell soc.
the attached source.zip contains the mods that I did.
http://xdaforums.com/showthread.php?t=2693483 for the mod I had to do to get philz recovery to compile.
Surfaceflinger.cpp mod:
Code:
static int getEmuDensity() {
return getDensityFromProperty("qemu.sf.lcd_density"); }
static int getEmuXDensity() {
return getDensityFromProperty("qemu.sf.lcd_density.xdpi"); }
static int getEmuYDensity() {
return getDensityFromProperty("qemu.sf.lcd_density.ydpi"); }
static int getBuildXDensity() {
return getDensityFromProperty("ro.sf.lcd_density.xdpi"); }
static int getBuildYDensity() {
return getDensityFromProperty("ro.sf.lcd_density.ydpi"); }
static int getBuildDensity() {
return getDensityFromProperty("ro.sf.lcd_density"); }
};
if (type == DisplayDevice::DISPLAY_PRIMARY) {
// The density of the device is provided by a build property
float density = Density::getBuildDensity() / 160.0f;
if (density == 0) {
// the build doesn't provide a density -- this is wrong!
// use xdpi instead
ALOGE("ro.sf.lcd_density must be defined as a build property");
density = xdpi / 160.0f;
}
if (Density::getBuildXDensity()) {
// if "ro.sf.lcd_density.xdpi" is specified, it overrides xdpi
xdpi = Density::getBuildXDensity();
}
if (Density::getBuildYDensity()) {
// if "ro.sf.lcd_density.ydpi" is specified, it overrides ydpi
ydpi = Density::getBuildYDensity();
}
if (Density::getEmuXDensity()) {
// if "qemu.sf.lcd_density" is specified, it overrides everything
xdpi = Density::getEmuXDensity();
}
if (Density::getEmuYDensity()) {
// if "qemu.sf.lcd_density" is specified, it overrides everything
ydpi = Density::getEmuYDensity();
}
if (Density::getEmuDensity()) {
// if "qemu.sf.lcd_density" is specified, it overrides everything
xdpi = ydpi = density = Density::getEmuDensity();
density /= 160.0f;
}
info->density = density;
lets you set custom x and y dpi by setting ro.sf.lcd_density.xdpi and ro.sf.lcd_density.ydpi. I did this mod so I could change the screen size without having to change the dpi.
Logicaldisplay.java:
Code:
mBaseDisplayInfo.type = deviceInfo.type;
String dxres = String.valueOf(deviceInfo.width);
String dyres = String.valueOf(deviceInfo.height);
String xres = SystemProperties.get("qemu.sf.widthpixels", SystemProperties.get("ro.sf.widthpixels", dxres));
String yres = SystemProperties.get("qemu.sf.heightpixels", SystemProperties.get("ro.sf.heightpixels", dyres));
Integer xre = Integer.valueOf(xres);
Integer yre = Integer.valueOf(yres);
mBaseDisplayInfo.address = deviceInfo.address;
mBaseDisplayInfo.name = deviceInfo.name;
mBaseDisplayInfo.appWidth = xre;
mBaseDisplayInfo.appHeight = yre;
mBaseDisplayInfo.logicalWidth = xre;
mBaseDisplayInfo.logicalHeight = yre;
mBaseDisplayInfo.rotation = Surface.ROTATION_0;
mBaseDisplayInfo.refreshRate = deviceInfo.refreshRate;
mBaseDisplayInfo.logicalDensityDpi = deviceInfo.densityDpi;
mBaseDisplayInfo.physicalXDpi = deviceInfo.xDpi;
mBaseDisplayInfo.physicalYDpi = deviceInfo.yDpi;
mBaseDisplayInfo.smallestNominalAppWidth = xre;
mBaseDisplayInfo.smallestNominalAppHeight = yre;
mBaseDisplayInfo.largestNominalAppWidth = xre;
mBaseDisplayInfo.largestNominalAppHeight = yre;
mBaseDisplayInfo.ownerUid = deviceInfo.ownerUid;
mBaseDisplayInfo.ownerPackageName = deviceInfo.ownerPackageName;
mPrimaryDisplayDeviceInfo = deviceInfo;
mInfo = null;
lets you set custom screen resolution via build.prop by setting ro.sf.widthpixels and ro.sf.heightpixels. this mod can give you additional features or give you a less restrictive experience in certain apps. I did that mod so I could have a 10.1 inch tablet look with a google play compatible dpi of 120.
phonewindowmanger.java:
Code:
// Allow a system property to override this. Used by the emulator.
// See also hasNavigationBar().
String navBarOverride = SystemProperties.get("qemu.hw.mainkeys", SystemProperties.get("ro.hw.mainkeys"));
if ("1".equals(navBarOverride)) {
mHasNavigationBar = false;
} else if ("0".equals(navBarOverride)) {
mHasNavigationBar = true;
}
allows you to enable softkeys by setting ro.hw.mainkeys=0 I did that so I would not have to use qemu properties. Just copy these mods to the apporiate sections and you should be good.