[APP] HtcMusic for 2.1 ROMs

I'll look into the widget more later. I should be able to add a back-button, album art, and re-arrange the layout a bit. Then again, I might not.

At the very least, I should be able to change the widget from 4x1 to 2x2 with the song/artist info at top and pause/forward at bottom as an alternate download.

I'm working a lot on my rom (just need a few more tweaks and need to kang cyanogen's camera/video hardware fix), after that I might have a look at the Layout for the Music and Now Playing list activities of the music player so they can work in landscape.

I also noticed there's a lot of artwork for 320x240 devices that's unnecessary for the Dream. It adds size. In pre-eliminary tweaks, I got the player down to 800kb w/o roptipng, but some things broke.
Once I get all those xmls sorted out, I should be able to get it down to around 700kb w/roptipng.

I got several bugs to report.

- I have the regular music app from cyanogen 2.1 test 5 and the htc app installed. occasionally when I play music with the htc app, the regular music app will start up and play a song that I played a long time ago when I still used that app. I click on that song in the status bar (there are two different songs showing there) and it stops playing and the status disappears.
- when i exit the HTC app, I get FC and then it plays music in the background again after I hit ok for the FC and then another FC comes up and that finally kills the app.

Other than that, great work, I always loved the HTC music app when I was running the hero rom. Now all we need is the album art in the lock screen and music controls in lock screen.

Ive run into a reproducible bug: Open HTC Music, play a song for a moment, press pause, then home, open up MMS and soon you'll see a FC for the music app, it seems to be a nullpointer, possibly because its using old API calls. Heres a snippet from logcat:


/Service ( 1092): setForeground: ignoring old API call on com.htc.music.MediaPlaybackService
V/MediaPlaybackService( 1092): onStart
D/AndroidRuntime( 1092): Shutting down VM
W/dalvikvm( 1092): threadid=3: thread exiting with uncaught exception (group=0x4001e178)
E/AndroidRuntime( 1092): Uncaught handler: thread main exiting due to uncaught exception
E/AndroidRuntime( 1092): java.lang.RuntimeException: Unable to start service com.htc.music.MediaPlaybackService@43bfb5e8 with null: java.lang.NullPointerException
E/AndroidRuntime( 1092): at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:2882)
E/AndroidRuntime( 1092): at android.app.ActivityThread.access$3500(ActivityThread.java:119)
E/AndroidRuntime( 1092): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1926)
E/AndroidRuntime( 1092): at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime( 1092): at android.os.Looper.loop(Looper.java:123)
E/AndroidRuntime( 1092): at android.app.ActivityThread.main(ActivityThread.java:4363)
E/AndroidRuntime( 1092): at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime( 1092): at java.lang.reflect.Method.invoke(Method.java:521)
E/AndroidRuntime( 1092): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
E/AndroidRuntime( 1092): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
E/AndroidRuntime( 1092): at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime( 1092): Caused by: java.lang.NullPointerException
E/AndroidRuntime( 1092): at com.htc.music.MediaPlaybackService.onStart(MediaPlaybackService.java:1206)
E/AndroidRuntime( 1092): at android.app.Service.onStartCommand(Service.java:306)
E/AndroidRuntime( 1092): at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:2873)
E/AndroidRuntime( 1092): ... 10 more
I/Process ( 159): Sending signal. PID: 1092 SIG: 3
I/dalvikvm( 1092): threadid=7: reacting to signal 3
I/dalvikvm( 1092): Wrote stack trace to '/data/anr/traces.txt'




and the stack trace:





----- pid 1092 at 2010-05-21 12:18:14 -----
Cmd line: com.htc.music

DALVIK THREADS:
"main" prio=5 tid=3 NATIVE
| group="main" sCount=1 dsCount=0 s=N obj=0x4001e258 self=0xbcf0
| sysTid=1092 nice=0 sched=0/0 cgrp=default handle=-1343997136
at android.os.BinderProxy.transact(Native Method)
at android.app.ActivityManagerProxy.handleApplicationError(ActivityManagerNative.java:2376)
at com.android.internal.os.RuntimeInit.crash(RuntimeInit.java:339)
at com.android.internal.os.RuntimeInit$UncaughtHandler.uncaughtException(RuntimeInit.java:76)
at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:887)
at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:884)
at dalvik.system.NativeStart.main(Native Method)

"Binder Thread #2" prio=5 tid=13 NATIVE
| group="main" sCount=1 dsCount=0 s=N obj=0x43bb9780 self=0x123780
| sysTid=1097 nice=0 sched=0/0 cgrp=default handle=1176336
at dalvik.system.NativeStart.run(Native Method)

"Binder Thread #1" prio=5 tid=11 NATIVE
| group="main" sCount=1 dsCount=0 s=N obj=0x43bb9450 self=0x140568
| sysTid=1096 nice=0 sched=0/0 cgrp=default handle=1312040
at dalvik.system.NativeStart.run(Native Method)

"JDWP" daemon prio=5 tid=9 VMWAIT
| group="system" sCount=1 dsCount=0 s=N obj=0x43bb82a0 self=0x11e188
| sysTid=1095 nice=0 sched=0/0 cgrp=default handle=1230440
at dalvik.system.NativeStart.run(Native Method)

"Signal Catcher" daemon prio=5 tid=7 RUNNABLE
| group="system" sCount=0 dsCount=0 s=N obj=0x43bb81e8 self=0x11a418
| sysTid=1094 nice=0 sched=0/0 cgrp=default handle=1178048
at dalvik.system.NativeStart.run(Native Method)

"HeapWorker" daemon prio=5 tid=5 VMWAIT
| group="system" sCount=1 dsCount=0 s=N obj=0x42e5d238 self=0x11f8a8
| sysTid=1093 nice=0 sched=0/0 cgrp=default handle=1357296
at dalvik.system.NativeStart.run(Native Method)

----- end 1092 -----

i'm gettin both of those bugs using jubeh's also

Just confirmed the bug in either .apk (tried both, clearing dalvik each time), the one I'm mainly using has md5sum b6672d96973110ef5fc8c29e289d41a7
(from OP).

It doesn't seem to do it right after rebooting, but leaving the music app open for a while, browsing artists, albums, playing music on it, then hitting home and opening up MMS (possibly other apps) leads me to two FCs from the music app.

actually, this is what seems to be the problem to me:
I think that the Playback Service is not terminating correctly when you exit the app. I don't think it's just loading mms, but loading any other app that pushed the player service out of memory (since the main activity is paused and thus can be terminated).
For some reason, the main activity tries to re-activate the music service, but it's not bound anymore, so it HTCMusic crashes.
To fix that, we'd have to edit the source, don't think we really can fix it by just using smali...

It's calling setForeground, which is depreciated in 2.X:

http://android-developers.blogspot.com/2010/02/service-api-changes-starting-with.html

Dose any one can modify this HTC_CIME for G1 CM5 rom user？


http://xdaforums.com/showthread.php?t=672094&page=3

Thanks a lot

I jsut installed the 'fixed version'....

the_fish said:

thanks for looking it up jubeh and kernelzilla i removed it and wasn't able to reproduce it (however i wasn't able to do so before as well!) someone please check it, i removed / replaced the calls of that method:
http://www.solidfiles.com/d/ca1/download/

Click to expand...

Click to collapse

Hey,
I just installed the 'fixed version' over a clean install of SuperBad 1.3 (based on CM507 T7) and still get the FC's....

Do you need a logcat or do you have what you need - shout if you need any help, please. I REALLY love this app - if it just wants to keep running.


Thanks for the great work
Bert

the_fish said:

thanks for looking it up jubeh and kernelzilla i removed it and wasn't able to reproduce it (however i wasn't able to do so before as well!) someone please check it, i removed / replaced the calls of that method:
http://www.solidfiles.com/d/ca1/download/

Click to expand...

Click to collapse

You sir, are a gentleman and a scholar! We are close! I downloaded this version and cleared the dalvik cache but after filling up memory it still produces a pair of FCs(pid 741 and 772 below), but looking at the log they appear to be different ones:

logcat:


I/ActivityThread( 748): Publishing provider downloads: com.android.providers.downloads.DownloadProvider
I/ActivityManager( 154): Starting activity: Intent { cmp=com.android.browser/.CombinedBookmarkHistoryActivity (has extras) }
I/ActivityThread( 748): Publishing provider drm: com.android.providers.drm.DrmProvider
W/ActivityManager( 154): Activity pause timeout for HistoryRecord{43e44dc0 com.android.browser/.BrowserActivity}
W/MediaPlayer( 741): info/warning (1, 44)
W/MediaPlayer( 741): info/warning (1, 44)
V/MediaPlaybackService( 741): onStart
D/AndroidRuntime( 741): Shutting down VM
W/dalvikvm( 741): threadid=3: thread exiting with uncaught exception (group=0x4001e178)
E/AndroidRuntime( 741): Uncaught handler: thread main exiting due to uncaught exception
E/AndroidRuntime( 741): java.lang.RuntimeException: Unable to start service com.htc.music.MediaPlaybackService@43bfd578 with null: java.lang.NullPointerException
E/AndroidRuntime( 741): at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:2882)
E/AndroidRuntime( 741): at android.app.ActivityThread.access$3500(ActivityThread.java:119)
E/AndroidRuntime( 741): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1926)
E/AndroidRuntime( 741): at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime( 741): at android.os.Looper.loop(Looper.java:123)
E/AndroidRuntime( 741): at android.app.ActivityThread.main(ActivityThread.java:4363)
E/AndroidRuntime( 741): at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime( 741): at java.lang.reflect.Method.invoke(Method.java:521)
E/AndroidRuntime( 741): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
E/AndroidRuntime( 741): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
E/AndroidRuntime( 741): at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime( 741): Caused by: java.lang.NullPointerException
E/AndroidRuntime( 741): at com.htc.music.MediaPlaybackService.onStart(MediaPlaybackService.java:1206)
E/AndroidRuntime( 741): at android.app.Service.onStartCommand(Service.java:306)
E/AndroidRuntime( 741): at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:2873)
E/AndroidRuntime( 741): ... 10 more
I/Process ( 154): Sending signal. PID: 741 SIG: 3
I/dalvikvm( 741): threadid=7: reacting to signal 3
I/dalvikvm( 741): Wrote stack trace to '/data/anr/traces.txt'
I/DumpStateReceiver( 154): Added state dump to 1 crashes
I/ActivityManager( 154): Displayed activity com.android.browser/.CombinedBookmarkHistoryActivity: 2784 ms (total 2784 ms)
D/dalvikvm( 577): GC freed 140 objects / 4368 bytes in 123ms
W/ActivityManager( 154): Timeout executing service: ServiceRecord{43fcba40 com.htc.music/.MediaPlaybackService}
D/WifiService( 154): ACTION_BATTERY_CHANGED pluggedType: 2
I/Process ( 741): Sending signal. PID: 741 SIG: 9
W/InputManagerService( 154): Window already focused, ignoring focus gain of: com.android.internal.view.IInputMethodClient$Stub$Proxy@43cac430
I/ActivityManager( 154): Process com.htc.music (pid 741) has died.
W/ActivityManager( 154): Scheduling restart of crashed service com.htc.music/.MediaPlaybackService in 20000ms
I/ActivityManager( 154): Low Memory: No more background processes.


I/ActivityManager( 154): Start proc com.htc.music for service com.htc.music/.MediaPlaybackService: pid=772 uid=10102 gids={3003, 1015, 1003}
I/ActivityManager( 154): Process com.google.android.apps.genie.geniewidget (pid 577) has died.
W/ActivityManager( 154): Scheduling restart of crashed service com.google.android.apps.genie.geniewidget/.GenieRefreshService in 5000ms
I/ActivityManager( 154): Low Memory: No more background processes.
I/installd( 141): free_cache(9410960) avail 9334784
I/ActivityManager( 154): Process com.android.settings (pid 766) has died.
I/ActivityManager( 154): Low Memory: No more background processes.
D/dalvikvm( 772): GC freed 1413 objects / 174728 bytes in 192ms
I/ActivityManager( 154): Start proc android.process.media for content provider com.android.providers.media/.MediaProvider: pid=778 uid=10023 gids={1015, 1003, 2001, 3003, 1006}
I/ActivityThread( 778): Publishing provider media: com.android.providers.media.MediaProvider
V/MediaProvider( 778): Attached volume: internal
V/MediaProvider( 778): /sdcard volume ID: 148158518
V/MediaProvider( 778): Attached volume: external
I/ActivityThread( 778): Publishing provider downloads: com.android.providers.downloads.DownloadProvider
I/ActivityThread( 778): Publishing provider drm: com.android.providers.drm.DrmProvider
I/ActivityManager( 154): Start proc com.google.android.apps.genie.geniewidget for service com.google.android.apps.genie.geniewidget/.GenieRefreshService: pid=787 uid=10007 gids={3003, 1015, 1003}
W/MediaPlayer( 772): info/warning (1, 44)
W/MediaPlayer( 772): info/warning (1, 44)
V/MediaPlaybackService( 772): onStart
I/ActivityManager( 154): Process se.catharsis.android.calendar (pid 611) has died.
W/ActivityManager( 154): Scheduling restart of crashed service se.catharsis.android.calendar/.UpdateService in 5000ms
I/ActivityManager( 154): Low Memory: No more background processes.
D/AndroidRuntime( 772): Shutting down VM
W/dalvikvm( 772): threadid=3: thread exiting with uncaught exception (group=0x4001e178)
E/AndroidRuntime( 772): Uncaught handler: thread main exiting due to uncaught exception
D/dalvikvm( 721): GC freed 4080 objects / 598232 bytes in 398ms
I/ActivityThread( 787): Publishing provider com.google.android.apps.genie.geniewidget.weather: com.google.android.apps.genie.geniewidget.providers.WeatherProvider
E/AndroidRuntime( 772): java.lang.RuntimeException: Unable to start service com.htc.music.MediaPlaybackService@43c3d578 with null: java.lang.NullPointerException
E/AndroidRuntime( 772): at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:2882)
E/AndroidRuntime( 772): at android.app.ActivityThread.access$3500(ActivityThread.java:119)
E/AndroidRuntime( 772): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1926)
E/AndroidRuntime( 772): at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime( 772): at android.os.Looper.loop(Looper.java:123)
E/AndroidRuntime( 772): at android.app.ActivityThread.main(ActivityThread.java:4363)
E/AndroidRuntime( 772): at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime( 772): at java.lang.reflect.Method.invoke(Method.java:521)
E/AndroidRuntime( 772): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
E/AndroidRuntime( 772): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
E/AndroidRuntime( 772): at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime( 772): Caused by: java.lang.NullPointerException
E/AndroidRuntime( 772): at com.htc.music.MediaPlaybackService.onStart(MediaPlaybackService.java:1206)
E/AndroidRuntime( 772): at android.app.Service.onStartCommand(Service.java:306)
E/AndroidRuntime( 772): at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:2873)
E/AndroidRuntime( 772): ... 10 more
I/Process ( 154): Sending signal. PID: 772 SIG: 3
I/dalvikvm( 772): threadid=7: reacting to signal 3
I/ActivityThread( 787): Publishing provider com.google.android.apps.genie.geniewidget.newsimage: com.google.android.apps.genie.geniewidget.providers.NewsImageProvider
I/dalvikvm( 772): Wrote stack trace to '/data/anr/traces.txt'






And stack trace:

----- pid 741 at 2010-05-24 15:26:59 -----
Cmd line: com.htc.music

DALVIK THREADS:
"main" prio=5 tid=3 NATIVE
| group="main" sCount=1 dsCount=0 s=N obj=0x4001e258 self=0xbcf0
| sysTid=741 nice=0 sched=0/0 cgrp=default handle=-1343997136
at android.os.BinderProxy.transact(Native Method)
at android.app.ActivityManagerProxy.handleApplicationError(ActivityManagerNative.java:2376)
at com.android.internal.os.RuntimeInit.crash(RuntimeInit.java:339)
at com.android.internal.os.RuntimeInit$UncaughtHandler.uncaughtException(RuntimeInit.java:76)
at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:887)
at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:884)
at dalvik.system.NativeStart.main(Native Method)

"Binder Thread #2" prio=5 tid=13 NATIVE
| group="main" sCount=1 dsCount=0 s=N obj=0x43bb98d8 self=0x11cd78
| sysTid=746 nice=0 sched=0/0 cgrp=default handle=1330304
at dalvik.system.NativeStart.run(Native Method)

"Binder Thread #1" prio=5 tid=11 NATIVE
| group="main" sCount=1 dsCount=0 s=N obj=0x43bb9450 self=0x11e188
| sysTid=745 nice=0 sched=0/0 cgrp=default handle=1330104
at dalvik.system.NativeStart.run(Native Method)

"JDWP" daemon prio=5 tid=9 VMWAIT
| group="system" sCount=1 dsCount=0 s=N obj=0x43bb82a0 self=0x113828
| sysTid=744 nice=0 sched=0/0 cgrp=default handle=1128424
at dalvik.system.NativeStart.run(Native Method)

"Signal Catcher" daemon prio=5 tid=7 RUNNABLE
| group="system" sCount=0 dsCount=0 s=N obj=0x43bb81e8 self=0x142198
| sysTid=743 nice=0 sched=0/0 cgrp=default handle=1230256
at dalvik.system.NativeStart.run(Native Method)

"HeapWorker" daemon prio=5 tid=5 VMWAIT
| group="system" sCount=1 dsCount=0 s=N obj=0x42e5d7c8 self=0x10a478
| sysTid=742 nice=0 sched=0/0 cgrp=default handle=1334000
at dalvik.system.NativeStart.run(Native Method)

----- end 741 -----




----- pid 772 at 2010-05-24 15:27:59 -----
Cmd line: com.htc.music

DALVIK THREADS:
"main" prio=5 tid=3 NATIVE
| group="main" sCount=1 dsCount=0 s=N obj=0x4001e258 self=0xbcf0
| sysTid=772 nice=0 sched=0/0 cgrp=default handle=-1343997136
at android.os.BinderProxy.transact(Native Method)
at android.app.ActivityManagerProxy.handleApplicationError(ActivityManagerNative.java:2376)
at com.android.internal.os.RuntimeInit.crash(RuntimeInit.java:339)
at com.android.internal.os.RuntimeInit$UncaughtHandler.uncaughtException(RuntimeInit.java:76)
at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:887)
at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:884)
at dalvik.system.NativeStart.main(Native Method)

"Binder Thread #2" prio=5 tid=13 NATIVE
| group="main" sCount=1 dsCount=0 s=N obj=0x43bf97d8 self=0x130288
| sysTid=777 nice=0 sched=0/0 cgrp=default handle=1317640
at dalvik.system.NativeStart.run(Native Method)

"Binder Thread #1" prio=5 tid=11 NATIVE
| group="main" sCount=1 dsCount=0 s=N obj=0x43bf94f8 self=0x11f208
| sysTid=776 nice=0 sched=0/0 cgrp=default handle=1167184
at dalvik.system.NativeStart.run(Native Method)

"JDWP" daemon prio=5 tid=9 VMWAIT
| group="system" sCount=1 dsCount=0 s=N obj=0x43bf82a0 self=0x123780
| sysTid=775 nice=0 sched=0/0 cgrp=default handle=1230440
at dalvik.system.NativeStart.run(Native Method)

"Signal Catcher" daemon prio=5 tid=7 RUNNABLE
| group="system" sCount=0 dsCount=0 s=N obj=0x43bf81e8 self=0x11cd78
| sysTid=774 nice=0 sched=0/0 cgrp=default handle=1172056
at dalvik.system.NativeStart.run(Native Method)

"HeapWorker" daemon prio=5 tid=5 VMWAIT
| group="system" sCount=1 dsCount=0 s=N obj=0x42e5ae88 self=0x124f48
| sysTid=773 nice=0 sched=0/0 cgrp=default handle=1171992
at dalvik.system.NativeStart.run(Native Method)

----- end 772 -----

I agree with jubeh, it seems to happen when the app is getting pushed out of memory and I suspect MediaPlaybackService isn't handling something right when the app is left in the background with the music paused.

Still getting the pair of FCs, usually by opening the music app, playing a song, pressing pause, then home, then browser, and I go into bookmarks and scroll down, this seems to fill up memory on my phone to the point of killing the mediaplayback service, which then wants to restart because its 'STICKY'. I've been reading up on the service API changes on

http://android-developers.blogspot.com/2010/02/service-api-changes-starting-with.html

and I think it has to do with START_STICKY being the default now, while the htc music app is still using the old service.onStart and not the new service.onStartCommand, so its expecting the system to make it behave like START_NOT_STICKY would. Could we try it with START_NOT_STICKY? Many thanks for all your efforts!

I tested it out on my phone after a complete wipe, and while it took a while (had to load gmail, browser & twitter) to fill up memory but the same behavior is there, FYI.

I can't reproduce the error.
I'm testing this on my personal rom built from AOSP (with camera fixes and compcache being the only differences) and I get no force-closes, even after loading a lot of apps and having disabled any kind of extended memory.

Are you sure the error is not due to the rom you're using (it could be likely).

jubeh said:

I can't reproduce the error.
I'm testing this on my personal rom built from AOSP (with camera fixes and compcache being the only differences) and I get no force-closes, even after loading a lot of apps and having disabled any kind of extended memory.

Are you sure the error is not due to the rom you're using (it could be likely).

Click to expand...

Click to collapse

It could be some of the lowmem killer adjustments in cyanogen's kernel. What kernel are you running? & is your rom eclair or donut?

kernelzilla said:

It could be some of the lowmem killer adjustments in cyanogen's kernel. What kernel are you running? & is your rom eclair or donut?

Click to expand...

Click to collapse

Eclair, stock 2.6.29 kernel that comes with AOSP

anyone know if its possible to get the HTC Lockscreen or any other Lockscreen with music controls and artwork on 2.1?