Ok. Removed the links and comments ..
Just felt that Adam needs to be recognized for all the efforts he has spent till now
Just felt that Adam needs to be recognized for all the efforts he has spent till now
Do what you like.. Yes I started with your tree as a base, and you were given credit as such, I have given you credit for everything I used, but that's why android is an OPEN source community. Also, if you'll check the official device tree you will see that cm made me remove half of it because it wasn't necessary, the pfebuilt folder and kernel and modules, cm devices must build kernels inline. And they made me remove a lot of proprietary files they said were not necessary cause they're built in source. I was skeptical, but I made a build with the new tree and it runs perfect, better than before. The point is, don't give up.. I've been trying for months myself for official support, but I didn't give up... Your a great dev.. Keep going bro... Y'all have a great day...
Sent from my SGH-I927 using xda premium
The cm team has to fork the tree and kernel source over to the cm github. Then pulled to the cm gerrit for review. I spent two days cleaning the tree up and removing repetitive entries and unnecessary files. And resubmitting. They would review and let me know what else had to be fixed. Then they forked it over. You just have to contact the right cm dev. I've been doing this a long time and many people to this day use my work and I say great as long as I'm given credit. If someone can take my work and make it better or make it work on their device , I'm all for it, that's what android is all about. I will talk to some of the cm devs and see what I can do...
Sent from my SGH-I927 using xda premium
(Quoted from the answer got by The-Droidster.)Second, jellybean running on this device is a pretty large hack. (On top of the "hackiness", the device is still not even complete.)
This clearly describes what is the "hack" about.Core CM source was not modified with one exception. Another stagefright lib needs to be loaded, because the device uses Nvidia and Samsung codecs as well for hardware acceleration. I will push a Gerrit change about it at the weekend.
First of all, thanks everybody for the support! This means me a lot!
Yes, you have given credit at the end of your thread. This is the preferred and the appreciated way of doing so. I don't have any problems with it.
Talking about credits:
http://xdaforums.com/showthread.php?p=34332781#post34332781: Karthik's fix for camera and HW-acc. No credits.
http://xdaforums.com/showthread.php?p=35008981#post35008981: New build released on 4th Dec. I updated my repo (commit: https://github.com/Adam77Root/andro...mmit/11d995fcc7666fda0a9012bc87bc04de85794668) on 2nd Dec. You credited for mobile data, but obviously all other fixes came from there.
http://xdaforums.com/showthread.php?p=34924255#post34924255: You said that the extract-files.sh is not appropriate for the Glide. If I do a 'diff' on the two files (my one and that being on CM GitHub), I can only see changes told you by CM team. Others are all the same.
Regarding the 'diff': Here it is: http://pastebin.com/6EAzqXdd Done recursively on my latest GitHub files and CM GitHub files for Glide. There are some changes, it seems. They include:
-Changing device name from galaxyr to i927.
-Putting a './' at the beginning of each line in extract-files.sh.
-Removing some files from extract-files.sh (These are probably that you were sceptical about.).
-Adding some key layouts and modifying previous ones.
Yes, Android is an open source community. But as codeworkx says, this does not mean out-of-respect. Probably all of the changes they told you would be done for the SGR if it got supported. The changes are not difficult to do.
The only question remaining: Why does CM has a mail address to which developers can write if they don't care replying? Then they are pissed of by people writing on their G+ page. One of CyanogenMod's main goal is to support a wide variety of devices. How can they achieve this by such an attitude?
I have to contact the right CM dev: So this means I should write to all of them and someone hopefully responds? Having that e-mail address just turns out again to be pointless.
If someone can take my work and make it better: If you had looked into my files a bit deeper, you would have working camera and torch. I have even posted the camera thing in your thread at some point.
(Quoted from the answer got by The-Droidster.)
The whole hack with the device tree is actually adding some feature. Samsung OMX libs cannot be used with official libs, because they don't have support for it. I wrote in my e-mail:
This clearly describes what is the "hack" about.
Finally: Sorry for making such a long post. You can now see what I talk about. It may be a bit harsh. I don't want to insult anybody. dman3285 is in the P.A.C. and AOCP team and must surely know what he does.
It's currently being discussed internally.
If i look at adams device tree, i can see that he also kanged a lot of our work (bdaddr_read, tvout, liblights and so on) without mentioning it in the commit messaged.
But that's not really needed since he left the copyright untouched where our names are on.
So basically he used all the hard stuff from us. Setting up a device tree with makefiles and copying config files in is "kinder garten".
I think it's not fair to start fighting against the i927 guy. Both of those guys reused other peoples work.
yes you can swap it by editing build.prop file with 0 to 1 or 1 to 0 value. search it buddy. you will get it.
so adam has stopped working on our device ?:crying::crying::crying:
Yep! Got a pm from him... he is working on cm 10.1
Sent from my GT-I9103 using xda app-developers app
Adam, I LOVE YOU! :victory:
According to what I read and experienced autobrightness in CM10 is not yet working properly. I have to enable light sensor filter, otherwise the brightness will only increase not decrease. It seems that using direct light sensor values is partly broken.
With the following setup, autobrightness works on my device:
- enable light sensor filter
- Set 'reset threshold' to something different than 'none'.
- enable 'Allow light decrease'
- don't modify the number of light leves (reset to default, if you changed the amount of light leves).
Do what you like.. Yes I started with your tree as a base, and you were given credit as such, I have given you credit for everything I used, but that's why android is an OPEN source community. Also, if you'll check the official device tree you will see that cm made me remove half of it because it wasn't necessary, the pfebuilt folder and kernel and modules, cm devices must build kernels inline. And they made me remove a lot of proprietary files they said were not necessary cause they're built in source. I was skeptical, but I made a build with the new tree and it runs perfect, better than before. The point is, don't give up.. I've been trying for months myself for official support, but I didn't give up... Your a great dev.. Keep going bro... Y'all have a great day...
Sent from my SGH-I927 using xda premium
The cm team has to fork the tree and kernel source over to the cm github. Then pulled to the cm gerrit for review. I spent two days cleaning the tree up and removing repetitive entries and unnecessary files. And resubmitting. They would review and let me know what else had to be fixed. Then they forked it over. You just have to contact the right cm dev. I've been doing this a long time and many people to this day use my work and I say great as long as I'm given credit. If someone can take my work and make it better or make it work on their device , I'm all for it, that's what android is all about. I will talk to some of the cm devs and see what I can do...
Sent from my SGH-I927 using xda premium
(Quoted from the answer got by The-Droidster.)Second, jellybean running on this device is a pretty large hack. (On top of the "hackiness", the device is still not even complete.)
This clearly describes what is the "hack" about.Core CM source was not modified with one exception. Another stagefright lib needs to be loaded, because the device uses Nvidia and Samsung codecs as well for hardware acceleration. I will push a Gerrit change about it at the weekend.