BeanStalk Build *Developers ONLY* Updated 12.9.2015 - Support and Assistance Thread.

Search This thread
A

AndroidSlave

Guest
Did you try the thing I PM'd you a week ago? It was recommended by someone.

Sent from my Samsung Galaxy SVII using Tapatalk 6 Beta
 

willl03

Senior Member
Oct 25, 2008
1,530
6,659
Quebec
Did you try the thing I PM'd you a week ago? It was recommended by someone.

Sent from my Samsung Galaxy SVII using Tapatalk 6 Beta

Ah yes I tried, and it did no change unfortunatly

It's confirmed to work on pure CM build for my device, hope we can get it here

Sent from my ATARI-JAGUAR using 64bit Mathematics
 
A

AndroidSlave

Guest
Ah yes I tried, and it did no change unfortunatly

It's confirmed to work on pure CM build for my device, hope we can get it here

Sent from my ATARI-JAGUAR using 64bit Mathematics

Whats interesting is it works on pure CM builds on the n7000 note 1 too, but I also build another ROM that forks framework, trebuchet, and settings from SGT7, and the stylus gestures don't work on that either
so it must be something in framework tree wish I had a clue what
 

willl03

Senior Member
Oct 25, 2008
1,530
6,659
Quebec
Whats interesting is it works on pure CM builds on the n7000 note 1 too, but I also build another ROM that forks framework, trebuchet, and settings from SGT7, and the stylus gestures don't work on that either
so it must be something in framework tree wish I had a clue what

I see that STG7 uses the same code BeanStalk

STG7 Framework commit
https://github.com/sgt7/android_frameworks_base/commit/d8ddc09cd2a0246bc2a403c540b301373c6d974a
326 additions vs 336 in CM

STG7 Settings commit
https://github.com/sgt7/android_pac...mmit/283a1d351f90a194e980d29fff8f97fb3e8fcc2c
356 additions vs 388 in CM

And if we check BeanStalk or STG7 vs CM commit code line for line we can see it's not the same everywhere
 
Last edited:
A

AndroidSlave

Guest
I see that STG7 uses the same code BeanStalk uses

STG7 Framework commit
https://github.com/sgt7/android_frameworks_base/commit/d8ddc09cd2a0246bc2a403c540b301373c6d974a
326 additions vs 336 in CM

STG7 Settings commit
https://github.com/sgt7/android_pac...mmit/283a1d351f90a194e980d29fff8f97fb3e8fcc2c
356 additions vs 388 in CM

I talk with the main person doing the SGT7 stuff.
What in particular could give him more info as to the issue, if Scott doesn't get to it... I mean, anything in addition to what we've discussed.
 

willl03

Senior Member
Oct 25, 2008
1,530
6,659
Quebec
I talk with the main person doing the SGT7 stuff.
What in particular could give him more info as to the issue, if Scott doesn't get to it... I mean, anything in addition to what we've discussed.

Cool man,

Looks like the code is not integrated at the right / same place in SGT7 / BeanStalk vs CM

In 1/2 the framework commit, look how the "same" code is integrated differently and missing lines in BeanStalk / SGT7

For example,

CM: the code is added cleanly in
Line: 251, 253, 254, 255
https://github.com/CyanogenMod/andr...3ee9f7c0877fcfbe90a7c176481f949194fb75#L3L201

vs

Beanstalk / STG7: The code is incomplete
Line: 270
https://github.com/scotthartbti/and...cd7d22b67da51c86e320cea37dfab888df4dd2#L4R270



And take a look at the line 1878 added in BeanStalk repo here
https://github.com/scotthartbti/and...d7d22b67da51c86e320cea37dfab888df4dd2#L4R1868
There is no equivalent in CM repo

Search for "mSettingsObserver" in both CM and Beanstalk pages of Stylus gestures features (1/2) to see, you find it in one and not in the other, looks really messy
 
Last edited:
A

AndroidSlave

Guest
OK I will PM him all the info tomorrow and see if he wants to work on it or not. I know he is busy with other stuff so we will see if he has time.

Maybe a fix will come from here too.

Sent from my Samsung Galaxy SVII using Tapatalk 6 Beta
 

willl03

Senior Member
Oct 25, 2008
1,530
6,659
Quebec
OK I will PM him all the info tomorrow and see if he wants to work on it or not. I know he is busy with other stuff so we will see if he has time.

Maybe a fix will come from here too.

Sent from my Samsung Galaxy SVII using Tapatalk 6 Beta

I'll try to revert all Beanstalk stylus gestures and merge the good one when I have time

I set up a git account, forked scott's branches, merged some of my changes, but I'm not able to cherry-pick my commits

It says invalid id



Sent from my ATARI-JAGUAR using 64bit Mathematics

---------- Post added at 10:58 PM ---------- Previous post was at 10:57 PM ----------

A small bug report, the setting to change wifi and network icons color in status bar has no effect, it stays holo blue

Sent from my ATARI-JAGUAR using 64bit Mathematics
 
Last edited:

patch_Adams

Senior Member
May 21, 2013
1,250
2,070
northwoods USA
Huawei P30 Pro
OnePlus 10 Pro
I'll try to revert all Beanstalk stylus gestures and merge the good one when I have time

I set up a git account, forked scott's branches, merged some of my changes, but I'm not able to cherry-pick my commits

It says invalid id



Sent from my ATARI-JAGUAR using 64bit Mathematics

---------- Post added at 10:58 PM ---------- Previous post was at 10:57 PM ----------

A small bug report, the setting to change wifi and network icons color in status bar has no effect, it stays holo blue

Sent from my ATARI-JAGUAR using 64bit Mathematics

I wish I knew how to do all the reverting and merging. Can you walk me through it some?? I would like to get the gestures working.

Sent from my SAMSUNG-SGH-I717 using xda premium
 
A

AndroidSlave

Guest
I wish I knew how to do all the reverting and merging. Can you walk me through it some?? I would like to get the gestures working.

Sent from my SAMSUNG-SGH-I717 using xda premium

I have a script I made for it. I don't want to distribute it publicly but if you can PMme to remind me I will send you the base of it and explain how it works when I get a chance in the next few days.

Sent from my ME301T using Tapatalk 2
 
A

AndroidSlave

Guest
Anyone with a fresh repo sync getting an error building At Dash Clock? I had to remove the DashClock folder to get a build going, yet it built fine a few days ago (rebuilding to implement the privacy zip flashing fix for a user having issues)
 
Last edited:

willl03

Senior Member
Oct 25, 2008
1,530
6,659
Quebec
Anyone with a fresh repo sync getting an error building At Dash Clock? I had to remove the DashClock folder to get a build going, yet it built fine a few days ago (rebuilding to implement the privacy zip flashing fix for a user having issues)

Weird, no change to DashClock repo

I'll let you know next build I try (prob next weekend)
 
A

AndroidSlave

Guest
every time keeps failing at Dash clock
even after make clobber
still failing at dash clock @scott.hart.bti do you have a clue whats going on?

EDIT: trying to just start in a fresh folder, not sure why this is happening all the sudden...\

Even completely new folder:
make: *** [/home/asf58967/beanstalk/out/target/common/obj/APPS/DashClock_intermediates/src/R.stamp] Error 1
make: *** Waiting for unfinished jobs....
Warning: AndroidManifest.xml already defines versionCode (in http://schemas.android.com/apk/res/android); using existing value in manifest.

EDIT: even getting this now too.. what in the world is going on

target R.java/Manifest.java: Calculator (/home/asf58967/beanstalk/out/target/common/obj/APPS/Calculator_intermediates/src/R.stamp)
invalid resource directory name: packages/apps/Calculator/res/drawable-inverted-hdpi
invalid resource directory name: packages/apps/Calculator/res/drawable-inverted-mdpi
invalid resource directory name: packages/apps/Calculator/res/values-inverted
invalid resource directory name: packages/apps/Calculator/res/drawable-inverted-xhdpi
make: *** [/home/asf58967/beanstalk/out/target/common/obj/APPS/Calculator_intermediates/src/R.stamp] Error 1
make: *** Waiting for unfinished jobs....
 
Last edited:

azoller1

Senior Member
Aug 4, 2011
1,928
1,807
My Room
OnePlus 8T
im getting a weird issue on 1.261 on my nexus 7, when in landscape mode with expanded desktop off, the navbar seems like it wants to stay where it is like in portrait mode and you cant see the buttons at all, ill get s screenshot here soon
 

rwaterspf1

Senior Member
Nov 17, 2012
109
506
DURHAM, NC
every time keeps failing at Dash clock
even after make clobber
still failing at dash clock @scott.hart.bti do you have a clue whats going on?

EDIT: trying to just start in a fresh folder, not sure why this is happening all the sudden...\

Even completely new folder:
make: *** [/home/asf58967/beanstalk/out/target/common/obj/APPS/DashClock_intermediates/src/R.stamp] Error 1
make: *** Waiting for unfinished jobs....
Warning: AndroidManifest.xml already defines versionCode (in http://schemas.android.com/apk/res/android); using existing value in manifest.

EDIT: even getting this now too.. what in the world is going on

target R.java/Manifest.java: Calculator (/home/asf58967/beanstalk/out/target/common/obj/APPS/Calculator_intermediates/src/R.stamp)
invalid resource directory name: packages/apps/Calculator/res/drawable-inverted-hdpi
invalid resource directory name: packages/apps/Calculator/res/drawable-inverted-mdpi
invalid resource directory name: packages/apps/Calculator/res/values-inverted
invalid resource directory name: packages/apps/Calculator/res/drawable-inverted-xhdpi
make: *** [/home/asf58967/beanstalk/out/target/common/obj/APPS/Calculator_intermediates/src/R.stamp] Error 1
make: *** Waiting for unfinished jobs....
Give us about 20 or so lines above that error so we can see what is going on please
 
A

AndroidSlave

Guest
Give us about 20 or so lines above that error so we can see what is going on please

Every single time. I even completely erased the folder and reset up everything from scratch...
I appreciate your help
is there a way to just remove dash clock from being built? would that even help? I am unable to figure out how to set it put to not build an individual app
Code:
Aidl: framework <= frameworks/base/wifi/java/android/net/wifi/p2p/IWifiP2pManager.aidl
Aidl: framework <= frameworks/base/voip/java/android/net/sip/ISipSession.aidl
Aidl: framework <= frameworks/base/voip/java/android/net/sip/ISipSessionListener.aidl
Aidl: framework <= frameworks/base/voip/java/android/net/sip/ISipService.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IFmReceiver.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IFmTransmitter.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnStateChangedListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnStartedListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnErrorListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnScanListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnForcedPauseListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnForcedResetListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnBlockScanListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnRDSDataFoundListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnSignalStrengthListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnStereoListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnExtraCommandListener.aidl
Aidl: framework <= frameworks/base/fmradio/java/com/stericsson/hardware/fm/IOnAutomaticSwitchListener.aidl
Aidl: telephony-common <= frameworks/opt/telephony/src/java/com/android/internal/telephony/ISms.aidl
Aidl: telephony-common <= frameworks/opt/telephony/src/java/com/android/internal/telephony/ISmsMiddleware.aidl
Aidl: telephony-common <= frameworks/opt/telephony/src/java/com/android/internal/telephony/IIccPhoneBook.aidl
Install: /home/asf58967/beanstalk/out/host/linux-x86/framework/bouncycastle-host.jar
Install: /home/asf58967/beanstalk/out/host/linux-x86/bin/zipalign
target Symbolic: libexpat (/home/asf58967/beanstalk/out/target/product/n7000/symbols/system/lib/libexpat.so)
target Symbolic: libcrypto (/home/asf58967/beanstalk/out/target/product/n7000/symbols/system/lib/libcrypto.so)
Install: /home/asf58967/beanstalk/out/host/linux-x86/lib/libexpat.so
target Prebuilt: egl.cfg (/home/asf58967/beanstalk/out/target/product/n7000/obj/ETC/egl.cfg_intermediates/egl.cfg)
Copy: /home/asf58967/beanstalk/out/host/linux-x86/usr/icu/icudt48l.dat
Install: /home/asf58967/beanstalk/out/host/linux-x86/lib/libcrypto.so
target Prebuilt: bt_stack.conf (/home/asf58967/beanstalk/out/target/product/n7000/obj/ETC/bt_stack.conf_intermediates/bt_stack.conf)
target Prebuilt: bt_did.conf (/home/asf58967/beanstalk/out/target/product/n7000/obj/ETC/bt_did.conf_intermediates/bt_did.conf)
target Prebuilt: auto_pair_devlist.conf (/home/asf58967/beanstalk/out/target/product/n7000/obj/ETC/auto_pair_devlist.conf_intermediates/auto_pair_devlist.conf)
target Prebuilt: Calculator (/home/asf58967/beanstalk/out/target/common/obj/JAVA_LIBRARIES/libarity_intermediates/classes.jar)
target Prebuilt: Calculator (/home/asf58967/beanstalk/out/target/common/obj/JAVA_LIBRARIES/chartengine_intermediates/classes.jar)
target Prebuilt: Calculator (/home/asf58967/beanstalk/out/target/common/obj/JAVA_LIBRARIES/ejml_intermediates/classes.jar)
target Prebuilt: Calculator (/home/asf58967/beanstalk/out/target/common/obj/JAVA_LIBRARIES/slider_intermediates/classes.jar)
target R.java/Manifest.java: android-common-chips (/home/asf58967/beanstalk/out/target/common/obj/JAVA_LIBRARIES/android-common-chips_intermediates/src/R.stamp)
target R.java/Manifest.java: DashClock (/home/asf58967/beanstalk/out/target/common/obj/APPS/DashClock_intermediates/src/R.stamp)
Aidl: DashClock <= packages/apps/DashClock/src/com/google/android/apps/dashclock/api/IDashClockDataProvider.aidl
Aidl: DashClock <= packages/apps/DashClock/src/com/google/android/apps/dashclock/api/internal/IExtensionHost.aidl
invalid resource directory name: packages/apps/DashClock/res/color-inverted
invalid resource directory name: packages/apps/DashClock/res/drawable-inverted-hdpi
invalid resource directory name: packages/apps/DashClock/res/layout-inverted
invalid resource directory name: packages/apps/DashClock/res/drawable-inverted-mdpi
invalid resource directory name: packages/apps/DashClock/res/values-inverted
invalid resource directory name: packages/apps/DashClock/res/drawable-inverted-xhdpi
invalid resource directory name: packages/apps/DashClock/res/drawable-inverted
make: *** [/home/asf58967/beanstalk/out/target/common/obj/APPS/DashClock_intermediates/src/R.stamp] Error 1
make: *** Waiting for unfinished jobs....
Warning: AndroidManifest.xml already defines versionCode (in http://schemas.android.com/apk/res/android); using existing value in manifest.
asf58967@box:~/beanstalk$
 

willl03

Senior Member
Oct 25, 2008
1,530
6,659
Quebec
Every single time. I even completely erased the folder and reset up everything from scratch...
I appreciate your help
is there a way to just remove dash clock from being built? would that even help? I am unable to figure out how to set it put to not build an individual app

Man I just built v1.261 without any trouble :/ coming from a 100% clean, unaltered build folder to repo sync

Then I copy it, in the copied folder do my mods and build

Wish I could assist

When things went wrong in the past I deleted my whole beanstalk folder and repo sync'd it from scratch, it fixed some build errors

Sent from my ATARI-JAGUAR using 64bit Mathematics
 
Last edited:
A

AndroidSlave

Guest
Man I just built v1.261 without any trouble :/ coming from a 100% clean, unaltered build folder to repo sync

Then I copy it, in the copied folder do my mods and build

Wish I could assist

When things went wrong in the past I deleted my whole beanstalk folder and repo sync'd it from scratch, it fixed some build errors

Sent from my ATARI-JAGUAR using 64bit Mathematics

Yeah I literally erased the whole folder
Can anyone shed light on what I do to just stop it from trying to build dashclock? I can just add the all manually after
What file controls that?

Sent from my ME301T using Tapatalk 2
 

patch_Adams

Senior Member
May 21, 2013
1,250
2,070
northwoods USA
Huawei P30 Pro
OnePlus 10 Pro
Man I just built v1.261 without any trouble :/ coming from a 100% clean, unaltered build folder to repo sync

Then I copy it, in the copied folder do my mods and build

Wish I could assist

When things went wrong in the past I deleted my whole beanstalk folder and repo sync'd it from scratch, it fixed some build errors

Sent from my ATARI-JAGUAR using 64bit Mathematics

So are you doing your mods after you build?

Sent from my SAMSUNG-SGH-I717 using xda premium
 

Top Liked Posts

  • There are no posts matching your filters.
  • 48
    banner4.jpg

    This thread has been opened to help avoid clutter in the original BeanStalk thread and to provide a centralized place to assist developers and porters with any issues they may be having with providing BeanStalk versions to their devices.

    I will try my best to help out with any issue that is listed, but please remember that there are things that may be out of my control or things that im not aware of. I am hoping with creating a centralized thread for developmental discussion, other developers will also be able to assist when issues arise.

    BeanStalk sources can be found HERE

    UPDATE 12/14/2015
    FYI... Beanstalk 6.01 was launched for nexus 6 (angler) this past weekend... Please take a moment to view the thread a d follow the new OP design (obviously change what's needed for your device) if building for a new device http://xdaforums.com/nexu...2015-t3269156/

    UPDATE 12/9/2015
    Good news BeanStalk builders... After what seems like forever, its safe to say that BeanStalk is up and running and ready for android Marshmallow 6 builds. It is still based on CM as prior versions have been. I am taking a bit of a different approach this time though. Instead of having a specific menu from the main settings screen with the extras that I am adding in, I decided to integrate all the additional features into the existing CM settings menus... So added features will be in all areas of the build. I am going to be maintaining for the Nexus 6P (Angler) and plan on opening the OP Thread later this evening (time permitting of course)... The big change is going to be where the BeanStalk files are stored. With the fall of Goo manager, I had to find another file server. I am registered with a few files servers, but decided to use romwarehouse and would like to try to keep the builds from other devices stored there as well (for OTA purposes). This is the main address where the device folders will be listed http://romwarehouse.com/scott.hart.bti/beanstalk/

    Please contact me via hangouts or gmail (scott.hart.bti@gmail.com) so that I can setup your device folder and provide username and password information.

    I will need to create a new OP for the BeanStalk threads. If anyone would like to get something created, that would be a big help. Once the OP is created, I would like everyone else to use the same format.

    Important build related Info and fixes:
    BeanStalk builds will not be implementing any of the new cmparts code. Instead, BS will keep the old format with the advanced device settings options. This means that you need to make sure that your device repo has the advanced settings code available and you need to make sure you revert any changes that you pull from CM that are for the new cmparts... if you have the cmparts commits in your device repo, it will cause build errors since it wont be in the frameworks/settings repos.

    If you are a current BeanStalk builder/maintainer: I currently was setup with a website thanks to a friend of mine and it is located at www.scotthartbti.com. The main point of me setting up a website is a way to centralize all the different beanstalk builds out there. So, what im going to need from you guys... Please email me at scott.hart.bti@gmail.com, gtalk me at scott.hart.bti@gmail.com, or message me on xda with the device you build for and a link to where your zip files are located for download. I will then add a link to my website to your downloads.

    So your interested in Building/Porting for another device?! Follow this guide! **Please make sure to give proper credits and Use the layout i have in the first post.** - If you need assistance, please send me a PM, do NOT post questions in this thread. I may open a general porting/building thread in another section depending on how this goes. You must have some general experience/knowledge in this area to complete this. Building from Linux platforms. In particular Ubuntu 10.04

    Setup to build - This section can be skipped if youve ever built anything before. This is for first time build setup.
    1. From your root terminal location, type the following: sudo apt-get install curl git-core gnupg flex bison gperf libsdl1.2-dev libesd0-dev libwxgtk2.6-dev squashfs-tools build-essential zip curl libncurses5-dev zlib1g-dev sun-java6-jdk pngcrush schedtool g++-multilib lib32z1-dev lib32ncurses5-dev lib32readline5-dev gcc-4.3-multilib g++-4.3-multilib
    2. Type: mkdir ~/bin
    3. Type: PATH=~/bin:$PATH
    4. Type: curl https://dl-ssl.google.com/dl/googlesource/git-repo/repo > ~/bin/repo
    5. Type: chmod a+x ~/bin/repo

    From terminal
    1. type 'cd'. This will bring you to your root folder.
    2. type 'mkdir beanstalk'. This will create a folder named beanstalk.
    3. type 'cd beanstalk'. This will take you to the beanstalk directory created from previous step
    4. type 'repo init -u git://github.com/scotthartbti/android.git -b cm-10.1'. This will setup the folders to be synced.
    5. type 'repo sync'. This will sync the folders to your beanstalk directory. Note - This will take some time depending on internet connection. Be patient!
    6. After the repo sync finally finishes, all you need to do is add your device, kernel, vendor specific files for the device you are building for. (You must know what these are, dont bother asking me if your not sure.)
    7. Make sure all your device specific files are setup as if you were going to build for CM.
    8. Outside of terminal, navigate to beanstalk/vendor/cm. Double click on the get-prebuilts file and select run in terminal. This will fetch necessary files needed to build and place them where they need to be.
    9. Type '. build/envsetup.sh && brunch "device name"'
    10. Previous step will start building beanstalk for your device. The process takes anywhere from 1 - 3 hours depending on your computer.
    11. Once completed, it will say package complete and you will have a beanstalk named zip file in your out folder.
    12
    Good news guys. I'll start working on getting everything up to speed hopefully early next week. I decided to take a hit in the pocket and pick up a n6 so I can get started... Couldn't wait any longer on the g4. I'll start pushing to my github as soon as possible. Also im gonna start getting the official page with the graphics to use so everything looks official again.

    I'll update here with progress.

    Sent from my LG-H810 using XDA Free mobile app
    10
    Thanks for this. The cm changes have been hourly for skyrocket it seems.
    I was wondering. Will you be staying with 4.2.2 as official build until 4.3 stabilizes?

    Good question and i meant to address this earlier, but got side tracked. Since a majority of my time will need to go into 4.3, i really dont have an option but to stop development for 4.2.2. I pushed out most of the fixes last night and the jb43 branches should be ready to go. There are still a few issues i need to work out, but nothing major. Id say its about 90% working right now. You guys should be able to sync and build as long as you have all your device/kernel changes needed for the Android 4.3 system. In order to sync the new branches for 4.3, you can use the same root path as you used for 4.2.2 and follow these steps:

    repo init -u git://github.com/scotthartbti/android.git -b jb43
    repo sync

    Thats all. Your ready to build. Please note that since this is not 100 percent yet, you may want to hold off a couple days on releasing anything. I plan on officially releasing BeanStalk 4.3 tomorrow night.
    10
    Ok guys things are looking good for getting the new theme engine working on Beanstalk. Couple of bugs to work out yet but very close. I just wanted to keep you posted.
    Then I am going to build it for the One Plus and update for hammerhead.
    Take care all.
    10
    For those of you watching the github for beanstalk 4.3 (branches jb43), You have seen that i have been putting in alot of work. The past few days i have been working on squaring away the errors from merging the 4.3 source code and believe me when i say that there were a **** ton of them! But, I am glad to announce that beanstalk 4.3 is now completely building. I have not pushed out the fixes needed to build yet as i want to test everything on my end first and fix anything that may have been missed. With all that said, you should see the fixes and necessary commits pushed out here today or hopefully tomorrow at the latest. I will post once everything has been pushed to my github.

    Im not sure about any of the other devices, but i know for my device (Samsung Infuse4g) there are a few commits that are needed in order to build for Android 4.3 correctly. Please make sure that you go through and add any necessary commits needed on your end.