[Q] Push source changes to Superuser app
Recently I pull down the source code for Koushik Dutta's Superuser app. I made some changes in the source. This changes are the following:
1. SuHelper class now throws 2 kind of exceptions instead of one generic instance of Exception. I believe it is better for developing. Different exceptions, different reasons, different action to do when they are catched.
2. Fixes for several Lint's warnings.
3. Fixes in translation.
4. UI new features:
a) At the first screen you can long click at an item several actions are shown ("Allow/Deny" which changes the permission without deleting the permission, "Revoke permission", "Details" leads to the same screen as a simple click o\at an item).
b) At the details screen for every item/application and new checkbox/switch added to allow/deny superuser permission.
c) At settings screen miscellaneous settings added which refer to the pop-up dialog about the outdated su binary.
Please see the attached photos from the modified application.
I would like to ask 2 questions now:
1. Do you think that these changes are useful to you?
2. Has anyone contribute by commiting any source to this app? Should I pull the current HEAD of the from the repository or simply commit and push my changes?
Thanks in advance,
PS: Dear moderator's, I think that this thread fits better at "Android Software and Hacking General [Developers Only]" or "Android Software Development" but I was not able to post it there.