[INFO] Note to all ROM makers

---

There seems to be issues with baksmali/smali v1.2.6 when deodexing latest samsung roms (2.3.4 maybe also some 2.3.3!).

If you baksmali framework.odex and smali it back to a dex file (without changing anything) your ROM will become laggy!

Some people say its the hardware acceleration that no longer works.
The web browser becomes unusable. There have been reports that video player and camera also seems laggy.

My suggestion is NOT to deodex framework.odex! I'm sorry to say this...
I know this means no custom deodexed roms! But I do believe you will run into more problems we don't know about yet!

But you can still do mods!
Just not deodexed framework mods. You can deodex apk files in the app folder. You can also try and deodex files in the framework folder as long and you dont deodex the framework.odex file! But here you have to convert them back to odex files!

As proof I have made this mod for stock XXKG1. I have the odexed the files back to odex using the dexopt-wrapper tool.

It is not just 1.2.6, I have built from the latest source and still has problems.

I disagree 100% fwiw with OP

I have no speed issues beyond that stupid browser, and that looks just like a baksmali bug. I don't do the "quit" attitude - I will fix it...

But anyway, there is no lag or anything here, even on 2.3.4 deodexed and underclocked.

So while there may be a browser issue, I would not suggest to people not to deodex. I can provide thousands of posts of people happy with a properly Deodexed and optimised ROM...

do we know why this happens? Is there an logic explanation

Originally Posted by stian230

do we know why this happens? Is there an logic explanation

Most likely minor baksmali bug

Originally Posted by designgears

It is not just 1.2.6, I have built from the latest source and still has problems.

Maybe if we can debug using source we can figure out what goes wrong!

Originally Posted by pulser_g2

I disagree 100% fwiw with OP

I have no speed issues beyond that stupid browser, and that looks just like a baksmali bug. I don't do the "quit" attitude - I will fix it...

But anyway, there is no lag or anything here, even on 2.3.4 deodexed and underclocked.

So while there may be a browser issue, I would not suggest to people not to deodex. I can provide thousands of posts of people happy with a properly Deodexed and optimised ROM...

I hope you are right... But alot people also complains about all sorts of problems with the custom roms... and we dont really know if its related to this or not...

I spent all yesterday thinking about that...

The odex file is only valid when used with the exact BOOTCLASSPATH files. dalvik enforces this by storing a checksum of each file that the odex file is dependent on, and ensuring that the checksum for each file matches when the odex file is loaded.

When you are deodexing an apk, even if you don't need to set BOOTCLASSPATH for it (because you don't get any error msg while baksmali), by default these 5 jar are already included in the classpath: core.jar, ext.jar, framework.jar, android.policy.jar and services.jar. This means that an odex file has dependencies on every "BOOTCLASSPATH" file that is loaded when it is generated.

So i was thinking about to deodexing every apk in /system/app a part Browser.apk (i.e leaving Browser.odex) and try to figure out which jar file inside /system/framework has to remain odexed.

Maybe we can still have overscroll glow mod, renounce to have the extended power menu in order to get an HW accellerated Browser!

I don't know if it make sense for you as my english need to be improved

Originally Posted by _JKay_

I hope you are right... But alot people also complains about all sorts of problems with the custom roms... and we dont really know if its related to this or not...

You got any examples to hand?

The common issues I see are

- failing to read my install instructions

- trying to come from some other ROM without following the instructions

- trying to restore titanium backups entirely, depositing apps that are codes like half-polished turds in the phone

- pushing incorrect files into rom without knowing what they are doing

- stupid setcpu config


Am interested to see if you have found other issues, as camera and video player are confirmed by a fair number to be fine...

I swapped my phone with one running stock, and I had to tell my friend what I had done, as he was sure it was his oh, and I was underclocked to 800 max too at the time

Originally Posted by pulser_g2

You got any examples to hand?

The common issues I see are

- failing to read my install instructions

- trying to come from some other ROM without following the instructions

- trying to restore titanium backups entirely, depositing apps that are codes like half-polished turds in the phone

- pushing incorrect files into rom without knowing what they are doing

- stupid setcpu config


Am interested to see if you have found other issues, as camera and video player are confirmed by a fair number to be fine...

I swapped my phone with one running stock, and I had to tell my friend what I had done, as he was sure it was his oh, and I was underclocked to 800 max too at the time

The frameword.odex is not compiled correctly!! That's a fact!! The laggy browser proofs it. Framework.odex the largest most important file in the android framework!! And that does not concern you? Is that not a bit naive?