Post Reply

[PATCH] ICS Call echo FIX + [potential] car dock audio fix (Update II - 04/30/12)

OP fuse1820

28th April 2012, 09:39 PM   |  #1  
fuse1820's Avatar
OP Senior Member
Flag Chicago, IL
Thanks Meter: 1,445
 
320 posts
Join Date:Joined: Oct 2006
Donate to Me
More
FOR AT&T LEAK BASED ROMS ONLY. NOT FOR CM9 or gingerbread!!!

Hi all,

No more call echo

This fix uses the proper T989 audio parameters so noise suppression actually works like it should (car dock should work too in theory). On top of that is Samsung Diamond Voice Engine which really makes calls sound great.

It fixes the issue at the core, within the audio libraries. The audio paramaters and noise cancelling routines now work as they should.

UPDATED
I think I finally fixed this f$cking issue once and for all. For real this time. Try out the newest update I have attached to this post (Diamonds.zip)
This patch is a breed of libraries from the Galaxy Note and the Galaxy Blaze. It took me a very long time to put it together. But with a lot of work and hex digging I found the perfect combination.

I don't even think T-Mobile's ROM is going to sound this good

You might still have to turn down your volume a notch if you have a troublesome case, but I am going to make a bold statement and say that this should fix the problem for a 90% portion of you

Also--by its nature--this newest patch should fix the car dock audio problems. I can't test it to confirm. Please let me know if it does.

Report back with results!

Devs you are free to use. Credit is all I ask I spent lots of time on this and not enough time working on a project due tomorrow >_<

To the kind folks that donated to me in the past few days. thank you and I will thank you personally and address my PMs too. Been on and off the grid because of finals.

Cheers
Yaldak

Sent from my SAMSUNG-SGH-I727-IcyS using xda premium
Attached Files
File Type: zip DiamondsVoiceX.zip - [Click for QR Code] (478.3 KB, 2618 views)
Last edited by fuse1820; 1st May 2012 at 02:44 AM.
The Following 84 Users Say Thank You to fuse1820 For This Useful Post: [ View ]
28th April 2012, 10:05 PM   |  #2  
intricatedesign's Avatar
Senior Member
Flag Santa Fe, NM
Thanks Meter: 24
 
175 posts
Join Date:Joined: Mar 2011
More
Dear sweet baby jesus yes!! DLing, gunna see what happens! ur the effin man, seriously.
28th April 2012, 10:10 PM   |  #3  
epicroot's Avatar
Senior Member
Flag Charlotte
Thanks Meter: 142
 
555 posts
Join Date:Joined: Sep 2010
Donate to Me
More
I've made two phone calls yaldak and asked if they here an echo. They both said no..
1st call was w/ case
2nd call was w/o case

Before it was hit and miss for me some ppl would complain if echoing bothers were not..

So far so good brother

Edit 1 : have not had an oppurtunity to test compass.
Sent from my SAMSUNG-SGH-T989 using xda premium
28th April 2012, 10:12 PM   |  #4  
fuse1820's Avatar
OP Senior Member
Flag Chicago, IL
Thanks Meter: 1,445
 
320 posts
Join Date:Joined: Oct 2006
Donate to Me
More
Good to hear. Compass is still broken in this version

Did 4 test calls myself. All reported no echo.

Sent from my SAMSUNG-SGH-I727-IcyS using xda premium
28th April 2012, 10:15 PM   |  #5  
marcopolo1's Avatar
Senior Member
Flag Lima
Thanks Meter: 68
 
614 posts
Join Date:Joined: Sep 2010
great work my friend!.. i love your rom. and your fixes.. rotation, facebook font, now echo ! great!
The Following User Says Thank You to marcopolo1 For This Useful Post: [ View ]
28th April 2012, 10:16 PM   |  #6  
unlvmike's Avatar
Senior Member
Flag Las Vegas
Thanks Meter: 100
 
417 posts
Join Date:Joined: Sep 2010
More
I think TDJ already fixed this issue you should ask him for help if he'd be willing to share.

Sent from my SGH-T989 using xda premium
28th April 2012, 10:19 PM   |  #7  
-Mr. X-'s Avatar
Senior Member
Flag Ontario
Thanks Meter: 2,167
 
1,674 posts
Join Date:Joined: Apr 2007
Donate to Me
More
Quote:
Originally Posted by unlvmike

I think TDJ already fixed this issue you should ask him for help if he'd be willing to share.

Sent from my SGH-T989 using xda premium

I know people keep saying he fixed it, but if he did. I would expect he would have released it. Unless he is doing the community a disservice and trying to squander the fix for him self only for glory or what ever other reasoning.

Also to the OP. What do the display firmware in /etc have to do with the audio echo? and i understand you're trying to fix the compass so is that why the sensors lib is in there?
28th April 2012, 10:27 PM   |  #8  
gorillaz1's Avatar
Senior Member
Flag Wilmington, DE
Thanks Meter: 89
 
577 posts
Join Date:Joined: Nov 2011
More
Based on his new ROM being a beta I think TDJ is testing a fix same as Yaldak.

Hopefully they both work.

Sent from my SAMSUNG-SGH-T989 using xda premium
28th April 2012, 10:28 PM   |  #9  
Senior Member
Thanks Meter: 299
 
1,794 posts
Join Date:Joined: Jan 2009
Seems legit, my wife won't hate talking to me! Do you drink? If so, what's your drink of choice? If not, I'll buy you a burger.

Here's something to show my gratitude - 0LC82576P94652635.
Last edited by daveid; 28th April 2012 at 10:32 PM.
The Following User Says Thank You to daveid For This Useful Post: [ View ]
28th April 2012, 10:29 PM   |  #10  
fuse1820's Avatar
OP Senior Member
Flag Chicago, IL
Thanks Meter: 1,445
 
320 posts
Join Date:Joined: Oct 2006
Donate to Me
More
Quote:
Originally Posted by unlvmike

I think TDJ already fixed this issue you should ask him for help if he'd be willing to share.

Sent from my SGH-T989 using xda premium

The approach used in the Darkside ROM is different. I did a library comparison to verify it.

While the approach should work because it appears to reverse the noise redcution switch (hence why the TDJ says to keep it on), this approach fixes the problem at its core--audio library side. Noise reduction will work exactly as it did in Gingerbread. Some people in that thread are still reporting the call echo issue because the audio paramters are off in all of the Skyrocket-based roms.

A LOT of work and experimenting was done to narrow it down to this one stupid file.

Quote:
Originally Posted by -Mr. X-

I know people keep saying he fixed it, but if he did. I would expect he would have released it. Unless he is doing the community a disservice and trying to squander the fix for him self only for glory or what ever other reasoning.

Also to the OP. What do the display firmware in /etc have to do with the audio echo? and i understand you're trying to fix the compass so is that why the sensors lib is in there?

There is no display firmware. That's sensor firmware. This is preliminary work toward fixing the compass, as such it is a work in progress. It's not a beautified patch just yet

Quote:

Seems legit, my wife won't hate talking to me! Do you drink? If so, what's your drink of choice? If not, I'll buy you a burger.

A beer will do my friend

The Following User Says Thank You to fuse1820 For This Useful Post: [ View ]
Post Reply Subscribe to Thread
Previous Thread Next Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes


Top Threads in T-Mobile Samsung Galaxy S II Android Development by ThreadRank