Welcome to XDA

Search to go directly to your device's forum

Register an account

Unlock full posting privileges

Ask a question

No registration required
Thread Closed

Xposed - Legacy thread. Don't panic, Xposed is still here.

OP rovo89

6th April 2012, 08:24 PM   |  #21  
rovo89's Avatar
OP Senior Recognized Developer
Thanks Meter: 15,402
 
2,386 posts
Join Date:Joined: Jan 2012
More
Do you have Busybox installed? Or rather, do you have an /sbin/sh executable? The script is executed by /sbin/sh, which is linked to /sbin/busybox on my phone.
The Following User Says Thank You to rovo89 For This Useful Post: [ View ]
6th April 2012, 08:32 PM   |  #22  
Brotuck's Avatar
Senior Member
Flag Rotterdam
Thanks Meter: 362
 
1,424 posts
Join Date:Joined: Dec 2010
More
Yes busybox is installed (double checked)
version is 1.19.4-Stericson
6th April 2012, 08:46 PM   |  #23  
rovo89's Avatar
OP Senior Recognized Developer
Thanks Meter: 15,402
 
2,386 posts
Join Date:Joined: Jan 2012
More
I have the same.. but I'm not sure whether the link from /sbin/sh is automatically there. So I have checked the LPQ stock image and found out that /system/bin/sh is a part of it. I changed the references to it. Could you try that please?
Attached Files
File Type: apk XposedInstaller.apk - [Click for QR Code] (66.2 KB, 1439 views)
The Following 2 Users Say Thank You to rovo89 For This Useful Post: [ View ]
6th April 2012, 09:16 PM   |  #24  
Brotuck's Avatar
Senior Member
Flag Rotterdam
Thanks Meter: 362
 
1,424 posts
Join Date:Joined: Dec 2010
More
Installation succes !

First message was:



So i thought install again and i got:


After that the program still said not installed, but i decided to reboot and after thatthe program said installed.
The Following User Says Thank You to Brotuck For This Useful Post: [ View ]
6th April 2012, 10:01 PM   |  #25  
rovo89's Avatar
OP Senior Recognized Developer
Thanks Meter: 15,402
 
2,386 posts
Join Date:Joined: Jan 2012
More
Thanks for the feedback! I hadn't thought of the commands like touch and chown that are executed by the script. I have also other versions of these. So now I changed it to always use the versions from /system/bin. I got the same errors then and corrected them. Also, the versions are now updated when you install.

I will update the first post with the new installer. You will probably need to reinstall, because the permissions could not be set correctly.

PS: Which ROM is that?
The Following 3 Users Say Thank You to rovo89 For This Useful Post: [ View ]
6th April 2012, 10:13 PM   |  #26  
Brotuck's Avatar
Senior Member
Flag Rotterdam
Thanks Meter: 362
 
1,424 posts
Join Date:Joined: Dec 2010
More
I will test the new apk no problem.
I am running xwlp4 odexed, rooted with speedmod

--edit --

Uninstalled and rebooted
Installed new version from fp and got this


Rebooted and xposed tells me installed
Last edited by Brotuck; 6th April 2012 at 10:22 PM.
7th April 2012, 07:49 PM   |  #27  
Senior Member
Thanks Meter: 54
 
273 posts
Join Date:Joined: Oct 2010
what about performance, and battery usage?
what are your thoughts on that?
8th April 2012, 10:08 AM   |  #28  
rovo89's Avatar
OP Senior Recognized Developer
Thanks Meter: 15,402
 
2,386 posts
Join Date:Joined: Jan 2012
More
Battery impact should be close to zero. Xposed does not require any services or additional wakelocks. Also it does no polling (frequent checks for a certain state). There is a small initialization phase, afterwards it gets only called when one of the hooked methods is about to be executed. So it does not prevent deep sleep because it gets only triggered by apps/services running anyway.

This of course depends on how the modules are implemented. The red clock example hooks a specialized method that is only called when the clock text is updated (once a minute). If it instead hooked a very generic method like setText, it would be called more often and it would have to execute more new code to find out if it has to do something.

The same applies to performance. If the developer is specific with the method hooks and the ratio of original to additional code is sensible, the impact will be low.

These are mainly thoughts as I could not test battery impact over a longer period yet (too much develop and restarts etc). But I did not feel a performance impact from the clock example, so the framework should be fine.
The Following User Says Thank You to rovo89 For This Useful Post: [ View ]
8th April 2012, 01:41 PM   |  #29  
Junior Member
Thanks Meter: 1
 
27 posts
Join Date:Joined: Mar 2011
More
Thumbs up
So I've installed the apk and red clock test one aswell. It works fine on CM9 and seems like a great project.
9th April 2012, 01:34 PM   |  #30  
Senior Member
Thanks Meter: 28
 
205 posts
Join Date:Joined: Dec 2005
More
Just a quick (maybe dumb) question/idea:
Would a module build with PDroid work with this?
I think PDroid changes some framework stuff and so we could have an easy way to intigrate it's privacy fetaures into our android rom (without using this "smali" patch thing on every rom update-zip we install)

Link to the thread is here:
http://forum.xda-developers.com/show....php?t=1357056

(And here ICS specific thread: http://forum.xda-developers.com/show....php?t=1554960 )


PDroid is changing framework.jar, services.jar, core.jar i think!

Thank you for reading and sorry for my bad english
Last edited by wooki; 9th April 2012 at 01:39 PM. Reason: Additional informations

The Following User Says Thank You to wooki For This Useful Post: [ View ]
Thread Closed Subscribe to Thread

Tags
don't ask questions about modules here!!!, framework, xposed
Previous Thread Next Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes