FORUMS
Remove All Ads from XDA

[DEV][PATCH] KCAL - Advanced color control for Qualcomm MDSS 8x10/8x26/8974/8084/8939

1,784 posts
Thanks Meter: 5,765
 
By savoca, Inactive Recognized Developer on 16th February 2015, 09:07 AM
Post Reply Email Thread
16th February 2015, 06:38 PM |#11  
savoca's Avatar
OP Inactive Recognized Developer
Flag Pasadena
Thanks Meter: 5,765
 
Donate to Me
More
Quote:
Originally Posted by franciscofranco

On Shamu I can't get anything to work besides the usual RGB and inverted.

Quote:
Originally Posted by flar2

Sweet. I'll try it on HTC m8 and Nexus 6 this week.

Sat/Hue/Val/Cont use the picture adjustment feature, and on APQ8084 and beyond it's been moved to a 2nd version of Qcom's picture adjustment. I don't have any of those devices so I didn't attempt to add support - but here's a blind patch you can try to add support or use for reference:
https://github.com/savoca/kernel-msm...e52b448b39fc98
(This patch is assuming the scaling for PA v2 is the same as v1, it's very possible that has changed - but again, no device in hand, not much I can find out)

Quote:
Originally Posted by neobuddy89

Great work @savoca
How to check MDSS_MDP_HW_REV? Any idea which is for Hammerhead and Shamu?

First code block in the OP has a reference list.
The Following 2 Users Say Thank You to savoca For This Useful Post: [ View ] Gift savoca Ad-Free
16th February 2015, 07:16 PM |#12  
GalaticStryder's Avatar
Senior Member
Flag Porto Alegre
Thanks Meter: 4,764
 
Donate to Me
More
I'll try to add it on my G2 kernel, let's see how good is this...
+1 savoca
16th February 2015, 07:17 PM |#13  
Snepsts's Avatar
Senior Member
Flag St. Louis, MO
Thanks Meter: 560
 
Donate to Me
More
Looks like for newer Qualcomms, good work! Unfortunately my device is back on APQ8064T, but always nice to see innovation for all devices!
16th February 2015, 07:23 PM |#14  
drive2droad's Avatar
Senior Member
Flag Delhi
Thanks Meter: 226
 
More
Well i have a Redmi 1S with a Qualcomm Snapdragon 400 chipset , i know this might be stupid to ask but will it work ??
16th February 2015, 08:03 PM |#15  
@savoca I merged your patches on shamu, at least RGB, invert and so on work echo values.
Can't test your app, it crashes when opening...
Attached Files
File Type: txt color_control.txt - [Click for QR Code] (5.3 KB, 504 views)
The Following User Says Thank You to eng.stk For This Useful Post: [ View ] Gift eng.stk Ad-Free
16th February 2015, 08:05 PM |#16  
Tommy-Geenexus's Avatar
Senior Member
Flag I live on a Stone Hill.
Thanks Meter: 2,582
 
Donate to Me
More
Quote:
Originally Posted by djvita

any support for first gen krait?

Anything released before msm8974 doesn't use MDSS display driver and can't be supported.
The Following User Says Thank You to Tommy-Geenexus For This Useful Post: [ View ] Gift Tommy-Geenexus Ad-Free
16th February 2015, 08:13 PM |#17  
savoca's Avatar
OP Inactive Recognized Developer
Flag Pasadena
Thanks Meter: 5,765
 
Donate to Me
More
Quote:
Originally Posted by eng.stk

@savoca I merged your patches on shamu, at least RGB, invert and so on work echo values.
Can't test your app, it crashes when opening...

Check this post for info on HW_REV_103 (APQ8084) - you can test the patch there.

As for the app, never happened to me - I'd gladly accept a log.
16th February 2015, 08:41 PM |#18  
Quote:
Originally Posted by savoca

Check this post for info on HW_REV_103 (APQ8084) - you can test the patch there.

As for the app, never happened to me - I'd gladly accept a log.

Sorry mate I added a log but was on .log and now I put .txt so xda upload doesn't derp it

I added the said patch also, but would like to test with the app.
16th February 2015, 08:46 PM |#19  
savoca's Avatar
OP Inactive Recognized Developer
Flag Pasadena
Thanks Meter: 5,765
 
Donate to Me
More
Quote:
Originally Posted by eng.stk

Sorry mate I added a log but was on .log and now I put .txt so xda upload doesn't derp it

I added the said patch also, but would like to test with the app.

Are you using a ROM with support for RGB calibration? If so the selinux/contexts it may hold with the kcal sysfs path could prevent the app from using them. You can either pull all references to kcal out of the ramdisk, or use a root shell for now.

I'd also like to hear your results on pa_v2 control with N6.
16th February 2015, 08:58 PM |#20  
neobuddy89's Avatar
Recognized Developer / Recognized Contributor
Flag APQ8084
Thanks Meter: 22,861
 
Donate to Me
More
@savoca

Tested. Works great.
One thing.. on click on "Restore" ... Gamma value for RED autosets to 86 instead of 256.
The Following User Says Thank You to neobuddy89 For This Useful Post: [ View ]
16th February 2015, 09:02 PM |#21  
Quote:
Originally Posted by savoca

Are you using a ROM with support for RGB calibration? If so the selinux/contexts it may hold with the kcal sysfs path could prevent the app from using them. You can either pull all references to kcal out of the ramdisk, or use a root shell for now.

I'd also like to hear your results on pa_v2 control with N6.

yep I have CM12 stuff added for kcal:
# for Settings' access to DisplayColorCalibration
/sys/devices/platform/kcal_ctrl.0/kcal ubject_r:sysfs_display:s0
/sys/devices/platform/kcal_ctrl.0/kcal_ctrl ubject_r:sysfs_display:s0

# Display color calibration
chown system system /sys/devices/platform/kcal_ctrl.0/kcal
chown system system /sys/devices/platform/kcal_ctrl.0/kcal_ctrl
The Following User Says Thank You to eng.stk For This Useful Post: [ View ] Gift eng.stk Ad-Free
Post Reply Subscribe to Thread

Guest Quick Reply (no urls or BBcode)
Message:
Previous Thread Next Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes