FORUMS
Remove All Ads from XDA

[DEV][PATCH] KCAL - Advanced color control for Qualcomm MDSS 8x10/8x26/8974/8084/8939

1,784 posts
Thanks Meter: 5,765
 
By savoca, Inactive Recognized Developer on 16th February 2015, 09:07 AM
Post Reply Email Thread
16th February 2015, 09:02 PM |#21  
Quote:
Originally Posted by savoca

Are you using a ROM with support for RGB calibration? If so the selinux/contexts it may hold with the kcal sysfs path could prevent the app from using them. You can either pull all references to kcal out of the ramdisk, or use a root shell for now.

I'd also like to hear your results on pa_v2 control with N6.

yep I have CM12 stuff added for kcal:
# for Settings' access to DisplayColorCalibration
/sys/devices/platform/kcal_ctrl.0/kcal ubject_r:sysfs_display:s0
/sys/devices/platform/kcal_ctrl.0/kcal_ctrl ubject_r:sysfs_display:s0

# Display color calibration
chown system system /sys/devices/platform/kcal_ctrl.0/kcal
chown system system /sys/devices/platform/kcal_ctrl.0/kcal_ctrl
The Following User Says Thank You to eng.stk For This Useful Post: [ View ] Gift eng.stk Ad-Free
16th February 2015, 09:04 PM |#22  
savoca's Avatar
OP Inactive Recognized Developer
Flag Pasadena
Thanks Meter: 5,765
 
Donate to Me
More
Quote:
Originally Posted by neobuddy89

@savoca

Tested. Works great.
One thing.. on click on "Restore" ... Gamma value for RED autosets to 86 instead of 256.

You tested apq8084 + pa_v2 (hue/sat/etc...) controls working properly? Can you post a video just for my peace of mind?

Can you double check '86' wasn't saved earlier? When you save it just puts the seekbar progress in sharedpref, and on restore it just sends them right back.
The Following User Says Thank You to savoca For This Useful Post: [ View ] Gift savoca Ad-Free
16th February 2015, 09:37 PM |#23  
neobuddy89's Avatar
Recognized Developer / Recognized Contributor
Flag APQ8084
Thanks Meter: 22,861
 
Donate to Me
More
Quote:
Originally Posted by savoca

You tested apq8084 + pa_v2 (hue/sat/etc...) controls working properly? Can you post a video just for my peace of mind?

Can you double check '86' wasn't saved earlier? When you save it just puts the seekbar progress in sharedpref, and on restore it just sends them right back. /:

Tested on Hammerhead.
For some reason... on first test.. the value for red gamma went to 86 on restore.
When I closed app and retested... value of red gamma restores properly.... will let other users report if really there is any issue.
Saturation works fine as well. Unfortunately, saturation change cannot be seen in below video since their is no graphics to test.

Here is video:
https://www.youtube.com/watch?v=yQ_S...ature=youtu.be
@savoca: Can you include any graphic in app? It will be easier for all to check this awesome development.
The Following 3 Users Say Thank You to neobuddy89 For This Useful Post: [ View ]
16th February 2015, 09:46 PM |#24  
Quote:
Originally Posted by savoca

Are you using a ROM with support for RGB calibration? If so the selinux/contexts it may hold with the kcal sysfs path could prevent the app from using them. You can either pull all references to kcal out of the ramdisk, or use a root shell for now.

I'd also like to hear your results on pa_v2 control with N6.

Well app is working , but on shamu so far only RGB and invert controls work.
16th February 2015, 09:51 PM |#25  
savoca's Avatar
OP Inactive Recognized Developer
Flag Pasadena
Thanks Meter: 5,765
 
Donate to Me
More
Quote:
Originally Posted by neobuddy89

Tested on Hammerhead.
For some reason... on first test.. the value for red gamma went to 86 on restore.
When I closed app and retested... value of red gamma restores properly.... will let other users report if really there is any issue.
Saturation works fine as well. Unfortunately, saturation change cannot be seen in below video since their is no graphics to test.

@savoca: Can you include any graphic in app? It will be easier for all to check this awesome development.

I can definitely add a picture for reference, thanks for the vid and feedback!

Edit: @neobuddy89 updated app in the op, added reference parrots.

http://imgur.com/n5cR4QL

Quote:
Originally Posted by eng.stk

Well app is working , but on shamu so far only RGB and invert controls work.

I will need to get my hands on an APQ8084 device in that case.
The Following 4 Users Say Thank You to savoca For This Useful Post: [ View ] Gift savoca Ad-Free
17th February 2015, 02:00 AM |#27  
WhiteNeo's Avatar
Senior Member
Thanks Meter: 4,101
 
Donate to Me
More
Would this have any chance to work with msm8960 devices?

I'll definitely give it a try, but would like to hear your opinion anyway.
17th February 2015, 02:28 AM |#28  
savoca's Avatar
OP Inactive Recognized Developer
Flag Pasadena
Thanks Meter: 5,765
 
Donate to Me
More
Quote:
Originally Posted by WhiteNeo

Would this have any chance to work with msm8960 devices?

I'll definitely give it a try, but would like to hear your opinion anyway.

I think that is mdp4? Not sure, sorry I rolled onto the scene when msm8974 came out so I'm not sure about older chipsets. If you have a device using the mdss subsystem, you can use this.
The Following User Says Thank You to savoca For This Useful Post: [ View ] Gift savoca Ad-Free
17th February 2015, 05:20 AM |#29  
Flashhhh's Avatar
Senior Member
Flag Valsad
Thanks Meter: 5,368
 
More
Will work on msm8226 devices?
(Moto g)
17th February 2015, 05:23 AM |#30  
savoca's Avatar
OP Inactive Recognized Developer
Flag Pasadena
Thanks Meter: 5,765
 
Donate to Me
More
Quote:
Originally Posted by Flashhhh

Will work on msm8226 devices?
(Moto g)

Yes, I'm using a Moto G in the video actually.
The Following User Says Thank You to savoca For This Useful Post: [ View ] Gift savoca Ad-Free
17th February 2015, 05:26 AM |#31  
Flashhhh's Avatar
Senior Member
Flag Valsad
Thanks Meter: 5,368
 
More
Quote:
Originally Posted by savoca

Yes, I'm using a Moto G in the video actually.

Ok thanks
EDIT: will add the commits in my kernel!
Post Reply Subscribe to Thread

Guest Quick Reply (no urls or BBcode)
Message:
Previous Thread Next Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes