FORUMS
Remove All Ads from XDA

[BETA][2017.10.01] SuperSU v2.82 SR5

11,223 posts
Thanks Meter: 86,610
 
By Chainfire, Senior Moderator / Senior Recognized Developer - Where is my shirt? on 5th September 2014, 12:23 PM
Post Reply Email Thread
6th January 2018, 06:38 AM |#11791  
Junior Member
Thanks Meter: 0
 
More
Supers zip
 
 
6th January 2018, 11:42 AM |#11792  
Junior Member
Thanks Meter: 0
 
More
7th January 2018, 08:29 PM |#11793  
Eures's Avatar
Member
Thanks Meter: 2
 
More
Hello, I have a question: is the SuperSU-v2.82-20170528234214-TEST-1.zip (for Xperia users) rolled out in the SR5-SuperSU-v2.82-SR5-20171001224502.zip? In other words, can it be said that the former is obsolete?...
8th January 2018, 06:27 PM |#11794  
SlimSnoopOS's Avatar
Senior Member
Thanks Meter: 3,347
 
More
Quote:
Originally Posted by Eures

Hello, I have a question: is the SuperSU-v2.82-20170528234214-TEST-1.zip (for Xperia users) rolled out in the SR5-SuperSU-v2.82-SR5-20171001224502.zip? In other words, can it be said that the former is obsolete?...

Depends but likely yes. Whenever Chainfire would release test zips for specific issues, if it fixed issues then he'd incorporate that into his next SR# zip. Try SuperSU beta SR5 just know that there's no further support if anything goes awry.

Sent from my Nexus 5X using Tapatalk
8th January 2018, 06:46 PM |#11795  
Junior Member
Flag Gilgit
Thanks Meter: 0
 
More
Guide to Root Nokia2
I am asking that which app is compatible to root Nokia 2 smart phone?
GetOffMyLawn&!+¢#{$
9th January 2018, 02:04 AM |#11796  
Guest
Thanks Meter: 0
 
More
Quote:
Originally Posted by arter97

f2fs with Android story is always complicated.

So why is SuperSU broken with many custom ROMs:
systemless SuperSU saves a raw ext4 image in /data/su.img and mounts it as a loopback device and to various locations upon boot.
The problem with f2fs, is that most kernels included in custom ROMs have issues with managing loopback devices.
This is not SuperSU issue, rather, kernel developers has to incorporate the necessary fix for f2fs.

This “fix” is rather dumb :
https://git.kernel.org/cgit/linux/ke...7c3b67284db105

The f2fs head, Kim Jaegeuk forgot to add those pointer to post-4.10 versions of f2fs backports.
(The stock OnePlus 3T’s kernel source code seems to already have this fix. This explains why OxygenOS didn’t have any issues with SuperSU.)
So you have 2 choices :
A. Cherry-pick that fix separately
B. Merge f2fs version all the way up to 4.10(latest f2fs-stable.git is updated to 4.10)


But there are more stories to be told, unfortunately.
Both 2 methods introduce a new problem : breaks all previous f2fs versions to read the data.
There is no on-disk-format change introduced by the new “fix”, but it turns out that older versions of f2fs has an issue which is exploited only when newer version of f2fs is used to write data.

You need this additional fix, if you have no intention to update f2fs to the latest 4.10 version :
https://git.kernel.org/cgit/linux/ke...112255eb0837ee

Without this fix, the kernel will panic upon reading any data.


So we took care of the method A.
However, there is still an issue with method B : deadlock.

As noted in https://review.lineageos.org/#/c/95316/ , there are deadlocks present on the latest version of f2fs(from 4.8, iirc).
It took about a month to bisect it, and I got the culprit commit :
https://git.kernel.org/cgit/linux/ke...7f242836ce90d0

I’m still yet to hear from the upstream developers, but I can confirm that reverting that commit fixes the deadlock.
Our internal AOSPA builds are running on 4.10 f2fs with that commit reverted.


TL;DR
It’s not @Chainfire 's fault.
You have to ask the kernel developer to fix the issue.
2 methods for the kernel developers

A. Incorporate only the necessary 2 fixes to fix loopback images :
https://git.kernel.org/cgit/linux/ke...7c3b67284db105
https://git.kernel.org/cgit/linux/ke...112255eb0837ee

B. If you want to upstream f2fs to the latest 4.10, revert this to avoid deadlock :
https://git.kernel.org/cgit/linux/ke...7f242836ce90d0
(A little credit would be appreciated, as it took me a frustrating month to bisect this)

Thanks.

I just thought some of you might like to see this.
Edit: I almost forgot, I did give credit and linked the post.
Sent from my Moto E (4) Plus using XDA Labs
Attached Thumbnails
Click image for larger version

Name:	Screenshot_20180108-175439.png
Views:	1542
Size:	170.5 KB
ID:	4383849   Click image for larger version

Name:	Screenshot_20180108-175451.png
Views:	1534
Size:	98.2 KB
ID:	4383850   Click image for larger version

Name:	Screenshot_20180110-132735.png
Views:	1098
Size:	107.0 KB
ID:	4385426  
The Following 4 Users Say Thank You to For This Useful Post: [ View ] Gift Ad-Free
13th January 2018, 11:47 PM |#11797  
Senior Member
Flag Budapest
Thanks Meter: 80
 
More
Hey sorry this Will most likely sound nooby but I didn't used supersu alot till Now

No matter which version I choose either Way doesnt work if I used a version 2.80 or before it fails in the flashing procedure at patching sepolicy failure aborting

Or if I use v2.82 sr2 or sr5 they both flash but then ask for binary update which fails and even after relfashing in twrp still nothing fixes it

My device is a p9 liter (vns-l21c432)
Running Elite rom 7.3

TIA.
13th January 2018, 11:58 PM |#11798  
ktmom's Avatar
Senior Member
Thanks Meter: 1,138
 
More
@Razor10707, I take it you tried 2.80 then tried newer versions? How did you remove the previous flash before flashing the next version?

I'd first do a nandroid backup, then dirty flash your ROM again to get everything back to a known condition. Boot first to make sure everything is working then try SR5 and see if it flashes correctly.



"Good judgment comes from experience, and a lot of that comes from bad judgment." - Will Rogers
14th January 2018, 12:20 AM |#11799  
Senior Member
Flag Budapest
Thanks Meter: 80
 
More
Quote:
Originally Posted by ktmom

@Razor10707, I take it you tried 2.80 then tried newer versions? How did you remove the previous flash before flashing the next version?

I'd first do a nandroid backup, then dirty flash your ROM again to get everything back to a known condition. Boot first to make sure everything is working then try SR5 and see if it flashes correctly.



"Good judgment comes from experience, and a lot of that comes from bad judgment." - Will Rogers

Yes I tried older versions but as I said other Than 2.82 all fails at flashing in recovery only 2.82 gets trough that but it fails at binary update
14th January 2018, 09:46 AM |#11800  
Member
Thanks Meter: 5
 
More
After I dirty flashed Nougat and Odined TWRP, I still cant get root. I Odined SuperSu but after that I got this message: "Verification Failed, Unable to restart your device. The Integrity verification has failed. You need to reset your device to factory default settings. This will erase all your data."

I then dirty flashed Nougat and everything is ok. But I still dont have root. I used this SuperSu: SR5-SuperSU-v2.82-SR5-20171001224502.

What do you suggest to get root?

.
14th January 2018, 11:17 AM |#11801  
Badger50's Avatar
Recognized Contributor
Flag Kansas City
Thanks Meter: 3,706
 
More
Quote:
Originally Posted by deloj

After I dirty flashed Nougat and Odined TWRP, I still cant get root. I Odined SuperSu but after that I got this message: "Verification Failed, Unable to restart your device. The Integrity verification has failed. You need to reset your device to factory default settings. This will erase all your data."

I then dirty flashed Nougat and everything is ok. But I still dont have root. I used this SuperSu: SR5-SuperSU-v2.82-SR5-20171001224502.

What do you suggest to get root?

.

Since SU is no longer being activity developed at this time, you might wanna try this.

https://forum.xda-developers.com/app...mless-t3473445
Post Reply Subscribe to Thread

Guest Quick Reply (no urls or BBcode)
Message:
Previous Thread Next Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes