FORUMS
Remove All Ads from XDA

[MOD][THEME] WhatsApp desktop dark mode

36 posts
Thanks Meter: 43
 
Post Reply Email Thread
5th September 2019, 06:34 PM |#41  
Member
Thanks Meter: 10
 
More
@m4heshd
I was finally able to get it to run by making a really small code change.
at https://github.com/m4heshd/whatsapp-...-darwin.js#L37
I changed the default psargs from 'lx' to 'ax' to get other users' processes as well as your own.
I'm not entirely sure why whatsapp is running under a different user

Quote:

ps.lookup({
command: execPath,
psargs: 'ax'
}

 
 
5th September 2019, 10:12 PM |#42  
OP Member
Flag Sri Lanka
Thanks Meter: 43
 
Donate to Me
More
Quote:
Originally Posted by sberk

@m4heshd
I was finally able to get it to run by making a really small code change.
at https://github.com/m4heshd/whatsapp-...-darwin.js#L37
I changed the default psargs from 'lx' to 'ax' to get other users' processes as well as your own.
I'm not entirely sure why whatsapp is running under a different user

OMG i never cared about the args because i was always thinking in favor of Windows since WMIC doesn't take args. I'm really glad you brought this to light and able to fix it. It'll be really great if you can open an issue on Github with this issue so maybe i can include this as an update in the next release. Cheers.
5th September 2019, 10:35 PM |#43  
Member
Thanks Meter: 10
 
More
Quote:
Originally Posted by m4heshd

OMG i never cared about the args because i was always thinking in favor of Windows since WMIC doesn't take args. I'm really glad you brought this to light and able to fix it. It'll be really great if you can open an issue on Github with this issue so maybe i can include this as an update in the next release. Cheers.

Done
Thanks for the mod! looks great!
5th September 2019, 11:58 PM |#44  
OP Member
Flag Sri Lanka
Thanks Meter: 43
 
Donate to Me
More
Quote:
Originally Posted by sberk

Done
Thanks for the mod! looks great!

You're very welcome and it was my pleasure. The issue you just opened is now pinned to the repo.
6th September 2019, 01:34 PM |#45  
bobfrantic's Avatar
Senior Member
Thanks Meter: 1,106
 
More
@m4heshd just installed the mod on my laptop and all is fine, love it. thanks so much!!!!
7th September 2019, 09:00 PM |#46  
OP Member
Flag Sri Lanka
Thanks Meter: 43
 
Donate to Me
More
Quote:
Originally Posted by bobfrantic

@m4heshd just installed the mod on my laptop and all is fine, love it. thanks so much!!!!

Hi @bobfrantic, You're very welcome and the feedback is much appreciated.
9th September 2019, 09:02 AM |#47  
Krusade's Avatar
Senior Member
Flag Mumbai
Thanks Meter: 33
 
More
It requires the desktop application so won't run on Win 7, right?
10th September 2019, 11:12 AM |#48  
OP Member
Flag Sri Lanka
Thanks Meter: 43
 
Donate to Me
More
Quote:
Originally Posted by Krusade

It requires the desktop application so won't run on Win 7, right?

Hi @Krusade, I haven't done any testing but I'm pretty sure it can run on Windows 7.
10th September 2019, 02:29 PM |#49  
Krusade's Avatar
Senior Member
Flag Mumbai
Thanks Meter: 33
 
More
Quote:
Originally Posted by m4heshd

Hi @Krusade, I haven't done any testing but I'm pretty sure it can run on Windows 7.

Genuine doubt - Unsure if whatsapp desktop can run on win 7, its win 8+ iirc (dont want to sound like a dick)
10th September 2019, 02:45 PM |#50  
OP Member
Flag Sri Lanka
Thanks Meter: 43
 
Donate to Me
More
Quote:
Originally Posted by Krusade

Genuine doubt - Unsure if whatsapp desktop can run on win 7, its win 8+ iirc (dont want to sound like a dick)

It'll never hurt to try. WhatsApp is Electron based and I've done countless Electron projects which managed to run on Windows 7 perfectly. I think they're talking about the Microsoft store version. Give it a try.
12th September 2019, 12:49 PM |#51  
Senior Member
Flag Shahrakan
Thanks Meter: 106
 
Donate to Me
More
i installed this mod now and works great

thanks to the developer

check out the attachment
Attached Thumbnails
Click image for larger version

Name:	wadark.jpg
Views:	58
Size:	76.3 KB
ID:	4818580  
Post Reply Subscribe to Thread

Guest Quick Reply (no urls or BBcode)
Message:
Previous Thread Next Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes