That popup has been added since nougat iirc, it's annoying af but never liked for a way to remove it since I don't use GPS that often.
But anyways now I have xposed on my OnePlus 5t running Android 8.1 so if you had a working module that you know you can try.