[PORT][V.8] OxygenOS Stock Camera and Gallery Port

[reabook]

What problem there is to extract original OOS Camera app (without any changes) and implement every OOS feature related to camera to custom rom?
@markusviktorius
This port has worse photo quality than Sultan's app, but video stability is better while moving.

 

[GTRanushka]

You can judge the quality for yourself, but it's definitely not that bad as on your pics and it's even taken on less light.

Have you taken this photo enabling HQ mode on OOS camera? Or on default mode? Please try a HQ on and off comparison on OOS camera. When HQ is on shutter speed go down and shutter iso levels go down but looks like denoise is not happening. Which resulted in more noisy photo than HQ off default photos.

 

[siankatabg]

What problem there is to extract original OOS Camera app (without any changes) and implement every OOS feature related to camera to custom rom?

@markusviktorius
This port has worse photo quality than Sultan's app, but video stability is better while moving.

Well if you have contacts in oneplus and someone leak the code for you then there is no problem, but now everything is closed source and can't be implemented. I believe that the rest of the not wrong features are implemented in the framework.

 

[ExtentedByte]

Is this right concerning camera quality:
1: OOS
2: This Port
3. Sultan
4. The rest
?

I can't see any difference between this port and OOS.. I'm on latest ZenityRR with Multirom and got it on second rom.. In normal mode or HDR mode there is litterly no difference, just the HQ mode is worse on RR..
Don't know if zenixxx did some picture improvement under the hood but for me the picture quality is the same as OOS (beside the HQ mode)

 

[emonkhan826]

Thanks :good:

 

[siankatabg]

Have you taken this photo enabling HQ mode on OOS camera? Or on default mode? Please try a HQ on and off comparison on OOS camera. When HQ is on shutter speed go down and shutter iso levels go down but looks like denoise is not happening. Which resulted in more noisy photo than HQ off default photos.

Yep, as you've said HQ on oos and normal on Snap.

 

[NOSTALGIA]

@siankatabgany idea why oos cam fails to record video on aosip with omni7 hal1 enabler?

 

[GTRanushka]

Yep, as you've said HQ on oos and normal on Snap.

How so? I tried two different LOS roms with your port. I get decent photos with normal mode on ported camera. But grainy photos when HQ mode is on. i didn't want to flash HAL 1 enabler since i got HQ and HDR mode default with camera apk.
Do you have any idea what's wrong in this case?
Thank you in advance. :highfive:
HDR seems fine tho.

 

[sys01]

@siankatabg thanks for the fantastic camera port! It's working also on Mi5 with LOS, only slow motion is not working ^^
Gallery isnt working tho, it detect that im not on OnePlus3 (build.prop related maybe?) saying that i need to install official software (?)

 

[siankatabg]

@siankatabgany idea why oos cam fails to record video on aosip with omni7 hal1 enabler?

I need to see the device tree and the vendor files used for it, or to flash it, but that won't happen soon(I mean the flashing, I'll take a look when I have some free time).

@siankatabg thanks for the fantastic camera port! It's working also on Mi5 with LOS, only slow motion is not working ^^
Gallery isnt working tho, it detect that im not on OnePlus3 (build.prop related maybe?) saying that i need to install official software (?)

Yep, I already removed this check, I need to upload the new app

 

[cloudx720]

Getting 1080p60fps to work is going to require proper blobs/code from oneplus to be released IMO. Other wise it's never ever going to work 100% just my 2 cents.

 

[siankatabg]

Getting 1080p60fps to work is going to require proper blobs/code from oneplus to be released IMO. Other wise it's never ever going to work 100% just my 2 cents.

Actually you might be right, because I already got different app to take full 1080/60 on custom rom and it seems that oos is using another custom implementation for this too.

How so? I tried two different LOS roms with your port. I get decent photos with normal mode on ported camera. But grainy photos when HQ mode is on. i didn't want to flash HAL 1 enabler since i got HQ and HDR mode default with camera apk.
Do you have any idea what's wrong in this case?
Thank you in advance. :highfive:
HDR seems fine tho.

If you use LOS, better check if it really is useing the hal1(I explained how few pages back). But even if it's already on it and you flash the enabler, it will not make a harm.

And I'm not on los anymore, but on different rom that I bringed up for myself and I'm using the same blobs and stuffs, so should not be different for you.

 

[cloudx720]

Actually you might be right, because I already got different app to take full 1080/60 on custom rom and it seems that oos is using another custom implementation for this too.

Have you tried everything imaginable to get it to work? On custom ROMs it just plays the video really fast lol.

 

[Rajeev]

I need to see the device tree and the vendor files used for it, or to flash it, but that won't happen soon(I mean the flashing, I'll take a look when I have some free time).

Yep, I already removed this check, I need to upload the new app

Hi

Any advice on the attached image? I am on AOSIP latest. Tried to install Google Camera. Its force closing.

 

[siankatabg]

Have you tried everything imaginable to get it to work? On custom ROMs it just plays the video really fast lol.

Well idk, I've tried everything that I can think of that might help, but still no improvement. It takes 40 to 42-3 fps, but that's all.

Hi

Any advice on the attached image? I am on AOSIP latest. Tried to install Google Camera. Its force closing.

As the terminal says, you need to add a value(as second argument). "0" is hal1, "1" is hal3. But if the Gcam is FC, most probably you are already on hal1. You can use "getprop "prop you want to check"" to see the current value.

 

[Rajeev]

Well idk, I've tried everything that I can think of that might help, but still no improvement. It takes 40 to 42-3 fps, but that's all.


As the terminal says, you need to add a value(as second argument). "0" is hal1, "1" is hal3.

Thanks bro. Can u pls write a full command here.?

 

[siankatabg]

Thanks bro. Can u pls write a full command here.?

Your command seems right, just add "0" at the end.

setprop persist.camera.HAL3.enabled 0

P.s. - Can someone recommend me a good collage maker app that doesn't lower the quality?

 

[Rajeev]

Your command seems right, just add "0" at the end(I'm on the phone so writing commands is not easy )

Thanks for ur time bro. Tried with 0 and 1 but still GCam force closing..Anyway don't wish to disturb u more...

EDIT

Its working. Its my fault. One last question. Using ur V5 camera port too. For getting that "processing" text for HDR and HQ mod do I need to flash HAL1 enabler zip from OP? Because now I am not getting the "processing" blah blah text after taking photo using HDR or HQ with ur port..

 

[siankatabg]

Thanks for ur time bro. Tried with 0 and 1 but still GCam force closing..Anyway don't wish to disturb u more...

EDIT

Its working. Its my fault. One last question. Using ur V5 camera port too. For getting that "processing" text for HDR and HQ mod do I need to flash HAL1 enabler zip from OP? Because now I am not getting the "processing" blah blah text after taking photo using HDR or HQ with ur port..

Erm, I'm not sure, if you have them, everything should be all right, but you need to get the processing dialogue. Try wiping the data of the app first, but as I said flashing the enabler can't do harm, so to be on the safe side flash it too

 

[VincentJoshuaET]

I've read that sultanxda's ROM's camera quality is almost stock like. How could he achieve that? Is this port basically the same as what he does?

Sent from my OnePlus 3 using XDA Labs