[ROM] [OFFICIAL] [AOKP 9.0/Pie] [dumpling] AOKP Pie for OnePlus 5T

[apophis9283]

I've seen this before. It's an issue with omniswitch I believe. We fixed it in oreo. I'd have to go through commits back then for one of the roms I was doing

I still swear Omniswitch was causing this issue, the issue I was remembering were these

https://github.com/wrongway213/plat...mmit/3d72c47e0e0fc49a160f881d9c28847af9c0fb28

https://github.com/wrongway213/plat...mmit/5b22fff020c66b9721eb79815c7293f510d28387

 

[shane87]

I did aokp for note 2. I'm also the one that solved the RIL issue for Omni Rom on note 2 Verizon. I remember when Steve wrote the code for the animations. That's how long ago all that was

Also, how do you disable ambient display always on. I can disable ambient display all together and it'll still stay on.

I am actually looking into that right now, I got the same question over on cheeseburger. As of right now, the only way to toggle ambient Display is to use the search in settings, type in ambient, and the first option will allow you to disable Ambient Display.

The option under Settings -> Display -> Ambient Display is changing the wrong value.

 

[shane87]

I've seen this before. It's an issue with omniswitch I believe. We fixed it in oreo. I'd have to go through commits back then for one of the roms I was doing

I still swear Omniswitch was causing this issue, the issue I was remembering were these

https://github.com/wrongway213/plat...mmit/3d72c47e0e0fc49a160f881d9c28847af9c0fb28

https://github.com/wrongway213/plat...mmit/5b22fff020c66b9721eb79815c7293f510d28387

What issue did these commits fix?

 

[apophis9283]

What issue did these commits fix?

A stock recents issue with omniswitch. We had slim, Omni and stock. Caused a weird issue.

 

[apophis9283]

I am actually looking into that right now, I got the same question over on cheeseburger. As of right now, the only way to toggle ambient Display is to use the search in settings, type in ambient, and the first option will allow you to disable Ambient Display.

The option under Settings -> Display -> Ambient Display is changing the wrong value.

Makes sense. Drives me nuts, other than that seems to work fine.

 

[Dgonix]

Need gaps or not?

 

[AlexX-DE]

Need gaps or not?

Yes, you need !

 

[rohithksaj]

Need gaps or not?

You definitely need Gapps...

 

[aftnoon2]

Deleted

 

[shane87]

AOD/Ambient Display fixed

Alright guys, I just finished some changes that will fix the AOD/Ambient Display issue. There was a missing commit, even LOS doesn't have it as far as I can tell, that added the Always On Display switch to the Ambient Display screen in Settings. I now have that option added, and tested as working on cheeseburger. However, the change is strictly to the common tree that cheeseburger and dumpling share, so it should work the same on dumpling. I have pushed the change up, but I am waiting to see if anyone else wants to test before the change goes live, so it may be a day or two before you see a new build with the fix in it. I am attaching a screenshot of the new Ambient Display options screen from my cheeseburger device.

 

[shane87]

Alright guys, I just finished some changes that will fix the AOD/Ambient Display issue. There was a missing commit, even LOS doesn't have it as far as I can tell, that added the Always On Display switch to the Ambient Display screen in Settings. I now have that option added, and tested as working on cheeseburger. However, the change is strictly to the common tree that cheeseburger and dumpling share, so it should work the same on dumpling. I have pushed the change up, but I am waiting to see if anyone else wants to test before the change goes live, so it may be a day or two before you see a new build with the fix in it. I am attaching a screenshot of the new Ambient Display options screen from my cheeseburger device.

The build from this morning, dated 02-05, has the fix for AOD/AmbientDisplay included.

 

[rohithksaj]

How's this rom ? If I remember I flashed it last time it didn't boot .

Anybody using this ?

Tell me hows this rom as a DD !

 

[aftnoon2]

Hi

Please, how can we download 9.0.9 firmware?
I only find 9.0.7 or 9.0.8.
Thanks!

 

[shane87]

Hi

Please, how can we download 9.0.9 firmware?
I only find 9.0.7 or 9.0.8.
Thanks!

Here is a link to a post with the OP 5T 9.0.9 firmware link.

https://xdaforums.com/showthread.php?t=3728665&p=80559327

 

[Bubble-be]

Builds have been failing for a week?

 

[shane87]

Builds have been failing for a week?

No, the system only produces a build if there have been any changes since the last build. No changes to source means no new builds. I checked our build status page, and it shows the system is properly processing dumpling. However, since LOS has moved on to Q, there have not been many updates to the 9/pie trees.

 

[Amrut Parmar]

Is development stopped for this rom?

 

[shane87]

Is development stopped for this rom?

I check in at least weekly, and watch for any updates from Lineage, whom we base off of. Lineage has now moved on to Android 10, so there haven't been any updates in a month or two for Android 9 Pie.

To answer your question, in essence, yes, development had stopped. However, it is not due to a lack of interest, but rather due to a lack of development on LineageOS's lineage-16.0 branch. And it doesn't mean that development is stopped forever. As soon as any changes come in on Lineage, I will pull them in to AOKP.

 

[aggregate1166877]

You should have left it as I'm sorry it didn't work that would have been the polite thing to do. I don't like your attitude. I too do not get paid to test your work and waste my time.

It's this arrogant sense of entitlement that killed the AOKP scene in the first place. It's killed the PS4 hacking scene as well. I can't post source links, psx-place shows the lead contributor specifically stating he's abandoned the scene for this reason.

No one owes you anything. The post has warnings written in clear English, bold and underlined no less. Please do everyone a favour and read the description before flashing things to your phone. Failing that, there is nothing that can be done for you.

---------- Post added at 12:50 AM ---------- Previous post was at 12:39 AM ----------

Alright guys, I just finished some changes that will fix the AOD/Ambient Display issue. There was a missing commit, even LOS doesn't have it as far as I can tell, that added the Always On Display switch to the Ambient Display screen in Settings. I now have that option added, and tested as working on cheeseburger. However, the change is strictly to the common tree that cheeseburger and dumpling share, so it should work the same on dumpling. I have pushed the change up, but I am waiting to see if anyone else wants to test before the change goes live, so it may be a day or two before you see a new build with the fix in it. I am attaching a screenshot of the new Ambient Display options screen from my cheeseburger device.

I'd just like to say thank so, so much for your efforts. It truly is appreciated and you are amazing. Merging in the upstream sources is well beyond my technical capabilities, and I'm thankful someone is willing to do this for me even when they don't own the device in question.

EDIT:
Flashed TWRP+AOKP and ROM appears to be working perfectly. In addition to cache/dalvik wipe, had to reset selinux permissions. After that, it's running nicely.

 

[shane87]

---------- Post added at 12:50 AM ---------- Previous post was at 12:39 AM ----------



I'd just like to say thank so, so much for your efforts. It truly is appreciated and you are amazing. Merging in the upstream sources is well beyond my technical capabilities, and I'm thankful someone is willing to do this for me even when they don't own the device in question.

I appreciate your thanks. However, this ROM is basically dead. The main AOKP team left years ago, and it appears that the main dev for the last few years has also left. Most of us maintainers have moved on to other projects as well. I will leave the download links on the OP, but this thread will no longer be monitored. I never had an OP5T, and I have lost my OP5 as well. Stupid charging port. It was a fun ride while it lasted, and I thank all of the people who tested and reported issues, gave thanks, and kept me going when I wanted to just throw in the towel. Maybe I will see you on a different project (though I am not currently working on any at the moment, too busy with building a house)!