[ROM][7.1.2_r33] AOSPlusone 7.1 [SultanXDA's Camera HAL][OMS] | 25/08/17

[Gawd]

Granted I haven't flashed and tried ALL roms out there, almost ALL AOSP-based roms I have tried since Marshmallow had this problem.

"Almost"

 

[rphlfjrd]

"Almost"

¯\_(ツ)_/¯

 

[Gawd]

¯\_(ツ)_/¯

▕▔▔▔▔▔▔▔▔▔▔▔╲┈┈
▕╮╭┻┻╮╭┻┻╮╭▕╮╲┈
▕╯┃╭╮┃┃╭╮┃╰▕╯╭▏
▕╭┻┻┻┛┗┻┻┛┈▕┈╰▏
▕╰━━━┓┈┈┈╭╮▕╭╮▏
▕╭╮╰┳┳┳┳╯╰╯▕╰╯▏
▕╰╯┈┗┛┗┛┈╭╮▕╮┈▏

 

[myshakugan]

Weird, I've got Pixel since first build and everything is at full speed. Still happy it fixed it for you tho.

I'm using the TWRP flashed pixel launcher and there isn't any lag. OTOH, nova launcher lags a bit compared with the pixel launcher.

Another correction, turns out it was slowing down due to the google calendar widget. Figured it out when the stock launcher was slowing down too. Haha. ?

 

[dragsterman]

Also, I've managed to get the HAL to work without blobs, so now we're building it directly from sources, allowing us to do customizations and stuff. First job I was able to get done is to update our HAL to match the new libstagefright hardening, thus removing the reverts, patches and workarounds needed in frameworks/av.
Take that CM/Color OS blobs, how does improved security sound to you?

Hope to get a build up before 20 Jan., but I can't assure. Need more time to test.

Sorry for the n00b question, but what does actually mean that you managed to get the HAL to work without blobs?

So, we can use CM camera blobs with Sultan's HAL and for example have 1080p@60fps HSR mode? Or have a ROM with CM blobs and use Sultan's anti-shake algortihm?

 

[freshgiammi]

Yes, my system is ext4. Cannot give you a log since i format my data and cache back to ext4. Sorry. Everything is working perfectly now though. So good job!

No prob. Thanks!

Another correction, turns out it was slowing down due to the google calendar widget. Figured it out when the stock launcher was slowing down too. Haha.

Nice spot haha, i wouldn't have thought about that!

Sorry for the n00b question, but what does actually mean that you managed to get the HAL to work without blobs?

So, we can use CM camera blobs with Sultan's HAL and for example have 1080p@60fps HSR mode? Or have a ROM with CM blobs and use Sultan's anti-shake algortihm?

Let's make this easy and clear: blobs are precompiled files that don't give us access to the source code.
Sultanxda used not to release the code of his HAL, leaving us with OOS camera blobs and his HAL blobs. Now that we have access to the HAL source code, we can trash the HAL blobs, and replace them with the ones built from the source code he now released.. Still, we need OOS blobs, because we don't have access to proprietary files.

tl;dr
1. OOS blobs (necessary, closed source)
2. Sultanxda's HAL blobs (now open source, replaced with the open source implementation)
To make this easy, we could say that HAL contains the "features" of the camera, while the OOS blobs have all the technical drivers to make the camera recognizable. (It's not the right definition but it's as noob-proof as I can be, not really great with words)

Sultanxda's HAL is not compatible with CM Camera Blobs, and it's better since CM camera has really bad blobs.

However some updates on the ROM.
Camera looks stable now. HFR/HSR has the improvements stated in the previous pages.
I'm working on SElinux (almost fully implemented) right now, hope to get a build this weekend. Still permissive tho, enforcing might be coming next week.

EDIT: Thanks to the ones who reported the HW keys status! I'm gomma leave the implementation as-is, since i've seen there's some movement in AOSPA (The place I took the commits from).
I'l probably wait for them to merge it and add it later. We're fine for now.

 

[se7enlyn]

Another correction, turns out it was slowing down due to the google calendar widget. Figured it out when the stock launcher was slowing down too. Haha. ?

I use the Google calendar widget+pixel launcher but there isn't any lag in my OPO.
Did you restore your apps or did you set up as a new device during installation?

 

[fireflyv2]

@freshgiammi

Hi, I'm using the 15th Jan build, and I'm getting some random reboots. Not quite clear why, but it happens when I'm using the phone. Happened a couple of times, and while doing different activities like browsing, watching a video and even playing Pokémon Go (lost a chance to catch a vaporeon!). Adding the last kmsg log I could grab after the latest reboot. Could you help me out?

I have grabbed other logs also right after the reboot, so if required, I can provide them.

 

[myshakugan]

I use the Google calendar widget+pixel launcher but there isn't any lag in my OPO.
Did you restore your apps or did you set up as a new device during installation?

Setup as a new device, but restored Google calendar from titanium backup.

 

[se7enlyn]

Setup as a new device, but restored Google calendar from titanium backup.

Delete that TiBu Google calendar app and data. Reinstall from the play store.

 

[Gawd]

Sleeps perfect

 

[myshakugan]

Delete that TiBu Google calendar app and data. Reinstall from the play store.

Already tried that, the launcher starts to slow down after a while unless I remove the google calendar widget.

 

[freshgiammi]

@freshgiammi

Hi, I'm using the 15th Jan build, and I'm getting some random reboots. Not quite clear why, but it happens when I'm using the phone. Happened a couple of times, and while doing different activities like browsing, watching a video and even playing Pokémon Go (lost a chance to catch a vaporeon!). Adding the last kmsg log I could grab after the latest reboot. Could you help me out?

I have grabbed other logs also right after the reboot, so if required, I can provide them.

You did changes to kernel settings? Looks like it's kernel panic, not rom related.

However, the next build will probably need a few more days, SELinux is being problematic due to the new HAL

 

[hammer-is]

How to build this ROM?

@freshgiammi great ROM and I really like your no-nonsense approach!
I'm trying to build using your manifest, but I'm having issues. I've build variations of CyanogenMod for different devices for some years so I have some build experience but I've never tried building AOSP based ROMs so it might be something very basic that I dont understand. Hope you can help me out.

I'm on Linux Mint 18.1 / openjdk 1.8 (and it builds LineageOS 14.1 without issues) - what Linux/environment are you using for building?

I build like this:

repo init -u https://github.com/AOSPlusone/platform_manifest -b aosp-7.1
repo sync
make clobber
. build/envsetup.sh
lunch aosp_bacon-userdebug
make -j8

First I got this error when building the kernel.

FAILED: /bin/bash -c "(make -j4  -C kernel/oneplus/msm8974 O=[b]out/target/product/bacon/obj/KERNEL_OBJ[/b] ARCH=arm CROSS_COMPILE=\"/home/martin/src/AOSPlusone/prebuilts/misc/linux-x86/ccache/ccache arm-linux-androideabi-\" VARIANT_DEFCONFIG= SELINUX_DEFCONFIG= bacon_defconfig ) && (if [ ! -z \"\" ]; then 			echo \"Overriding kernel config with ''\"; 			echo  >> out/target/product/bacon/obj/KERNEL_OBJ/.config; 			make -j4 -C kernel/oneplus/msm8974 O=out/target/product/bacon/obj/KERNEL_OBJ ARCH=arm CROSS_COMPILE=\"/home/martin/src/AOSPlusone/prebuilts/misc/linux-x86/ccache/ccache arm-linux-androideabi-\" oldconfig; fi ) && (if [ ! -z \"\" ]; then 			echo \"Using additional config ''\"; 			kernel/oneplus/msm8974/scripts/kconfig/merge_config.sh -m -O out/target/product/bacon/obj/KERNEL_OBJ out/target/product/bacon/obj/KERNEL_OBJ/.config kernel/oneplus/msm8974/arch/arm/configs/; 			make -j4 -C kernel/oneplus/msm8974 O=out/target/product/bacon/obj/KERNEL_OBJ ARCH=arm CROSS_COMPILE=\"/home/martin/src/AOSPlusone/prebuilts/misc/linux-x86/ccache/ccache arm-linux-androideabi-\" KCONFIG_ALLCONFIG=out/target/product/bacon/obj/KERNEL_OBJ/.config alldefconfig; fi )"
make: Entering directory '/home/martin/src/AOSPlusone/kernel/oneplus/msm8974'
/bin/sh: 1: cd: can't cd to out/target/product/bacon/obj/KERNEL_OBJ
Makefile:121: *** output directory "out/target/product/bacon/obj/KERNEL_OBJ" does not exist.  Stop.
make: Leaving directory '/home/martin/src/AOSPlusone/kernel/oneplus/msm8974'

But I was able to solve/get past this error by modifying kernel.mk to use an absolute path for the O= parameter. If you know how this can be solved cleaner please let me know.

Now I have this error that I don't know how I can solve. Can you help?

FAILED: /bin/bash -c "(build/core/tasks/check_boot_jars/check_boot_jars.py build/core/tasks/check_boot_jars/package_whitelist.txt  out/target/common/obj/JAVA_LIBRARIES/core-oj_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/core-libart_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/conscrypt_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/okhttp_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/core-junit_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/bouncycastle_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/ext_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/framework_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/telephony-common_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/voip-common_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/ims-common_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/apache-xml_intermediates/classes.jar  out/target/common/obj/JAVA_LIBRARIES/org.apache.http.legacy.boot_intermediates/classes.jar ) && (mkdir -p out/target/common/obj/PACKAGING/boot-jars-package-check_intermediates/ && touch out/target/common/obj/PACKAGING/boot-jars-package-check_intermediates/stamp )"
[b]Error: out/target/common/obj/JAVA_LIBRARIES/framework_intermediates/classes.jar: unknown package name of class file org/codeaurora/camera/ExtendedFace.class[/b]

 

[lowlow2]

My first nougat ROM and it's gooood! After +1 year of sultan continuously. Choose it because of the sultan camera.
All working very smooth, only things I'm missing are the advanced reboot menu, battery percentage next to battery icon and lighting up screen when using a magnetic case.
Very stable rom and lightweight, highly recommended!!
Only thing, sometimes I have to reboot phone to get on mobile data. Only sometimes and had the same problem in some versions of android 4.4 and 5.x. Probably something with nougat. Thanks for this amazing ROM!!

Edit: re-enabling mobile data is a bit of a problem. Need to reboot almost always! Can other persons test this please? Disable your mobile data and WiFi for a couple hours

 

[indhimaga]

Stable and perfect for daily driver and best battery... Just missing the quick charging here...

 

[abdullah.ibn.umar]

Plz add charge level

 

[freshgiammi]

Stable and perfect for daily driver and best battery... Just missing the quick charging here...

Charges at 2000ma without problems here.

My first nougat ROM and it's gooood! After +1 year of sultan continuously. Choose it because of the sultan camera.
All working very smooth, only things I'm missing are the advanced reboot menu, battery percentage next to battery icon and lighting up screen when using a magnetic case.
Very stable rom and lightweight, highly recommended!!
Only thing, sometimes I have to reboot phone to get on mobile data. Only sometimes and had the same problem in some versions of android 4.4 and 5.x. Probably something with nougat. Thanks for this amazing ROM!!

Edit: re-enabling mobile data is a bit of a problem. Need to reboot almost always! Can other persons test this please? Disable your mobile data and WiFi for a couple hours

Have you tried different radios? no problem here

@freshgiammi
I build like this:

repo init -u https://github.com/AOSPlusone/platform_manifest -b aosp-7.1
repo sync
make clobber
. build/envsetup.sh
lunch aosp_bacon-userdebug
make -j8

First I got this error when building the kernel.
But I was able to solve/get past this error by modifying kernel.mk to use an absolute path for the O= parameter. If you know how this can be solved cleaner please let me know.

Now I have this error that I don't know how I can solve. Can you help?

[b]Error: out/target/common/obj/JAVA_LIBRARIES/framework_intermediates/classes.jar: unknown package name of class file org/codeaurora/camera/ExtendedFace.class[/b]

1- Commands are okay but i don't use "make clobber"
2- I am aware of this problem but haven't solved it. I worked around it by setting a different out directory.

export OUT_DIR="/path/to/dir/"

3- Have you done changes to the repo? It should work just fine. Check your frameworks/base repo, you should have this https://github.com/AOSPlusone/andro...mmit/da870c7814a4f1154e586ac0b8f41d179fbcaefd
If you don't, repo sync the repo again.

Plz add charge level

plz no


However, managed to fix SELinux, so a build might be pushed today.
Still no F2FS, i might manage to get it working on the next build but i need someone to help me test it, since I can't change from EXT4.

 

[Gawd]

Charges at 2000ma without problems here.

Charges very slow for me, negligible charge when screen is on. Takes 3+ hours when screen is off (not using).

Anyone with same issue?

 

[fabio.pagliuca]

Charges very slow for me, negligible charge when screen is on. Takes 3+ hours when screen is off (not using).

Anyone with same issue?

Not here, charging is fine