[CLOSED][Kernel][March]FrankenKernel[P4][4.14.172]

Status
Not open for further replies.
Search This thread
By:
Advanced…
Freak07

Freak07

Recognized Developer / Recognized Contributor
Jan 2, 2011
6,441
23,040
dabug123 said:
RQ1

release build 1

chnagelog
-tidy up code to stable point
-added wake gesture,sleep gestures
-vibration control

Downloads
https://lab.dirtyrom.com/p4/FrankenKernel.RQ1.zip
Click to expand...
Click to collapse

hey,

it´s nice to see you here working on a kernel for the Pixel 4.

I really don´t like to play the devils advocate, but why couldn´t you at least wait until @flar2 opens his own thread for his kernel, before you cherry-pick his work for a new touchscreen driver (wake gestures), without even dropping a little thanks towards him in your changelog?
There is nothing wrong with cherry-picking, but I think flar2 deserves at least the possibility to publish his own kernel (here on XDA), with his own work first, before anybody starts to cherry-pick his work. (including myself)

I know there is technically no rule, that prohibits you from using the code publicly available on flars github in your own kernel. I don´t know if you asked flar2, before you decided to do so. If he allowed it and has no problems with it just disregard this message.
But even if he allowed it, I would just wait for him, if he wants to start a thread on XDA, like he always did on the past. Without him there would probably be not so many device with wake gestures.
Again there is no problem, with cherry-picking but I feel another developer who did some real original development, deserves the credit to publish his own kernel with new work first, before others can start to cherry-pick stuff. (only hours after he uploaded it to his git)
There is no official rule for that, but I feel that´s the spirit of XDA and a little base rule for the community. ( whatever that is and wherever that spirit is)
Not wanting to call you out, but I felt I needed to type this out.

Let´s all work together so we´re staying a nice little community.
 
Last edited:
  • Like
Reactions: CyberpodS2 and pappschlumpf
dabug123

dabug123

Recognized Developer
Sep 25, 2014
2,178
8,234
brunswick
Freak07 said:
hey,

it´s nice to see you here working on a kernel for the Pixel 4.

I really don´t like to play the devils advocate, but why couldn´t you at least wait until @flar2 opens his own thread for his kernel, before you cherry-pick his work for a new touchscreen driver (wake gestures), without even dropping a little thanks towards him in your changelog?
There is nothing wrong with cherry-picking, but I think flar2 deserves at least the possibility to publish his own kernel (here on XDA), with his own work first, before anybody starts to cherry-pick his work. (including myself)

I know there is technically no rule, that prohibits you from using the code publicly available on flars github in your own kernel. I don´t know if you asked flar2, before you decided to do so. If he allowed it and has no problems with it just disregard this message.
But even if he allowed it, I would just wait for him, if he wants to start a thread on XDA, like he always did on the past. Without him there would probably be not so many device with wake gestures.
Again there is no problem, with cherry-picking but I feel another developer who did some real original development, deserves the credit to publish his own kernel with new work first, before others can start to cherry-pick stuff. (only hours after he uploaded it to his git)
There is no official rule for that, but I feel that´s the spirit of XDA and a little base rule for the community. ( whatever that is and wherever that spirit is)
Not wanting to call you out, but I felt I needed to type this out.

Let´s all work together so we´re staying a nice little community.
Click to expand...
Click to collapse
You really just sent me this smh wow
 
CyberpodS2

CyberpodS2

Senior Member
Mar 27, 2012
2,813
1,240
NE Pennsylvania Boonies
My guess is one of the Magisk mods that folks are using is not playing will with a custom kernel. The thread by @Freak07 has some reports also. Over there it is seemingly good to go with a stock setup other than the kernel. I'm sure once enough users get involved with a wider pool of variables, it'll become obvious what is causing this behavior. I'm personally experiencing it once in a while but as you said a hard boot fixed it. I also almost always have to reboot a second time after adding or updating a magisk module.
 
  • Like
Reactions: dubt17
dabug123

dabug123

Recognized Developer
Sep 25, 2014
2,178
8,234
brunswick
CyberpodS2 said:
My guess is one of the Magisk mods that folks are using is not playing will with a custom kernel. The thread by @Freak07 has some reports also. Over there it is seemingly good to go with a stock setup other than the kernel. I'm sure once enough users get involved with a wider pool of variables, it'll become obvious what is causing this behavior. I'm personally experiencing it once in a while but as you said a hard boot fixed it. I also almost always have to reboot a second time after adding or updating a magisk module.
Click to expand...
Click to collapse


This would probably be a smart reply !! My guess also is that people are not flashing the stock kernel before moving to the other kernel and that is something you should do for sure!! Magisk module are horrible,I had edge module and my phone would not deep sleep after updating, deleted it phone ran great..
 
  • Like
Reactions: CyberpodS2
yyz71

yyz71

Senior Member
Mar 27, 2011
2,624
767
Somewhere in Canada ;)
Nvidia Shield
Google Pixel 4 XL
  • Like
Reactions: dubt17, Mrcactuseater and dabug123
Status
Not open for further replies.

Similar threads

Freak07
[Kernel][25.09.2023][4.14.315][A12][A13] Kirisakura 9.1.9 for Pixel 4/XL aka FLORAL
Replies
2K
Views
276K
D
denzel09
tbalden
[KERNEL] CleanSlate R2.7.13/S3.9.3 |S2S|Gamma|KCal|AdBlock|VIB|WrGrd [Jun 8]
Replies
674
Views
86K
tbalden
tbalden
P
[CLOSED, 2023-11-25] PK's Tuning Script
Replies
197
Views
39K
Monkeysss01
Monkeysss01
Sultanxda
[KERNEL][11.0.0] Sultan Kernel [June 16, 2022]
Replies
157
Views
35K
C
Curiousn00b
flar2
[KERNEL] [April 4] Pixel 4 ElementalX 3.12
Replies
281
Views
37K
P
Pixie 4 XL

Top Liked Posts

24 Hours All time

New posts