Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
flashing magisk on these devices breaks locksreen and samsung account
currently known devices are j6+ ,j4+
and probably the note 9 according to this : https://github.com/topjohnwu/Magisk/issues/1344
and check this: https://github.com/topjohnwu/Magisk/issues/1617
Last edited:
Could something be monitoring the ptrace status of zygote to determine if magisk is installed or not?
Before the implementation of Magisk hide using Zygote method, that PID remained open. Now with new method for hiding, Zygote PID is now being ptraced. So, an app simply checking Zygote ptrace status, could be enough to determine if Magisk is installed.
My thought is, is this how Netflix is detecting irregularities in system even while passing Safetynet?
Before the implementation of Magisk hide using Zygote method, that PID remained open. Now with new method for hiding, Zygote PID is now being ptraced. So, an app simply checking Zygote ptrace status, could be enough to determine if Magisk is installed.
My thought is, is this how Netflix is detecting irregularities in system even while passing Safetynet?
I'm not sure what developer you might need to ask about that, but this is the wrong place for module requestsPls add dual sound mod
I got an issue with magiskhide.
When i'm going to open western union app in my samsung s5 (custom rom RR 7.0.2), its just close & saying rooted device. Even though i already used magiskhide...!
When i'm going to open western union app in my samsung s5 (custom rom RR 7.0.2), its just close & saying rooted device. Even though i already used magiskhide...!
It has been discussed a lot/often in previous posts about some apps still detecting root although MagiskHide enforced (and SafetyNet passing)
You may try by hiding/repacking Magisk Manager (see its Settings), if it helps (some apps look for MM to proclaim that phone is rooted)
Search also fo discussions about RootBeer in this thread (app is available on Playstore, it explores various methods to detect root, and presents its results) and which steps are needed to successfully hide Magisk from RootBeer. RootBeer is an open source library, and other apps may include it to check if phone is rooted (maybe yours, too)
Last edited:
And apart from the above, you can find some further tips for hiding root here:
https://www.didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps
If you're using Magisk 19.3, try downgrading to Magisk 19.2 - I don't know why, but on my phone there's a difference. Toreba gives Connection Error -1103 on 19.3, but on 19.2 it's happy.
LATE EDIT: Disregard. Magisk 19.3's MagiskHide works fine - just needed to disable and re-enable MagiskHide after updating to 19.3 as Didgeridoohan's tips noted.
Last edited:
Appreciate the guess, and your consideration of this ongoing issue. When I turned off the option, a message came up making a positive reference to securing the device and now requiring a reboot to complete the action. Never saw that before on a developer option, and am hoping the reboot won't wipe the device or lose root, or make any other unwanted changes, or is that not possible...
It won't wipe the device. But you should of course always have a backup of any important data so you should be fine...
Did it have any effect?
Edit: to clarify, what is referenced is FRP (factory reset protection). If I remember correctly it's only enabled if that switch is set to off.
Last edited:
Just something i noticed, but i use seeder on my devices. I've been running pie with magisk canary builds. The latest release on that channel fixes issues with seeder, allowing services to be on upon bootup.
I flashed the stock ROM on my J7 2015 and still, with Magisk 19.3 hidden and Magisk hide enabled, Pokemon detect that my phone is rooted, I fixed it by installing the Magisk Canary version, so far Pokémon Go hasn't detected Magisk
Did you hide also Google Play Store? BTW, Magisk Canary is working well for you so don't update or switch channels or anything else until PoGO f*cks up again.
I have oem unlocking turned off on my pixel 2 after rooting with magisk. I turned it off a while back to see if it was preventing me from receiving update and I'm still able to fastboot flash updates.
It doesn't fix the Netflix issue for me though, still shows up as incompatible despite the play store being certified.
Similar threads
Top Liked Posts
-
1
Can you show screenshot from the main Magisk app screen, to see what is displayed there (Installed, etc)
Also, when you click to the dots (top-right) and enable Show System apps - does it list them -
5
Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.
EDIT: Ninja'd
4
Not pushed yet according to my magisk app.
Luckily i don't hide or need to hide; this is a sad bug and i hope, for others' sake, it's pushed as soon as the developers can. But that's also why it's canary and not beta or release, it's why (or should be why) we use canary, to squash bugs before the rest experience them.4
Just open another with "version code: 27002" somewhere in first post, explain you tested both but issue is with Canary only, not Debug... Supply logs from broken build and wait for further instructions from Devs... Template requires the version code (or bot closes) + logs (or Devs will often close with comment like "no log no fix")...
PW
Edit: Someone opened proper issue following template just now:
https://github.com/topjohnwu/Magisk/issues/7921
Looks to me like this commit has issues:
Always update stub APK when upgrade
committed5 days ago4
Known problem with 27002, the debug version doesn't have the problem with hiding, read back to see the discussion about it -
1103This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
