[CLOSED][BETA][2018.7.19] Magisk v16.7 (1671)

Status
Not open for further replies.
Search This thread

topjohnwu

Senior Recognized Developer / Inactive RC
Jan 31, 2012
1,849
61,429
Taipei
Hello, welcome to the beta Magisk thread! First check the main thread before starting.
I expect users reporting to at least have basic debug skills, this thread is heavily moderated so refrain from spamming with "useless" reports!


Latest Magisk Beta: v16.7 (code: 1671)
Bundled Magisk Manager: v5.8.3

Release Note | Changelogs | Download

If you need a clean start, use the uninstaller in the main thread to uninstall any verison of Magisk installation

Symptoms and Diagnose Procedure:
  • Installing Magisk fails:
    If you're flashing in TWRP: Upload the recovery logs (pull the file /tmp/recovery.log, or select "Advanced > Copy Log" and upload)
    If you're installing in MagiskManager: Choose to save logs after installation and upload
  • I want to report a Magisk bug:
    Magisk logs are placed in /cache/magisk.log
    If you face any issue, please upload /cache/magisk.log
    Starting from v16.6, /data/adb/magisk_debug.log is NOT USED anymore!
  • Magisk Manager is crashing:
    Grab LOGCAT (NOT magisk logs) when the crash occurs, upload the logs and report how to reproduce
  • SafetyNet / CTS / XXX app won't work after enabling MagiskHide:
    If it worked in previous versions, please at least upload /cache/magisk.log
    Please do NOT SPAM the forum with these kind of issues! It is NOT a priority to fix
Donation
I spent endless hours to create Magisk. If you like my work, feel free to donate.
https://www.paypal.me/topjohnwu
 
Last edited:
Samsung Galaxy Note 5
N920TUVU4EQE1
Stock boot or Modded
TWRP Latest 3.1
 

Attachments

  • Screenshot_2017-06-07-18-16-07.png
    Screenshot_2017-06-07-18-16-07.png
    245.6 KB · Views: 125,103

Deic

Senior Member
Feb 4, 2012
540
987
Madrid
www.xiaomiadictos.com
Samsung Galaxy Note 5
N920TUVU4EQE1
Stock boot or Modded
TWRP Latest 3.1

Did you not know read? is the first line else..

Symptoms and Diagnose Procedure:
  • Flashing the zip in custom recovery fails:
    Most likely your device's boot image is not supported
    Upload the recovery logs (pull file in /tmp/recovery.log, or select "Advanced > Copy Log" in TWRP and upload)
 
Last edited:

vsc0705

Member
Feb 4, 2011
16
12
After full uninstall using 170608 uninstaller, Magisk 13 installing failed. But install 12 version and dirty flash 13 version, it seems working.
And i don't know if you know this problem, magiskhide doesn't work with MIUI Nougat roms..
Logs attached.
Thanks
 

Attachments

  • recoverylog.log
    98.1 KB · Views: 3,610
  • magisk.log
    7.8 KB · Views: 5,455

vsc0705

Member
Feb 4, 2011
16
12
About the miui part, are you talking specifically about the safetynet? If yes, have you tried that module already? (just asking since I don't own a xiaomi device, I'm not sure if the module will work with v13 tho):
https://xdaforums.com/apps/magisk/xiaomi-safetynet-fix-t3600431
On miui nougat, magiskhide completly not work not only safetynet.
Even magiskhide is activated, apps can request root permission and grant.
I already tried that module..

나의 Redmi Note 4X 의 Tapatalk에서 보냄
 
  • Like
Reactions: MrZentroRethKid

abacate123

Senior Member
Feb 22, 2015
1,273
1,804
On miui nougat, magiskhide completly not work not only safetynet.
Even magiskhide is activated, apps can request root permission and grant.
I already tried that module..

Hmm, thanks for the report then. Mine is aosp and everything on this build works great, as always. :)
 

aLexzkter

Senior Member
Sep 21, 2010
656
177
After full uninstall using 170608 uninstaller, Magisk 13 installing failed. But install 12 version and dirty flash 13 version, it seems working.
And i don't know if you know this problem, magiskhide doesn't work with MIUI Nougat roms..
Logs attached.
Thanks

Same here on a Meizu M2 Note running LineageOS 14.1
If you clean flash a rom and then try flashing the V13 it fails.
I flashed v12 and then dirty flashed v13 and it worked.
 

vsc0705

Member
Feb 4, 2011
16
12
In my case, on LOS based roms and AOSP based roms like RR, AOSPEXTENDED, magsikhide works perfectly.
I think this is related with kernel..
It seems magisk can't detect running apps.
But if it is possible i wanna use magiskhide with stock miui rom.[emoji1]

나의 Redmi Note 4X 의 Tapatalk에서 보냄
 

Rakuu

Senior Member
Jun 16, 2014
2,424
820
Houston
Interesting situation, I tried all combinations of flashing and couldn't get it to work, I was on unofficial v13 fine, and official 12 worked as well, 13 wasn't.
I decided to try and get what logs I could, and out of curiosity tried `su` in terminal emulator from the phone and got a "connection refused" error from sudaemon, so I opened an ad shell and to my surprise had root in that shell! So I ran su for kicks and opened magisk manager again, and all was well! It said I had v13 installed, etc, very odd, not sure what to make of it.
I'm on a Nexus 6p, dirty unicorns 11.4 weekly and flash kernel. Magisk log attached which shows the connection refused errors and then it working after I run su from adb.

Sent from my Nexus 6P using XDA Labs
 

Attachments

  • magisk_error_20170607_200517.log
    38.1 KB · Views: 226
  • Like
Reactions: ikjadoon

Deic

Senior Member
Feb 4, 2012
540
987
Madrid
www.xiaomiadictos.com

I did a script in post-fs-data.d that runs su daemon if is not running and didn't work... I see what when flash v13 the first time and immediately boot you launch Magisk Manager fastly, you have got root, but after the apk is reinstalled automatically and lost root.

Code:
--------- beginning of main
D/Magisk  (  248): client: connect fail, try launching new daemon process
I/Magisk  (  249): Magisk v13.0(0980cb6) daemon started
D/Magisk  (  249): sepol: Starting large patch thread
I/Magisk  (  249): ** post-fs mode running
I/Magisk  (  249): ** post-fs-data mode running
D/Magisk  (  249): resetprop: Initializing...
I/Magisk  (  249): * Mounting /data/magisk.img
I/Magisk  (  249): * Running post-fs-data.d scripts
I/Magisk  (  249): post-fs-data.d: exec [su-daemon.sh]
I/Magisk  (  249): * Loading modules
I/Magisk  (  249): custom-module: constructing magic mount structure
I/Magisk  (  249): Fdroid-Priv: loading [system.prop]
D/Magisk  (  249): resetprop: Load prop file [/magisk/Fdroid-Priv/system.prop]
I/Magisk  (  249): Fdroid-Priv: constructing magic mount structure
I/Magisk  (  249): EmojiOne-systemless: constructing magic mount structure
I/Magisk  (  249): Greenify4Magisk: constructing magic mount structure
--------- beginning of system
D/Magisk  (  336): client: connect fail, try launching new daemon process
I/Magisk  (  343): Magisk v13.0(0980cb6) daemon started
D/Magisk  (  343): sepol: Starting large patch thread
I/Magisk  (  343): ** late_start service mode running
D/Magisk  (  343): su: request from client: 11
D/Magisk  (  343): su: request from uid=[10334] (#1)
D/Magisk  (  343): su: collector started
D/Magisk  (  343): su: wait_result waiting for 3433
D/Magisk  ( 3433): su: child process started
D/Magisk  ( 3433): su: argc=[2]
D/Magisk  ( 3433): su: argv[0]=[su]
D/Magisk  ( 3433): su: argv[1]=[-v]
D/Magisk  ( 3433): su: cwd=[/]
D/Magisk  ( 3433): su: pts_slave=[]
D/Magisk  (  343): su: return code to client: 0
D/Magisk  (  343): su: request from client: 12
D/Magisk  (  343): su: request from uid=[10334] (#1)
D/Magisk  (  343): su: wait_result waiting for 3437
D/Magisk  ( 3437): su: child process started
D/Magisk  ( 3437): su: argc=[1]
D/Magisk  ( 3437): su: argv[0]=[su]
D/Magisk  ( 3437): su: cwd=[/]
D/Magisk  ( 3437): su: pts_slave=[]
D/Magisk  (  343): su: Client killed unexpectedly
D/Magisk  (  343): su: return code to client: 0
D/Magisk  (  343): su: request from client: 11
D/Magisk  (  343): su: request from uid=[10030] (#1)
D/Magisk  (  343): su_db: query policy=[2]
D/Magisk  (  343): su: wait_result waiting for 3676
D/Magisk  ( 3676): su: child process started
D/Magisk  ( 3676): su: argc=[3]
D/Magisk  ( 3676): su: argv[0]=[su]
D/Magisk  ( 3676): su: argv[1]=[-c]
D/Magisk  ( 3676): su: argv[2]=[/system/bin/sh]
D/Magisk  ( 3676): su: cwd=[/]
D/Magisk  ( 3676): su: pts_slave=[]
E/Magisk  ( 3673): read failed with 25: Not a typewriter
D/Magisk  ( 6949): client: connect fail, try launching new daemon process
E/Magisk  ( 6949): start daemon failed with 111: Connection refused
D/Magisk  ( 6951): client: connect fail, try launching new daemon process
E/Magisk  ( 6951): start daemon failed with 111: Connection refused
D/Magisk  ( 6960): client: connect fail, try launching new daemon process
E/Magisk  ( 6960): start daemon failed with 111: Connection refused
D/Magisk  ( 7025): client: connect fail, try launching new daemon process
E/Magisk  ( 7025): start daemon failed with 111: Connection refused
D/Magisk  ( 7126): client: connect fail, try launching new daemon process
E/Magisk  ( 7126): start daemon failed with 111: Connection refused
D/Magisk  ( 7210): client: connect fail, try launching new daemon process
E/Magisk  ( 7210): start daemon failed with 111: Connection refused
D/Magisk  (10872): client: connect fail, try launching new daemon process
E/Magisk  (10872): start daemon failed with 111: Connection refused
D/Magisk  (10904): client: connect fail, try launching new daemon process
E/Magisk  (10904): start daemon failed with 111: Connection refused
D/Magisk  (11046): client: connect fail, try launching new daemon process
E/Magisk  (11046): start daemon failed with 111: Connection refused
D/Magisk  (11097): client: connect fail, try launching new daemon process
E/Magisk  (11097): start daemon failed with 111: Connection refused
D/Magisk  (12571): client: connect fail, try launching new daemon process
E/Magisk  (12571): start daemon failed with 111: Connection refused
D/Magisk  (12576): client: connect fail, try launching new daemon process
E/Magisk  (12576): start daemon failed with 111: Connection refused
 

Attachments

  • Screenshot_2017-06-08-03-34-00-286_com.topjohnwu.magisk.png
    Screenshot_2017-06-08-03-34-00-286_com.topjohnwu.magisk.png
    146.4 KB · Views: 4,224
Last edited:
Status
Not open for further replies.

Top Liked Posts

  • There are no posts matching your filters.
  • 1777
    Hello, welcome to the beta Magisk thread! First check the main thread before starting.
    I expect users reporting to at least have basic debug skills, this thread is heavily moderated so refrain from spamming with "useless" reports!


    Latest Magisk Beta: v16.7 (code: 1671)
    Bundled Magisk Manager: v5.8.3

    Release Note | Changelogs | Download

    If you need a clean start, use the uninstaller in the main thread to uninstall any verison of Magisk installation

    Symptoms and Diagnose Procedure:
    • Installing Magisk fails:
      If you're flashing in TWRP: Upload the recovery logs (pull the file /tmp/recovery.log, or select "Advanced > Copy Log" and upload)
      If you're installing in MagiskManager: Choose to save logs after installation and upload
    • I want to report a Magisk bug:
      Magisk logs are placed in /cache/magisk.log
      If you face any issue, please upload /cache/magisk.log
      Starting from v16.6, /data/adb/magisk_debug.log is NOT USED anymore!
    • Magisk Manager is crashing:
      Grab LOGCAT (NOT magisk logs) when the crash occurs, upload the logs and report how to reproduce
    • SafetyNet / CTS / XXX app won't work after enabling MagiskHide:
      If it worked in previous versions, please at least upload /cache/magisk.log
      Please do NOT SPAM the forum with these kind of issues! It is NOT a priority to fix
    Donation
    I spent endless hours to create Magisk. If you like my work, feel free to donate.
    https://www.paypal.me/topjohnwu
    428
    New Stable Release Coming In a Few Hours!
    Thanks for everyone involved in testing the brand new Magisk and provide useful information for me to fix the bugs :)

    And here I give the moderators a sincere respect, please accept my highest appreciation!
    Everyone on the Internet has a real life, not only me but also the moderators. It's very heartwarming to see them willing to sacrifice their time just to give me a better time on the forums.
    I cannot be more grateful, so thanks to all of you again :good:

    Thread will be temporarily closed until a next beta is available, all future releases (except quick hotfixes) should go through a beta stage before directly going to the masses.
    229
    2017.8.13 Magisk v13.5 (1350)(beta)
    Here comes another public beta!
    As most of you should know, Magisk is a fairly young project, and only recently does it undergo a complete rewrite on v13, so I place stability and compatibility first before I kept adding more features into it. This release comes with several major under-the-hood changes, both in native Magisk and Magisk Manager sides.

    Busybox Fights Back Strong
    Previously I had completely removed busybox from Magisk for causing too many troubles, and also the difficulty to build it myself. But after dealing with so many compatibility issues, and the need of reliable and feature packed command-line tools pushed me to add this gem back. I spent quite a lot of time integrating busybox sources into Magisk's building system, and believe me this isn't an easy task: busybox's config is based on Linux kernel, which itself is a complex topic. I created a tool (ndk-busybox-kitchen) to automatically handle the generation of config-based headers, and parse those files into Android.mk to support building with ndk-build command. To be honest this is super dope IMO, and I'm really proud of it lol.

    The next effort is to maximize compatibility for the Magisk installation process. I decided instead of adding busybox directly into the flashable zip, I would directly embed busybox into update-binary, which is now a specially crafted shell script to dump the correct binary for the CPU architecture, and then execute the installation process completely on the busybox's shell and command-line tools. The extracted busybox will also be utilized in many other places such as boot scripts (yes, the boot scripts will now run in a complete busybox environment) and Magisk Manager. The busybox binary will be installed only for internal use, if you want to install busybox to your device, @osm0sis already uploaded a Magisk Module on the repo, please install that instead.

    Finalizing Magisk Procedures
    Magisk hijacks specific points in the boot process, and will go through its own procedures to fulfill all the features. The order of these procedures are now be finalized, which means it is very less likely to change in the future. For post-fs-data mode, general scripts (scripts under post-fs-data.d) and modules scripts (post-fs-data.sh in each module) are executed before magic mount happens. This means experienced developers can now customize magic mount's behavior to a certain degree. However, I still suggest that most scripts should be run in service mode unless necessary such as time critical commands. Service mode will guarantee SELinux patches are finished, and setting props with proper init triggers will not block the device's boot or lead to a crash.

    Samsung Stock Kernel Workarounds
    Well, apparently Samsung is always here to break everything. On stock kernels, it places a restriction on how binaries can behave if they are executed from /data. An additional magisk binary mirror is created to overcome this issue, and will be used extensively in Magisk Manager (it will not effect recovery). Unfortunately, even though I had offloaded most of the functionality into a shell script function collection that can be upgraded through Magisk updates, the template itself still has to be slightly updated to reflect the changes. Magisk Module Template v5 is already live on another branch. However, before you go and upgrade all your modules to v5, please think twice and consider it as a Developer Preview. It depends on the updated util_functions.sh in this beta, so if you upgrade them into the Online Repo, your module won't install on users running the latest stable Magisk version (v13.3). It will be the default template version once the next stable release is live.

    A Small Mistake
    There was a small mistake in v13.3, which the SHA1 of the stock image cannot be acquired, and also the SHA1 backed up within ramdisk is also not extracted. This leads to stock boot image restoration (happens when uninstalling) fails, and will only revert your device by ramdisk backups. This mean you will be able remove Magisk, but the boot image will not be 100% reverted. If you are concern about the backups, restore your boot image back to stock, and reflash this current build to re-create the Magisk's stock boot image backup.
    227
    Beta releases are no longer "development oriented", this thread will be closed and replaced with a more "experimental channel" thread.
    Thank you to all reported useful logs and info, and I highly appreciate all moderators involved in moderating this thread extensively.