[2019.5.1][Magisk] Systemless Xposed v89.3/v90.2-beta3 (SDK 21-27)

Chainfire · May 31, 2016

I don't run Xposed so I haven't tried anything, but aside from the points you raise yourself in the OP I have some comments:

(1) sukernel. Why are you including sukernel in the package? It should already be installed by SuperSU into /su/bin? Expect issues with this in the future.

(2) /su/lib: I see you are using both /su/lib and /su/lib64. /su/lib should be used for max-bits binaries: 32 bit on 32 bit systems, 64 bit on 64 bit systems - not 32 bit on 64 bit systems. Please use /su/lib32 and /su/lib64 instead if that fits better with your setup.

mikaere66 · May 31, 2016

Systemless SU

topjohnwu said:
Changelog

v85.1
Fixed flash script not installing files issue

v85.0
Initial release

I hope you'll excuse the nube question, but where can I find Systemless SU? I'm currently running v2.65 Pro on MM. I have NOT selected "Install SuperSU into /system" ... does that mean my setup is Systemless?

---------- Post added at 10:15 AM ---------- Previous post was at 10:09 AM ----------

I'm lazy and I didn't build Xposed from source. I hex edited the binaries to load and detect the correct files for systemless.
The arm and arm64 version is modified from Wanam's Xposed. The x86 version is modified from the official Xposed released by rovo89.

Damn! To think I was just about to install this ... I'm now glad I read the rest of the comments. It seems that there's still more work to do to make it polished. I'll keep my eye on it ... great work though =)

romracer · May 31, 2016

Chainfire said:
I don't run Xposed so I haven't tried anything, but aside from the points you raise yourself in the OP I have some comments:

(1) sukernel. Why are you including sukernel in the package? It should already be installed by SuperSU into /su/bin? Expect issues with this in the future.

(2) /su/lib: I see you are using both /su/lib and /su/lib64. /su/lib should be used for max-bits binaries: 32 bit on 32 bit systems, 64 bit on 64 bit systems - not 32 bit on 64 bit systems. Please use /su/lib32 and /su/lib64 instead if that fits better with your setup.

1) Easy to fix.

2) This replicates the setup already in place by Android itself on your /system partition. The libraries in /su/lib (or /system/lib in a non-systemless Xposed) are used by the 32-bit Zygote (and some of the *oat tools in /system/bin). The same is true of the libraries in /su/lib64 or /system/lib64; they are used by the 64-bit Zygote. Android has no /system/lib32 (at least my Nexus phones don't). Are you proposing the layout set forth by Android should be abandon when placing files into /su's file system?

masterv1 · May 31, 2016

Installed it on s7 edge. Xposed is working, but I can't test if android pay is working (can't install it through play store).
When I disable xposed then all xposed apps aren't working after reboot.

Gesendet von meinem SM-G935F mit Tapatalk

Mr.Yawnie · Jun 1, 2016

masterv1 said:
Installed it on s7 edge. Xposed is working, but I can't test if android pay is working (can't install it through play store).
When I disable xposed then all xposed apps aren't working after reboot.

Gesendet von meinem SM-G935F mit Tapatalk

Of course the xposed modules are not working when xposed is disabled.. That's the definition of disabled = not usable. The option to disable xposed is there to (possibly) get android pay to work. Right now it's either or. The advantage of this systemless xposed is that it only requires quick reboot to switch between on and off, and not uninstalling whole xposed framework from system, which then causes all apps to optimize, which in turn takes time.

Sent from my GT-I9505 using Tapatalk

Chainfire · Jun 1, 2016

romracer said:
2) This replicates the setup already in place by Android itself on your /system partition. The libraries in /su/lib (or /system/lib in a non-systemless Xposed) are used by the 32-bit Zygote (and some of the *oat tools in /system/bin). The same is true of the libraries in /su/lib64 or /system/lib64; they are used by the 64-bit Zygote. Android has no /system/lib32 (at least my Nexus phones don't). Are you proposing the layout set forth by Android should be abandon when placing files into /su's file system?

/su was created for SuperSU, what the layout is in /system is irrelevant, it was never meant to reflect /system. SuperSU installs the most-bits version of its tools (32-bits on 32-bit devices, 64-bit on 64-bit devices) in /su/bin and /su/lib. It has never made the distinction because there's always only one version installed.

I am not proposing anything. I am simply warning that this can potentially end up mixing 32-bit and 64-bit libraries in the same folder, which is a jolly bad idea, and it will at some point end up making some binary malfunction. A work-around is using lib32 and lib64 instead (or if the entire folder is going to be bound, lib32_bind and lib64_bind).

WhammyDroid · Jun 1, 2016

Thanks for creating this! Will the systemless changes be submitted to rovo89 for consideration?

LuanTeles · Jun 1, 2016

Now my bootlogo says kernel is not enforcing!

how to get rid of it?

JohnCorleone · Jun 1, 2016

topjohnwu said:
The x86 version has a few downloads now.
Is the x86 working as expected? Can anyone report if it works?

I am very excited that you put this together and that you have the HTC 10 (as I do) so I know that everything will work if I properly follow the steps. Are you s-off or s-on? Also did you change CID and/or MID? I am looking to keep my T-Mobile firmware (for now) because I got the 30 channel Sling TV package for $13.99 a month and I want to keep that discount! I am bone stock because I was pretty much hoping that this would come along... HUGE THANKS for your work! :cowboy:

---------- Post added at 01:15 AM ---------- Previous post was at 01:08 AM ----------

koko115 said:
Any one test this xposed in Galaxy S7 ?
Edit.
I try on S7 and no framework loaded. ;-(

Did the developers ever get Xposed working on the S6 or S6 Edge? I am not being a smarta$$, I just remember a period where it wasn't playing nicely with Samsung's ART modifications

Cass67 · Jun 1, 2016

Nice, seems to work on LG G5..

JohnCorleone · Jun 1, 2016

5upon said:
Hmm. How did you test? I used to get blocked by SafetyNet when I tried to add a card. Today, after deactivating Xposed and rebooting, I was able to add a card, but I haven't tried to make a purchase yet.

I'll switch to systemless Xposed the next time I update my ROM. Hopefully it will become the default install method. @rovo89 mentioned the possibility of going systemless a while ago but said he didn't plan to work on it.

Sometimes you can add a card but it won't work when you go to pay. This is as far as people got using Xposed and Root Cloak module before these new goodies came along.

---------- Post added at 01:26 AM ---------- Previous post was at 01:24 AM ----------

Cass67 said:
Nice, seems to work on LG G5..

Did you actually use Android Pay to buy something or just add the card? If you already tested paying, I am getting everything ready as soon as I get back home!

romracer · Jun 1, 2016

Chainfire said:
/su was created for SuperSU, what the layout is in /system is irrelevant, it was never meant to reflect /system. SuperSU installs the most-bits version of its tools (32-bits on 32-bit devices, 64-bit on 64-bit devices) in /su/bin and /su/lib. It has never made the distinction because there's always only one version installed.

I am not proposing anything. I am simply warning that this can potentially end up mixing 32-bit and 64-bit libraries in the same folder, which is a jolly bad idea, and it will at some point end up making some binary malfunction. A work-around is using lib32 and lib64 instead (or if the entire folder is going to be bound, lib32_bind and lib64_bind).

Sorry, I'm not trying to be obtuse, it was a genuine question. As the options for "system-less" things expands, I think these are valid questions so that we can be sure to all follow the same guidelines.

If no special meaning should be held to the layout of /system, then its no problem to use /su/lib32 and /su/lib64. Perhaps it adds additional complexity to falling back to /system/lib (when relevant) but only trivially so. I guess in hindsight SuperSU could have used /su/lib64 when appropriate, but SuperSU's implementation should be treated as a blackbox anyway (imho) so we shouldn't expect SuperSU to fit "our" patterns.

Regarding mixing libraries, can you elaborate? Is it possible for the dynamic linker to load a 32-bit library into a 64-bit binary (or vice-versa)? I've never had luck with that. Additionally, unless these /su/lib* paths are being added to every process's LD_LIBRARY_PATH, how is the linker ever going to even find them? Remember, at least for Xposed, the libraries placed there are bind mounted to /system (where the linker is actually looking).

Lastly, regarding lib32_bind and lib64_bind, are these documented anywhere? I find nothing in Google for them except for your earlier post today. They seem like what we really want anyway (at least here).

Cass67 · Jun 1, 2016

JohnCorleone said:
Sometimes you can add a card but it won't work when you go to pay. This is as far as people got using Xposed and Root Cloak module before these new goodies came along.

---------- Post added at 01:26 AM ---------- Previous post was at 01:24 AM ----------

Did you actually use Android Pay to buy something or just add the card? If you already tested paying, I am getting everything ready as soon as I get back home!

Not used it yet, added card only.

Though have found an issue, after disabling xposed via toggle and rebooting it appears that the toggle has gone to re-enable xposed, installing the same framework or installer app seems not to fix it. Installer sees framework is installed but just not active.. Dunno what im missing here..

Edit - not missing anything, its a bug. Post 751 on material design installer thread describes this toggle behaviour.

RobboW · Jun 1, 2016

Installed this to my Oppo Find 7 (arm 32 bit) running OmniROM 6.0
Working nicely!
Will be interesting to apply the next full Omni update and see what survives.

I don't care about Android Pay.

Sapphire999 · Jun 1, 2016

Did anyone test it on Samsung touchwiz?(in my case galaxy note 4)

Sent from my Samsung Galaxy Note 4 using XDA Labs

topjohnwu · Jun 1, 2016

Chainfire said:
I don't run Xposed so I haven't tried anything, but aside from the points you raise yourself in the OP I have some comments:

(1) sukernel. Why are you including sukernel in the package? It should already be installed by SuperSU into /su/bin? Expect issues with this in the future.

(2) /su/lib: I see you are using both /su/lib and /su/lib64. /su/lib should be used for max-bits binaries: 32 bit on 32 bit systems, 64 bit on 64 bit systems - not 32 bit on 64 bit systems. Please use /su/lib32 and /su/lib64 instead if that fits better with your setup.

Thanks for the heads up! I learned a lot from your systemless SuperSU, also shamelessly "borrowed" your ramdisk patching binary to save a lot of headache unpacking/repacking boot image

. Here I'll answer the questions

The flashing script will also handle the case that /data is not able to mount, such as devices with proprietary encryption that TWRP cannot decrypt correctly. I'll create /cache/su.img if /data/su.img and /cache/su.img are both not found, and place the files over there. I this case, we cannot access the sukernel installed into su.img. Then the mount_xposed.sh should merge /cache/su.img to /data/su.img (the same thing you've done in launch_daemonsu.sh).
What are the disadvantages including the binaries in the package? May you tell me the potential issues that might happen in the future?
Just like what @romracer said, I reflected the layout of /system, so that the flashing script is easy to write. I can separate the library installing commands with their own functions, but I don't see what will really cause problems. I bind mount individual files in the folders, not mirror the whole directory into system. If you're really concerned about the issue, a better way is to put all Xposed released files into a directory, and reflect system folders as subdirectories in that folder (so I don't have to massively change my flashing script).

Again, many thanks, Chainfire

nansah · Jun 1, 2016

mati_boy said:
Works great! Only the app says xposed 85.0 is installed but it's actually 85.1. Probably something you didn't edit because twrp also thought it was 85.0 [emoji2]

Did you figure a way to let it show? All the pictures I'm seeing seems to be only showing on the 64bit version but not the 32bit version like OPO......
Any thoughts?

topjohnwu · Jun 1, 2016

nansah said:
Did you figure a way to let it show? All the pictures I'm seeing seems to be only showing on the 64bit version but not the 32bit version like OPO......
Any thoughts?

Nah... maybe I forgot to update xposed.prop in the arm version.
If everything is working fine for you, then it's good. v85.0 and v85.1 only differs in the flash script, the files are the same.

nansah · Jun 1, 2016

Thanks for the clarification, I appreciate that ????

ahrion · Jun 1, 2016

I already have the official xposed installed with systemless root. Can I just use the official uninstaller and then flash this? Or is there another protocol besides doing a complete wipe?

[2019.5.1][Magisk] Systemless Xposed v89.3/v90.2-beta3 (SDK 21-27)

Moderator Emeritus / Senior Recognized Developer

mikaere66

Guest

Senior Member

Senior Member

Senior Member

Moderator Emeritus / Senior Recognized Developer

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Recognized Developer / Inactive RC

Member

Senior Recognized Developer / Inactive RC

Member

Retired Forum Moderator / Recognized Developer

Similar threads

Top Liked Posts