[MAGISK] Google camera with telephoto lens

sipollo · Mar 23, 2018

Hi everybody!
I made a very simple module to expose auxiliary camera to @cstark27 Google Camera port.
As you may know his app is targeted to LGs wide cameras, but with this module you can use his app to take wonderful shots with our telephoto lens.
I originally posted here:
http://www.androidiani.com/forum/mo...ocamera-zoom-2x-ottico-con-google-camera.html

UPDATE V2:
Now is included fix for WhatsApp camera crashes when rotating phone.
https://xdaforums.com/showpost.php?p=76506333&postcount=134

CUSTOM ROMS version:

This version enables Zoom support for Cstark27 "wide" versions WITHOUT breaking stock camera portrait mode.

I had to merge my fix with @ramesh1686 work.
https://xdaforums.com/showpost.php?p=77984552&postcount=289

Known bugs:

Sometimes setting flash to "auto" makes dark photos. Set flash ON or OFF instead.

Istructions:

Install the module you need.
Reboot.

Install one of Cstark27 Google Camera "wide" or "tele" port.

Enjoy

Tested with Xiaomi mi a1 but it might work with other models too. (Dual cameras models of course)

A quick comparison:
http://www.androidiani.com/forum/mo...reo-porting-google-camera-31.html#post7995410

jeneb11 · Mar 23, 2018

cstark27 · Mar 23, 2018

Nice work! Hopefully this gets it in the hands of more capable devs! I look forward to seeing the progress.

PS: V3.3 is a couple versions old, but if it works the best no problem. Just though I'd mention that. The up to date thread can be found here.

Here's what's changed to access the secondary rear camera for Google Camera. The code is a little different on my newer versions because I added a toggle to fix LG G6 Lineage OS Camera ID, but the concept is the same and this is simpler to show.

iga.smali

Code:

    :cond_0
    :try_start_1
    iget-object v0, p0, Liga;->b:Landroid/hardware/camera2/CameraManager;

    invoke-virtual {v0}, Landroid/hardware/camera2/CameraManager;->getCameraIdList()[Ljava/lang/String;

    move-result-object v2

    invoke-static {v2}, Liya;->b(Ljava/lang/Object;)Ljava/lang/Object;

    new-instance v3, Ljava/util/ArrayList;

    array-length v0, v2

    invoke-direct {v3, v0}, Ljava/util/ArrayList;-><init>(I)V

    array-length v4, v2

    const/4 v0, 0x1     [B]<------------ Start at Camera ID 1 (Front Camera)[/B]

    :goto_0
    if-ge v0, v4, :cond_1     [B]<------------ If greater or equal to 'v4' then skip the code below and continue[/B]

    aget-object v5, v2, v0

    new-instance v6, Ligc;

    invoke-static {v5}, Ligc;->a(Ljava/lang/String;)Ljava/lang/Integer;

    move-result-object v7

    invoke-direct {v6, v5, v7}, Ligc;-><init>(Ljava/lang/String;Ljava/lang/Integer;)V

    invoke-interface {v3, v6}, Ljava/util/List;->add(Ljava/lang/Object;)Z

    add-int/lit8 v0, v0, 0x1     [B]<------------ Add 1 to counter to end at Camera ID 2 (Secondary rear)[/B]

    goto :goto_0     [B]<------------ Loop back to goto_0 label[/B]

ecu.smali This edit fixes it so ZSL HDR+ works

Code:

    const-string v4, "Acquired metadata from the first frame."

    invoke-interface {v3, v4}, Licu;->b(Ljava/lang/String;)V
    :try_end_0
    .catch Ljava/util/concurrent/ExecutionException; {:try_start_0 .. :try_end_0} :catch_0

    move-object/from16 v0, p0

    iget-object v3, v0, Lecu;->e:Lgdq;

    invoke-interface {v3}, Lgdq;->a()Ligc;

    move-result-object v3

    invoke-virtual {v3}, Ligc;->a()I

    move-result v4
	
	const v3, 0x2      [B]<----- add this line. Sets a variable to 2 (Camera ID 2)[/B]
	
	if-ne v4, v3, :cond_f    [B] <--------- add this line. If v4 is not equal to v3, skip over next line (this means if Camera ID is not 2, then keep the ID number and carry on)[/B]
	
	const v4, 0x0       [B]<-------- add this line. Sets the variable to 0 (Camera ID 0). This means that if the Camera ID is set to 2 (Wide Angle app) then we need to make GCam think the ID is 0 for it to do ZSL HDR+ Processing.[/B]
	
	:cond_f           [B]<-------- add this line for the reference above[/B]
    :try_start_1
    move-object/from16 v0, p0

    iget-object v3, v0, Lecu;->c:Licu;

    const-string v5, "Starting HdrPlus#ZslShotCapture."

To get all cameras working in the app, we probably need to add a toggle that goes back to iga.smali and changes the start value to 0. Good luck!
@aer0zer0 this thread may be worth checking out for your phone/mods.

FerrarisIV · Mar 23, 2018

Great job. I flashed your module to try and the pictures in 2X are very nice!

Here the difference

ondy182 · Mar 23, 2018

Working great, thank you so much!

duniatri · Mar 24, 2018

Yes, it's working great. I'm using latest version of @cstark27 Gcam. Hdr+ result for zoom camera is also great!
Thanks for your works!

Just one question, is there any possibility in the future that one moded Gcam can use both normal and zoom lens? Like it has a switch to choose between normal and zoom lens.

Now i have 3 camera version, miui cam, arnova's, and cstark's. I think that's too much

Rajeev · Mar 24, 2018

duniatri said:
Yes, it's working great. I'm using latest version of @cstark27 Gcam. Hdr+ result for zoom camera is also great!
Thanks for your works!

Just one question, is there any possibility in the future that one moded Gcam can use both normal and zoom lens? Like it has a switch to choose between normal and zoom lens.

Now i have 3 camera version, miui cam, arnova's, and cstark's. I think that's too much

Which one u using latest? Normal or wide cam ?

duniatri · Mar 24, 2018

Rajeev said:
Which one u using latest? Normal or wide cam ?

Wide (zoom) one

Rajeev · Mar 24, 2018

duniatri said:
Wide (zoom) one

Thanks friend. Still settling force close is there right?

duniatri · Mar 24, 2018

Rajeev said:
Thanks friend. Still settling force close is there right?

Nope. No force close on setting and video on last version. All good so far :good:

Rajeev · Mar 24, 2018

duniatri said:
Nope. No force close on setting and video on last version. All good so far :good:

Fantastic.. :good:

sikoo1996 · Mar 24, 2018

Rajeev said:
Thanks friend. Still settling force close is there right?

Version 3.6 wide angle camera getting fc on setting.
I am on stock feb beta

cstark27 · Mar 24, 2018

duniatri said:
Nope. No force close on setting and video on last version. All good so far :good:

That's Arnova's version I believe. The Wide (zoom) app should say Camera (Wide). My version Settings doesn't have the margins in the left and has a couple different options.

I'm going to assume that there's no Video related parameters available through the Camera2 API for the Zoom lens, so when you try to go to settings it crashes when it's trying to find that info. Not sure when I'll have time to dig into for you guys.

How does GCam 2x digital zoom on your regular lens compare to using GCam on the Zoom lens?

sipollo · Mar 24, 2018

cstark27 said:
How does GCam 2x digital zoom on your regular lens compare to using GCam on the Zoom lens?

Night and day difference.

Rajeev · Mar 24, 2018

Finally no more ****ty Beauty mod.. Superb.. If we get working settings then can make some changes too...

@sipollo and @cstark27 thanks for everything

joeyhuab · Mar 24, 2018

Rajeev said:
Finally no more ****ty Beauty mod.. Superb.. If we get working settings then can make some changes too...

@sipollo and @cstark27 thanks for everything

Which version you using? Pixel 2 Mod by Arnova and Tolyan?

Rajeev · Mar 24, 2018

joeyhuab said:
Which version you using? Pixel 2 Mod by Arnova and Tolyan?

Same version that available in OP bro. And my primary GCam is MGC Final v3.4. Using cstark version only for Telephoto... I think only cstark version support Telephoto. Am i correct?

joeyhuab · Mar 24, 2018

Rajeev said:
Same version that available in OP bro. And my primary GCam is MGC Final v3.4. Using cstark version only for Telephoto... I think only cstark version support Telephoto. Am i correct?

Thanks! Will stock to Tolyan's version for primary GCam.

Will stick to v3.3 for Camera (Wide) but hopefully someone updates the app for v3.6 support.

duniatri · Mar 24, 2018

cstark27 said:
That's Arnova's version I believe. The Wide (zoom) app should say Camera (Wide). My version Settings doesn't have the margins in the left and has a couple different options.

I'm going to assume that there's no Video related parameters available through the Camera2 API for the Zoom lens, so when you try to go to settings it crashes when it's trying to find that info. Not sure when I'll have time to dig into for you guys.

How does GCam 2x digital zoom on your regular lens compare to using GCam on the Zoom lens?

It's your cam. I can go to settings, open video, and even see 'about' to see your cam version. See my screenshot. Ohya, video recording also works :good:

joeyhuab · Mar 24, 2018

duniatri said:
It's your cam. I can go to settings, open video, and even see 'about' to see your cam version. See my screenshot. Ohya, video recording also works :good:

Which ROM are you using and what other modules do you have installed? I installed the module and APK linked in the OP but the Camera (Wide) crashes in Pixel Experience ROM.

[MAGISK] Google camera with telephoto lens

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Inactive Recognized Contributor

Senior Member

Inactive Recognized Contributor

Senior Member

Attachments

Inactive Recognized Contributor

Senior Member

Senior Member

Senior Member

Inactive Recognized Contributor

Attachments

Recognized Developer

Inactive Recognized Contributor

Recognized Developer

Senior Member

Attachments

Recognized Developer

Similar threads

Top Liked Posts