you should have welcomed magisk instend of fighting it
the install process was always painful and prone to breakage magisk simplifyed the install
and no ad injection is never ever ever acceptable
and as far as credit ... due to the very questionable legality of the project you are lucky it wasn't removed on sight
I think that I can decide on my own what I should or should not welcome, but thanks for trying.
I've never had a single issue with installing OGYT and I must have done it a good couple hundred times... If someone doesn't know how to install/replace a system app, that person should either do some xda searching and reading or avoid rooting their phones altogether because messing up their phone is all that this will do for them.
It's all a matter of perspective and personal moral: I generally don't have much problem with people moding/hacking the stuff from abusive monopolistic big corporations. But as far as that magisk for OGTY thread, whoever started it, originally had no mention of OGMods at all and barely had a line saying: "thanks to the author". So that to me, was unacceptable and I didn't approve it. And I still don't approve it because OGYT has been stopped for legal matters with Google/YT. So why would magisk for OGYT risks of putting XDA into trouble?
The argument that the same should have applied to OGYT is true, but until Google comes knocking, I think that the project was not involving any direct liability to Xda and it had the benifit of the doubt. Well now that Youtube came with their lawyers' letter and that OGMods has promptly stopped his development, 'creating' (no big creation there) an installer and a few new themes for that exact same project under a new Xda thread is not what I would consider something new that would make it's legality questionable. So yes -in my view at least- that guy is now putting Xda at risk. I'm not fighting it too hard though: I've wrote a couple posts about it and never brought it up to Xda's attention...
And yes, we have been lucky with OGYT for a very long time and I'm most grateful for that.