Hi all,
I have been pretty busy the last weeks but I finally got some progress with Android 10 issues (it's a day off here, it definitely helps!).
Feedback:
Here is the verbose logcat of whats going on. I am still getting the "Copy Failed" error when I try to update hosts and at "Bulding Hosts File" stages in AA.
Thanks for your log. Don't forget to enable verbose logging option from the settings and restart the app.
It will log shell commands so we can understand even better what happens on your device.
@mariosaraylian
From the steps you describe.
I didn't see you mention AdAway requesting and gaining root access.
I haven't run into it lately, for me, it was always Magisk related.
All other apps / modules seem to work fine but, AdAway always showed me when my Magisk install was broken.
I know I've seen others mention just being able to toggle SU on or off/on for AdAway in Magisk's Superuser settings. If you take a look at the log file in Magisk, you should see a su request once or twice while AdAway is updating (or attempting) to update the hosts file.
@ktmom
May be a change coming down the line but, for now I would still recommend enabling the magisk systemless module.
Thanks for helping users and me with troubleshooting!
I would also recommend to use Magisk systemless module if you are running Magisk as root solution.
I just update the app in order to improve its systemless feature for the latest versions of Magisk:
- It should be able to check if the module is installed (the directory /data/adb/modules/hosts is present) and running (a mount point on /system/etc/hosts is present)
- If you try to enable / disable it from the app, it brings a popup explaining how to set it up from Magisk manager.
I hope it will help users with the
remount failed errors.
About the root access not requested, killfrra proposed a patch to no more try to find su binary from known paths but call it directly from PATH.
It is how work ChainFire's libsuper and topjohnwu's libsu so it should work. I just hope it won't break any compatibility (but I honestly don't think so).
I merged it and it should resolve root request. May be it remains some old su binary or broken link to it and the past behavior triggered the wrong one. I will rely on PATH now.
Changelog:
- Fix root not requested
- Improve support for systemless hosts Magisk module
- Update translations
Thanks:
Special thanks to killfra for its contribution and all of you for theirs helpful bug reports.
@Vankog also did a great work with translations.
Donations:
I was recently accepted in the GitHub Sponsors program. It is a way GitHub proposes to help Open Source maintainers.
I setup up the support tiers and rewards, like stickers and supporter list on the project README.
Here is the link to my sponsor page:
https://github.com/sponsors/PerfectSlayer
I am kind of new to this kind of this and I honestly want to know what you think about it: the principle of monthly fee and the tiers I choose (Too expensive? Too cheap? Any reward idea?).
GitHub takes no fee and double the donation the first year so I though it was a good idea to try it.
For the record, since the call for donation from
@ktmom last month I received 10 donations for a total of 54€ to pay the shipping taxes. Thanks a lot! :highfive:
Download:
AdAway 4.3.0 on AndroidFileHost (md5: 54bc1ab9aa83bcdb300de7e4bf7e6271)