Requesting Repository Forks

Search This thread

Entropy512

Senior Recognized Developer
Aug 31, 2007
14,088
25,086
Owego, NY

Nope. We're not blindly forking CyanogenMod repositories. We are most definitely not using CM's frankendisplay mess.

All devices that use caf-new in CM should be using caf-bfam in Omni.

The only one of those repos I'm willing to consider forking is the kernel. You may need to make some kernel changes to work with the caf-bfam repos.
 

DeviousFusion

Senior Member
Nope. We're not blindly forking CyanogenMod repositories. We are most definitely not using CM's frankendisplay mess.

All devices that use caf-new in CM should be using caf-bfam in Omni.

The only one of those repos I'm willing to consider forking is the kernel. You may need to make some kernel changes to work with the caf-bfam repos.

Alright.. I just synced up the caf-bfam, and looks like the kernel indeed would need modifications(so yeah don't include in repos as of now) as the compile gives:

Code:
hardware/qcom/media-caf-bfam/mm-video-v4l2/vidc/vdec/src/omx_vdec_msm8974.cpp:9377:84: error: invalid conversion from 'ion_user_handle_t {aka int}' to 'ion_handle*' [-fpermissive]
hardware/qcom/media-caf-bfam/mm-video-v4l2/vidc/vdec/src/omx_vdec_msm8974.cpp:470:1: error:   initializing argument 4 of 'VideoHeap::VideoHeap(int, size_t, void*, ion_handle*, int)' [-fpermissive]

Can you help with that? Or give me some pointers?
 

Entropy512

Senior Recognized Developer
Aug 31, 2007
14,088
25,086
Owego, NY
Alright.. I just synced up the caf-bfam, and looks like the kernel indeed would need modifications(so yeah don't include in repos as of now) as the compile gives:

Code:
hardware/qcom/media-caf-bfam/mm-video-v4l2/vidc/vdec/src/omx_vdec_msm8974.cpp:9377:84: error: invalid conversion from 'ion_user_handle_t {aka int}' to 'ion_handle*' [-fpermissive]
hardware/qcom/media-caf-bfam/mm-video-v4l2/vidc/vdec/src/omx_vdec_msm8974.cpp:470:1: error:   initializing argument 4 of 'VideoHeap::VideoHeap(int, size_t, void*, ion_handle*, int)' [-fpermissive]

Can you help with that? Or give me some pointers?
My guess would be:
https://github.com/omnirom/android_...mmit/df78d33ea0c199e4b02f5207f2c351d0eef10f06
https://github.com/omnirom/android_...mmit/6823aadbef06b13691cc8430cfa599133a9ccd76
 
  • Like
Reactions: DeviousFusion

adeii

Senior Member
Nov 11, 2013
413
93
Sajlent Hil
Alright.. I just synced up the caf-bfam, and looks like the kernel indeed would need modifications(so yeah don't include in repos as of now) as the compile gives:

Code:
hardware/qcom/media-caf-bfam/mm-video-v4l2/vidc/vdec/src/omx_vdec_msm8974.cpp:9377:84: error: invalid conversion from 'ion_user_handle_t {aka int}' to 'ion_handle*' [-fpermissive]
hardware/qcom/media-caf-bfam/mm-video-v4l2/vidc/vdec/src/omx_vdec_msm8974.cpp:470:1: error:   initializing argument 4 of 'VideoHeap::VideoHeap(int, size_t, void*, ion_handle*, int)' [-fpermissive]

Can you help with that? Or give me some pointers?
This is so elegant solution https://gist.github.com/adrian-bl/999e5cd68246713d9cf7
 
  • Like
Reactions: raynofff

Top Liked Posts

  • There are no posts matching your filters.
  • 4
    CM bootable recovery and some commits over system core :)

    No for CWM - We're working on forking TWRP in, but some fixes still need to be made to allow it to work on devices with unified recovery/boot image. (Probably one of the biggest holdups for the exynos 4210 family - Sonys with unified boot/recovery can at least use Dees_Troy's FOTAKernel trick).

    Getting CWM to build in a tree requires hacks all over the tree in multiple repositories. TWRP is much more self-contained, but needs some tweaks to the build system in order to get it to build properly on a userdebug (as opposed to eng) build.
    2
    If you wish to request omni forks a repository from AOSP, in order to implement a patch into omni, please post this request here. Eventually this will be carried out via jira (http://jira.omnirom.org)

    When posting, please give the path to the repository, and a link to what you want to merge, or a description.

    For example if you wish to cherry pick a patch into it, a link to the patch and brief description of the reason for the patch.

    We'll then have that repository forked and made available on github and gerrit, permitting you to submit your change.

    Before you request, please check on github to ensure it isn't already forked!


    For example :

    frameworks/base - Needing forked so I can introduce multi window functionality (link here to information)
    1
    android_external_clang

    http://review.cyanogenmod.org/#/c/29799/2

    Needed for building my msm8960 device (Motorola Photon Q, xt897c).
    1
    Hmm but until the twrp is ported should i test build for some galaxy devices like SG S2 note 1 with cwm ?
    It will make me to push changes to git in device tree ... and will be easy to add support :)

    I'll pull up a remote to use for bootable/recovery until we fork (unless plodey already forked it) from TWRP, won't be able to provide it until tonight.

    However, right now, it will only build a working recovery if you do an eng build instead of userdebug. If Dees_Troy's talk at BABBQ is ever posted, that's what I was talking about when I trolled him at the end. ;)

    Something like:
    Code:
    . build/envsetup.sh && brunch custom_n7000-eng
    or something like that.
    1
    Alright.. I just synced up the caf-bfam, and looks like the kernel indeed would need modifications(so yeah don't include in repos as of now) as the compile gives:

    Code:
    hardware/qcom/media-caf-bfam/mm-video-v4l2/vidc/vdec/src/omx_vdec_msm8974.cpp:9377:84: error: invalid conversion from 'ion_user_handle_t {aka int}' to 'ion_handle*' [-fpermissive]
    hardware/qcom/media-caf-bfam/mm-video-v4l2/vidc/vdec/src/omx_vdec_msm8974.cpp:470:1: error:   initializing argument 4 of 'VideoHeap::VideoHeap(int, size_t, void*, ion_handle*, int)' [-fpermissive]

    Can you help with that? Or give me some pointers?
    My guess would be:
    https://github.com/omnirom/android_...mmit/df78d33ea0c199e4b02f5207f2c351d0eef10f06
    https://github.com/omnirom/android_...mmit/6823aadbef06b13691cc8430cfa599133a9ccd76