[9] GlassROM

Status
Not open for further replies.

anupritaisno1

Senior Member
Apr 29, 2014
1,811
1,900
153
Guys P is out

Changelog: upstreamed kernel to the latest
Upstreamed F2FS
Upstreamed sdfat driver
Upstreamed WiFi driver
Forced encryption now does not make the device get stuck at boot
Fixed an issue that would cause repetitive lockscreen crashes
You can now plug in usb drives formatted as fat/fat16/fat32/exfat and they will be recognised
Hardened fstab mount flags
F2FS is currently unsupported and it is unlikely that it will be added in a future release

Note: all op3 sources have been fully moved to https://github.com/GlassROM-devices including the kernel source

Instructions: just flash it

For users already on 8.1 dirty flash should work. No wiping is required
 

anupritaisno1

Senior Member
Apr 29, 2014
1,811
1,900
153
Clarification about magisk:

You can use it but if you think that there is a bug please reflash the ROM and check if the bug exists without magisk installed

If the bug does not exist when magisk is not installed then please report it to the magisk developer and not to me
 

abhibnl

Senior Member
Oct 13, 2011
3,595
1,463
0
Out of curiosity, is there any reason you are implementing "force encryption" on this custom non-OOS ROM? While it's your ROM so your decisions but unless you feel there is something in this ROM that would require encryption, shouldn't it be a user's choice if they want to run an non-encrypted storage or encrypted one?
 

anupritaisno1

Senior Member
Apr 29, 2014
1,811
1,900
153
Out of curiosity, is there any reason you are implementing "force encryption" on this custom non-OOS ROM? While it's your ROM so your decisions but unless you feel there is something in this ROM that would require encryption, shouldn't it be a user's choice if they want to run an non-encrypted storage or encrypted one?
Was never my intention to make a "custom" ROM

The best you can call it is something that's almost a stock ROM or "aftermarket firmware"

It behaves like a stock ROM in every way and has experimental support for booting off locked bootloaders
 

abhibnl

Senior Member
Oct 13, 2011
3,595
1,463
0
Was never my intention to make a "custom" ROM

The best you can call it is something that's almost a stock ROM or "aftermarket firmware"

It behaves like a stock ROM in every way and has experimental support for booting off locked bootloaders
Thanks for sharing your vision. The project actually sounds way cooler now. Once I decide to jump ship to P roms, I would definitely try this one.
 

TheMystic

Senior Member
Mar 18, 2017
450
178
53
Guys P is out

Changelog: upstreamed kernel to the latest
Upstreamed F2FS
Upstreamed sdfat driver
Upstreamed WiFi driver
Forced encryption now does not make the device get stuck at boot
Fixed an issue that would cause repetitive lockscreen crashes
You can now plug in usb drives formatted as fat/fat16/fat32/exfat and they will be recognised
Hardened fstab mount flags
F2FS is currently unsupported and it is unlikely that it will be added in a future release

Note: all op3 sources have been fully moved to https://github.com/GlassROM-devices including the kernel source

Instructions: just flash it

For users already on 8.1 dirty flash should work. No wiping is required
Hi!

Can you please assist:
 

Attachments

anupritaisno1

Senior Member
Apr 29, 2014
1,811
1,900
153
Can you tell me if there is anything wrong with my data partition? I'm using my phone normally and there are no errors or problems whatsoever.
TWRP does not open encrypted block devices with "allow-discards" and by default the Linux kernel forbids sending discards to an encrypted block device
You should run that command when you're booted into the system
 

TheMystic

Senior Member
Mar 18, 2017
450
178
53
TWRP does not open encrypted block devices with "allow-discards" and by default the Linux kernel forbids sending discards to an encrypted block device
You should run that command when you're booted into the system
It's been a while since I did clean flash of the ROM, but whenever I did, I have successfully run all 3 commands before the clean flash, and my device has always been encrypted, and always using TWRP.

Can I run this command from within the system without data loss?
 

anupritaisno1

Senior Member
Apr 29, 2014
1,811
1,900
153
It's been a while since I did clean flash of the ROM, but whenever I did, I have successfully run all 3 commands before the clean flash, and my device has always been encrypted, and always using TWRP.

Can I run this command from within the system without data loss?
I have never seen a proper fstrim binary on android. It's always some tiny version with busybox which is not exactly compliant to the standard

fstrim is part of util-linux

Will you have data loss? I cannot comment as I did not ship such a binary in the ROM to begin with
 

AL2000EX

Senior Member
Aug 17, 2013
168
84
0
It's been a while since I did clean flash of the ROM, but whenever I did, I have successfully run all 3 commands before the clean flash, and my device has always been encrypted, and always using TWRP.

Can I run this command from within the system without data loss?
There's nothing wrong with your data partition, you don't need to worry about fstrim as trim is already performed regularly on /data. Forcing trim from userspace isn't how it's meant to work anyway.
 
  • Like
Reactions: TheMystic

anupritaisno1

Senior Member
Apr 29, 2014
1,811
1,900
153
Updated

Changes:
Upstreamed F2FS to 5.1-rc1
F2FS is reenabled (but is on a separate build)
Enabled privileged access never emulation (PAN)
Made kernel text and rodata read-only
Kernel hardening (based on public grsecurity patches)
Fixed CVE-2019-8912 (severity rating by security researcher: anupritaisno1: HIGH, Atmos: CRITICAL)
Fixed a serious bug where using gestures when the phone has a screen lock would cause a system crash
Tripndroid is now the default I/O scheduler
Upstreamed lz4 driver. You can use a kernel manager program to manually use lz4 compression for zram. Other than that this currently has no use but it might in the future
Wireguard support. Note that ipv6 support on android is unreliable with the kernel module so confirm with ipv6.test-ipv6.com to make sure you aren't leaking ipv6 traffic when using wireguard. Note that glassrom does NOT recommend disabling ipv6 because you're literally cutting yourself off from a part of the internet by doing so
Kernel debugging is reenabled
Page table isolation (you might know it as KAISER) is enabled even if our CPU is not vulnerable to meltdown as it protects against several vulnerabilities other than meltdown
Upstream lineage changes: all the changes already included in the latest lineage nightly

The update adds 2 zips: op3_ext4.zip and op3_f2fs.zip
Both will only support one filesystem and not the other
If you use ext4 then /data and /cache MUST be ext4
If you use f2fs then /data and /cache MUST be f2fs
 

anupritaisno1

Senior Member
Apr 29, 2014
1,811
1,900
153
There's nothing wrong with your data partition, you don't need to worry about fstrim as trim is already performed regularly on /data. Forcing trim from userspace isn't how it's meant to work anyway.
The main issue is that I have never found a compliant fstrim binary that actually works like the one on a GNU system on android

It's always some tiny busybox or some other applet which is not standards compliant

So how exactly can I guarantee that the command will not break stuff?
 

TheMystic

Senior Member
Mar 18, 2017
450
178
53
@anupritaisno1

I just rebooted my phone and it takes me to the same Decryption Unsuccessful screen. I don’t even have a nandroid backup now, unlike last time.

There were some important communications that I had on WhatsApp today, and unfortunately it isn’t backed up either.

Is there a way to somehow boot into the system successfully?
 

anupritaisno1

Senior Member
Apr 29, 2014
1,811
1,900
153
@anupritaisno1

I just rebooted my phone and it takes me to the same Decryption Unsuccessful screen. I don’t even have a nandroid backup now, unlike last time.

There were some important communications that I had on WhatsApp today, and unfortunately it isn’t backed up either.

Is there a way to somehow boot into the system successfully?
Nandroid in TWRP then backup internal storage

Please read the instructions carefully and flash the correct variant
 
  • Like
Reactions: TheMystic

TheMystic

Senior Member
Mar 18, 2017
450
178
53
Nandroid in TWRP then backup internal storage

Please read the instructions carefully and flash the correct variant
Thanks. I was thinking since data partition is corrupt, I won't be able to create a Nandroid backup.

But what exactly did your ROM do to cause this error? I have never faced such a problem ever since I got into into custom ROMs, rooting and mods.
 

anupritaisno1

Senior Member
Apr 29, 2014
1,811
1,900
153
Thanks. I was thinking since data partition is corrupt, I won't be able to create a Nandroid backup.

But what exactly did your ROM do to cause this error? I have never faced such a problem ever since I got into into custom ROMs, rooting and mods.
Custom kernels will not work at all with the f2fs variant. This is because this ROM uses an F2FS feature that was added very recently to mainline and custom kernels are really slow at updating these things

Also did you format /cache as F2FS?
 
Status
Not open for further replies.