[APP][ROOT][1.6+] ButtonLED v1.6 (05/05/13)

[GermainZ]

now i don't have the phone so i can't check the logs. but it did nothing. maybe it was a problem with rom, not the app

Alright. Let me know if it happens again.

got it working, love that now i can see notifications without turning on my screen, since the case blocks my LED on my Optimus G

one thing that would be great is a was to block certain apps (music, evernote, play store, etc) instead of having to use key words that might appear in some text messages

That's not possible using Tasker, sorry.
Now that I think of it, tho, it might be possible using some shell commands. Don't hold your breath, it probably won't be reliable enough for me to actually implement it.

 

[Beef Incarnate]

Alright. Let me know if it happens again.


That's not possible using Tasker, sorry.
Now that I think of it, tho, it might be possible using some shell commands. Don't hold your breath, it probably won't be reliable enough for me to actually implement it.

if you could do it, that would be great, and im sure other people would love it as well. but if not, im gonna be turing my screen on every once in a while anyway out of habit

 

[GermainZ]

Nah, not possible.

The only way to do it would be for me to specify commonly excluded apps -you won't be able to change them (unless you have Tasker and use the Tasker project instead of the APK).

If there's enough demand, I'll add a poll, and we'll see.

 

[dgaralon]

Remove the second wait from the shell command (in the backlight task), as well as the goto action. Make a new task that does this:
- wait for %OFF_TIME
- perform task: backlight, if %RUNNING = 1
- call it 'wait'.
In the backlight task, add this at the end:
Perform task, 'wait', stop: yes.

Basically, the backlight task holds a wake lock, but calls the wait task when it's not blinking the LEDs (which doesn't hold a wake lock).
Considering Tasker sets an alarm to resume after the wait action, it shouldn't cause any problems. And it will probably greatly reduce battery usage.

I've been flashing test ROMs for the last few days and have been busy before that, so I didn't have much time to test it.

I have executed some tests using Tasker because I can not generate an app. I export it as a apk but when I try to install it I get an error analyzing package or somethig similar....

I changed the tasks as you said but still I could see a wake lock , associated to the Tasker process, and android never went to deep sleep mode while the led was blinking. Then I unchecked the Keep Awake option in both task (Backlist and Wait). In this case I got some deep sleep time but the seconds that the led is on or off are sometimes higher that the value defined in config variables (ex. 5 on /5 off). Perhaps it is part of the wake up process required after each sleeping period. Also I have checked that with higher values of ON_TIME and OFF_TIME more deep sleep time I get (ex. 10 on / 10 off)

In my phone, using the charging led (very low battery consumption), maybe the best option is to put a very high value for ON_TIME. In this case I could see the notification light most time while android sleep quietly.

I hope this information can help you.

 

[GermainZ]

I have executed some tests using Tasker because I can not generate an app. I export it as a apk but when I try to install it I get an error analyzing package or somethig similar....

I changed the tasks as you said but still I could see a wake lock , associated to the Tasker process, and android never went to deep sleep mode while the led was blinking. Then I unchecked the Keep Awake option in both task (Backlist and Wait). In this case I got some deep sleep time but the seconds that the led is on or off are sometimes higher that the value defined in config variables (ex. 5 on /5 off). Perhaps it is part of the wake up process required after each sleeping period. Also I have checked that with higher values of ON_TIME and OFF_TIME more deep sleep time I get (ex. 10 on / 10 off)

In my phone, using the charging led (very low battery consumption), maybe the best option is to put a very high value for ON_TIME. In this case I could see the notification light most time while android sleep quietly.

I hope this information can help you.

EDIT: (just so no one gets confused: this is about the upcoming version; don't worry about it)

In the modification I described, the wake lock isn't dropped while waiting for ON_TIME anyway, only while waiting for OFF_TIME.
I just flashed a new kernel and I'll try testing some things. Thanks for the help.

EDIT: The extra delay, if I'm not mistaken, should be around 2 seconds. That's because with the changes you made, the proximity sensor is being polled every blink (since the %counter variable is a local variable, it gets reset to 0 when we stop the task and restart it later again). I already changed it, but forgot to mention it earlier.
EDIT2: Removing the wakelock altogether isn't an option on some custom ROMs. It might cause the task to sleep forever.

 

[GermainZ]

Looks like it works... (BBS' Custom Reference was created just before the LEDs started blinking; ButtonLED's settings: 1s on/15s off)

 

[dgaralon]

View attachment 1685208
Looks like it works... (BBS' Custom Reference was created just before the LEDs started blinking; ButtonLED's settings: 1s on/15s off)

It sounds great. I will check it in my phone as soon as you publish it.

With this solution (Keep Awake in ON_TIME) we only could play with higher values of OFF_TIME (>10s) .... As I said it is not the best solution for me due to I prefer to have more time the led on in order to see the notification most of the time. Perhaps the backlist drains more battery that a simple led. In this case your picture of course is the best.
Maybe you can use the lowest value (ON_TIME or OFF_TIME) in the task that have "Keep Awake" to true and the highest in the other task that allows deep sleep. With this logic people could decide.

Thanks you for your effort.

 

[Shyciii]

Auto Locate/File browser isn't working. My device rooted, busybox also installed. When tap Auto Locate/File Browser nothing happens. I turned on log, but the log file is empty.
My device is Samsung Galaxy S Advance (I9070P).

 

[GermainZ]

Auto Locate/File browser isn't working. My device rooted, busybox also installed. When tap Auto Locate/File Browser nothing happens. I turned on log, but the log file is empty.
My device is Samsung Galaxy S Advance (I9070P).

Can you post / PM me a logcat? Note that it might contain some private information (e.g. notifications' titles: SMS contents, WhatsApp contacts, etc), so PM me instead if in doubt.
If the logcat doesn't show anything of use, I'll send you a debuggable APK.

EDIT: Thanks for sending the logcat. I think I've figured out what the problem was. Should be fixed in the next release (working out final details; I'll try uploading it tomorrow).

 

[dgaralon]

Can you post / PM me a logcat? Note that it might contain some private information (e.g. notifications' titles: SMS contents, WhatsApp contacts, etc), so PM me instead if in doubt.
If the logcat doesn't show anything of use, I'll send you a debuggable APK.

EDIT: Thanks for sending the logcat. I think I've figured out what the problem was. Should be fixed in the next release (working out final details; I'll try uploading it tomorrow).

I also detected similar problems with the File Browser & Auto Locate when I executed it. Analyzing the tasks in the Tasker project I could see that the in my case the problem is that my phone has got a busybox installed (pre-root ROM) but I don't have the symlinks for all the commands (ex. grep, sed). So, if you put "busybox sed" it works well but using only "sed" fails because is not in the shell path.
I can not create the symlinks due to the /system file system is read-only and I can not remount it in rw mode.......

Anyway, maybe the best option is to allow to write the brigthness file path directly in a text-box if the other options fails.

Regards.

 

[Silellak]

Thanks for the work you've done on this app so far!

Out of curiosity, would it be possible to add a feature in a future version so that the hard buttons only flash if the phone is charging? This is the most useful use-case for me on my phone (One XL), because the notification light is always in use while the device is charging.

No big deal if it's not possible, just figured I'd ask. Thanks again! :good:

 

[GermainZ]

I also detected similar problems with the File Browser & Auto Locate when I executed it. Analyzing the tasks in the Tasker project I could see that the in my case the problem is that my phone has got a busybox installed (pre-root ROM) but I don't have the symlinks for all the commands (ex. grep, sed). So, if you put "busybox sed" it works well but using only "sed" fails because is not in the shell path.
I can not create the symlinks due to the /system file system is read-only and I can not remount it in rw mode.......

Anyway, maybe the best option is to allow to write the brigthness file path directly in a text-box if the other options fails.

Regards.

I do specify busybox.
I'll add an option to directly write the path as you said (probably not in this next release tho), probably the best thing to do.

Thanks for the work you've done on this app so far!

Out of curiosity, would it be possible to add a feature in a future version so that the hard buttons only flash if the phone is charging? This is the most useful use-case for me on my phone (One XL), because the notification light is always in use while the device is charging.

No big deal if it's not possible, just figured I'd ask. Thanks again! :good:

I'll add it later. Meanwhile, you can set the low battery level to 100% when not charging, and change it to 0% when charging.

 

[GermainZ]

I tried a few ways to drop the wakelock for ON_TIME, but I kinda discovered a Tasker bug (all of them roughly use the same method, so it's the same bug).
I'll try a few other ways later, but didn't want to keep everyone waiting.

Now, with the amount of changes I've made, I'm afraid I might have broken something, which is why I'm not updating the OP yet.
If you guys can test it (MDPI version, <JB; HDPI devices can still install it BTW, it'll just be small and ugly), it'd be great.

Changes:

• Wake locks are released while the LEDs are off and ButtonLED is waiting;
• Sleep timer is fixed. The current value is also displayed when changing the sleep start/end times;
• Tapping on a log entry will give you the option to add that notification to the exclusion list;
• ButtonLED will give you the choice to install Busybox if it's not found;
• File Browser/Auto Locate issues might be fixed for users who were having them (pressing File Browser did nothing at all even if Busybox is installed). Please try it if you were having this issue.

If nothing serious is reported, I'll upload the rest ASAP. Thanks!

 

[afwolfpacked]

Re: [APP][ROOT][1.6-4.x] ButtonLED v1.4 (19/01/12)

Works great on sgh t679 Samsung galaxy exhibit 4g HDMI

As you stated the graphics aren't HDMI and looks funny.

SMS with no subject shows in log ad ntitle and gives entry for each flash.

Option to exclude works by line in log

Start/stop sets but haven't tried when say 10pm till 6am goes past day but see no reason it wouldn't.


Sent from my SGH-T679 using xda premium

 

[travisjustin]

App isn't showing up in accessibility for me to enable. HTC one s running 4.2.1 baked7 ROM.

(Edit) Had it working fine previously under 4.1 using cm10.

 

[GermainZ]

App isn't showing up in accessibility for me to enable. HTC one s running 4.2.1 baked7 ROM.

Which one? The test version?
If it's 1.4 (the current version), did you get the JB/CM10 version?

 

[travisjustin]

Which one? The test version?
If it's 1.4 (the current version), did you get the JB/CM10 version?

Tried both, same problem with both. Currently using test version.

 

[GermainZ]

Tried both, same problem with both. Currently using test version.

Try reinstalling, trying to enable it in Accessibility and PM me a logcat.

 

[travisjustin]

Re: [APP][ROOT][1.6-4.x] ButtonLED v1.4 (19/01/12)

Reinstall worked. Do you still want the logcat?

Sent from my HTC One S using xda app-developers app

 

[chokitodopoder]

Re: [APP][ROOT][1.6-4.x] ButtonLED v1.4 (19/01/12)

I'm going to test here. My only requests are that it keeps blinking as long as there are unread notifications, whether the screen goes on and off, and stop blinking if the notification is removed by the system without my interaction, e.g. it starts blinking when I receive a mail, but before I notice it, i've already deleted it on my pc. So the phone clean the notification, but the buttons keep blinking.

I don't know anything about java or Android, but I've read some things about firmwares and mods. Have you ever thought about seeing how notification leds works on phones that have them and just adapt it to the hw buttons? If possible to just change the address of the hw leds, like we do in ButtonLed choosing the path to ours, it could solve the battery drains and these things I've mentioned before, maybe ofc.

Sent from my GT-P1010 using xda app-developers app