[call for dev] Any dev working on device specific support over GSI image?

MAILUS

Senior Member
Nov 14, 2013
83
9
8
As you all know GSI image alone not sufficient to get fully functional robust stable OS running on Lenovo p2. There are many flashable zip files which need to be flashed individually to get most of the features working. Which makes GSI image meaning less.

So post/discuss all the available GSI and device specific features for Lenovo P2 here.

It will be helpful for Devs and users.

** Requesting Devs to work on device specific feature support over GSI image. **

So far our Dev helped us getting up to this level. We need little more effort to make the GSI image successful on our device.

Expecting Users active support for Devs.

Edited: request only to make device specific features which lacks in GSI image.

Refer post #3.
 
Last edited:

Kielbek

Senior Member
Nov 29, 2012
190
110
63
What do you mean by device specific GSI? What's the point of doing this while GSI (Generic) means (for us) that you can actually flash it over multiple Treble devices out there?
If you recompile system image with device specific patches it will be basically device specific standard ROM (but with Treble which is basically not needed now) and not GSI anymore.
I don't get why are you people actually need "Treble" compatible ROM while existing standard ROMs are working great for now. Because they're Treble ROMs? What does it change? GSIs created using phhusson scripts are one big hack at the moment and their state is experimental. Of course they will work but they're lacking of device specific build.prop's.
Oreo one's are actually fully compatible with Lenovo P2 and stable because I tested them myself. Probably all of them (but all I tested) share the same device specific bugs. Even FP gestures works but this function needs to be activated by "setprop persist.sys.fp.navigation 1" after boot. The fix zip provided in P2 Mods subforum is actually copying script to system which will actually do that after every boot, nothing more. Google told on their AMA that they will make official documentation of making GSIs in the near future so I believe that will fix our current problems and device specific build.props could be generated and added to ROMs without touching system partition integrity state and recompiling them.
Until Android Pie ROMs will be stable as GSIs you will also not benefit too much from creating device specific system image because you will need to wait for Mike or someone else to create compatible vendor image and kernel (Probably Mike will be the first so you will need to wait for official release of LOS16).
Recompiling ROMs just for adding few fixes is a waste of resources. You need approx ~250GB of memory to compile and maitain one ROM, time (depending on memory you are using) and a lot of electricity.
In my personal opinion, creating Magisk module for P2 devices which will fix build.prop systemless-ly and add that command for activating FP gestures will be better alternative for now. I could personally look into it when I get some time.
If you still think that you need these device specific system images for every ROM at all costs, you could build them and maitain yourself or ask someone who will do this. Maybe Fullbustah will be eager to do some requests because he already built some popular ROMs on Mike's sources lately. You could also extract system.img's from his last builded ROM's and they will be device specific system images you are looking for :). The only problem is that I don't think he is willing to maitain all of them at once.
 
  • Like
Reactions: MAILUS

MAILUS

Senior Member
Nov 14, 2013
83
9
8
I'm sorry if my previous post conveyed wrongly.

All we need is GSI images should be flashed directly. I didn't conveyed anywhere to build a sperate image from GSI.

May be I asked to maintain device specific vendor/system tweaks in a one place which will be flashed on top of any GSI image to get all the features working in our device.

Hope this helps!
 

Kielbek

Senior Member
Nov 29, 2012
190
110
63
I'm sorry if my previous post conveyed wrongly.

All we need is GSI images should be flashed directly. I didn't conveyed anywhere to build a sperate image from GSI.

May be I asked to maintain device specific vendor/system tweaks in a one place which will be flashed on top of any GSI image to get all the features working in our device.

Hope this helps!
Ah, okay. It changes a lot. I tested few Oreo GSIs about a month ago an everything was working fine and stable for me. The only tweak needed was FP gesture fix but it was messing with the system partition and I was too lazy to make to improve it so I just gave up using it. And another missing thing was build.prop because device is named "Phh's Treble ARM64" or something like that after installing GSI. Also build fingerprint is always messed up so I had problems passing SafetyNet even with Magisk.
Only these fixes are required for making Oreo GSI's working perfectly or almost perfectly (like official LOS) so I'm going to do Magisk module that will cumulate all of these fixes into one, easy to install solution. If I missed something just let me know.
 
  • Like
Reactions: iniro and MAILUS
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone