[CLOSED][BETA][2018.7.19] Magisk v16.7 (1671)

[georgekav33]

I have absolutely no clue... I'm gonna link this to some people that actually know what they're talking about. Let's hope they have some idea...

I think I am starting to have a clue. The device is a true A/B device, and as such, we have skip_initramfs argument which basically ignores the Ramdisk of the boot.img. So basically what we did with the patch of the boot.img by the app is to patch the recovery (the ramdisk belongs to recovery now).

 

[Wesley_NL]

I have absolutely no clue... I'm gonna link this to some people that actually know what they're talking about. Let's hope they have some idea...



That has absolutely nothing to do with Magisk beta discussion... Please keep Pokemon queries in the dedicated Pokemon Go thread: https://forum.xda-developers.com/apps/magisk/discussion-pokemon-magisk-discussion-t3465722

Yes ok but what about safetynet itself ? That belongs here right ?

 

[Didgeridoohan]

I think I am starting to have a clue. The device is a true A/B device, and as such, we have skip_initramfs argument which basically ignores the Ramdisk of the boot.img. So basically what we did with the patch of the boot.img by the app is to patch the recovery (the ramdisk belongs to recovery now).

Is that any different from the Pixel family? Because they can install Magisk just fine.

Yes ok but what about safetynet itself ? That belongs here right ?

From the OP, regarding SafetyNet:

Please do NOT SPAM the forum with these kind of issues! It is NOT a priority to fix

So... No. Keep it in the Pokemon thread or the general support thread.

 

[otyg]

/dev/block/boot detection is broken in latest magisk manager (trying to upgrade to Magisk 16.7).

would it be possible to manually specify the location in the next Magisk Manager update?

 

[georgekav33]

Is that any different from the Pixel family? Because they can install Magisk just fine.

Indeed it should be close because also the MX8 has the latest features/recommendations of Google. BUT, I think it is different when we flash via zip. The binary of Magisk has access to all partitions, and thus by detecting the skik_initramfs, it mounts and modifies the system. When we give the boot.img to the App, it is possible that the script does not do the sanity checks of skip_initramfs, as it does with the recovery mode ; and even if it did, it has zero ability to modify the /system and the true ramdisk in there.

Next test to do is to do an old school root and then use the direct mode of the app. If the Pixel/Pixel 2 is not hard-code as device strings that will use the new skip_initramfs procedure then it should work.

 

[H0wdy]

@Snowpuppy @spleenandcigars

Your problems are likely caused by sepolicy timing issues at boot. This has been fixed and will be in the next release.

That's why Verizon Pixel XL gets stuck on reboot/G logo after installing magisk?

 

[Homeboy76]

That's why Verizon Pixel XL gets stuck on reboot/G logo after installing magisk?

Not a question.
Maybe, you should try an Unofficial Magisk Build, you've tried just about everything else.
Go to Magisk General Support / Discussion by topjohnwu and read @martyfender post.

 

[SacredDeviL666]

Thread Cleaned.

Removed Safetynet posts
Posts without logs
Posts about playstore certifications
Discussion related to other apps
Responses given to all the above & any other non-beta related post. (use the Magisk General Thread :- https://forum.xda-developers.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382
DO NOT POST LINKS for unofficial builds in an Official Beta Thread.

If i have removed any of your posts in error PM me so i can take a look and action accordingly.

Read OP before you start posting in this thread specially :- https://forum.xda-developers.com/showpost.php?p=72588015&postcount=1

Thanks
SacredDeviL666
Forum Moderator.

 

[Homeboy76]

Thread Cleaned.

Removed Safetynet posts
Posts without logs
Posts about playstore certifications
Discussion related to other apps
Responses given to all the above & any other non-beta related post. (use the Magisk General Thread :- https://forum.xda-developers.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382
DO NOT POST LINKS for unofficial builds in an Official Beta Thread.

If i have removed any of your posts in error PM me so i can take a look and action accordingly.

Read OP before you start posting in this thread specially :- https://forum.xda-developers.com/showpost.php?p=72588015&postcount=1

Thanks
SacredDeviL666
Forum Moderator.

Didn't know it was official , thought it was BETA.
The link was to Magisk General Support / Discussion by topjohnwu.

 

[H0wdy]

Not a question.
Maybe, you should try an Unofficial Magisk Build, you've tried just about everything else.
Go to Magisk General Support / Discussion by topjohnwu and read @martyfender post.

Any ideas as to which one?

 

[Homeboy76]

Any ideas as to which one?

PM me don't want to go OT.

 

[Ubimo]

What does this mean in changelog?

• Add hexpatch to remove Samsung defex in kernel

 

[Pretoriano80]

@topjohnwu
@Didgeridoohan
New issue on Huawei Phones - Mate 10, Mate 10 Pro, P9 - Huawei roll out a new OTA called: "patch01". In the changelog is some fix mentioned (example: mms...) but the main patch is to disable the possibility of Root.

That means: if someone flash Magisk with TWRP, or flash patched_boot.img to ramdisk and reboot the phone, Phone get stuck on the splash screen: "Your device cannot be trusted..."
Only flashing back the original Huawei ramdisk.img helps to boot again to system. But no Root with Magisk is anymore possible.
Downgrade helps (if available, because for some Phones like Mate 10 it is dangerous to downgrade, if the Downgrade Firmware has another Xloader.img... but this is another story)

→ So, for Users of Huawei Phones it is better not to install OTA with Patch01 and disable Systemupdate in /system/app/HwOUC - rename HwOUC.apk to HwOUC.bak

I attach here the patch from Huawei for P9 - may you take a look, thanks

Hmm, while it's true that latest Huawei behavior goes against modding, we shouldn't expect that Magisk will always work. OEMs will always do their best to avoid rooting (for them it will always be a security isdue) and sometimes might happen that Magisk will be affected by a patch that it's not even direct attack to it. It was like that with other Root solutions even before Magisk.
Now back to this patch 01 issue, any of you tried to debug it while it gets stuck on booting? Did you guys tried to backup patch01's ramdisk and check it against previous stock ramdisk.
What about rolling back the previous kernel.img instead of rolling back to the stock ramdisk?

What i'm trying to say (while i'm not defending Huawei at all) is that so far we are just speculating, without proper logs or anything that could help us understand what changed and how could be fixed.

P.S. If i would be at Huawei HQ and my intentions would be all against rooting, then i would force a bootloader lock with an update. Adios rooting! ? (i really hope they won't go this far)

 

[Tecalote]

Hmm, while it's true that latest Huawei behavior goes against modding, we shouldn't expect that Magisk will always work. OEMs will always do their best to avoid rooting (for them it will always be a security isdue) and sometimes might happen that Magisk will be affected by a patch that it's not even direct attack to it. It was like that with other Root solutions even before Magisk.
Now back to this patch 01 issue, any of you tried to debug it while it gets stuck on booting? Did you guys tried to backup patch01's ramdisk and check it against previous stock ramdisk.
What about rolling back the previous kernel.img instead of rolling back to the stock ramdisk?

What i'm trying to say (while i'm not defending Huawei at all) is that so far we are just speculating, without proper logs or anything that could help us understand what changed and how could be fixed.

P.S. If i would be at Huawei HQ and my intentions would be all against rooting, then i would force a bootloader lock with an update. Adios rooting! ? (i really hope they won't go this far)

Hi Mate,

We are currently trying to find out if it was an unintended side effect.
For this we will roll up the whole situation with the patch again on two phones and try everything what's possible to sort it out.
I think we will know it at the end of this week.
I will report the results with Logs.

There are also two new Firmwares, which aren't officially released, but available.
We will test them too and see if Root is still possible or not..

 

[PrettyPistol555]

It is actually extremely simply... use the deuce-flash-all-v4.5 script for Pixel devices... best way to get both a/b on the same version. https://forum.xda-developers.com/pi...ol-deuces-bootloop-recovery-flashing-t3704761

I didn't see that this supports the OG Pixel XL (Marlin)
It specifically says "This script is for the UNLOCKED BOOTLOADER pixel2 / pixel2 XL"
If it does support original Pixel devices it might come in very handy....

 

[yochananmarqos]

I didn't see that this supports the OG Pixel XL (Marlin)
It specifically says "This script is for the UNLOCKED BOOTLOADER pixel2 / pixel2 XL"
If it does support original Pixel devices it might come in very handy....

It does not, but it's very easy to modify.

This is way off topic, FYI.

Sent from my Pixel using XDA Labs

 

[demonoidmaster]

as said already; not enough info.
In general you have the options to restore the system from a previous backup. Or a factory reset and clean flash of your rom.

he can just hold down vol - on boot to start up in safe mode

Or he could just delete his magisk img from data/adb and reflash the modules that work all over again or.. Do what guest4711 said about manually creating a file telling magisk to be disabled on boot

What you said about previous back or factory reset and clean flash is dumb, fixing an issue with a magisk module is simple, there's no need for such drastic measures

 

[IzaacJ]

Samsung Galaxy S7 Edge (Exynos) with Stock Oreo and Magisk 16.7 regularly looses root and says Magisk ain't installed.
Don't find the logs atm (no logs available in MM and on the go) but will attach them later tonight.
However, this happens without any modules installed, usually my only module is V4A but tried now for a week with no modules and still regularly says Magisk isn't installed until a reboot, and then it works for a few hours or so.
Any ideas?

 

[Didgeridoohan]

Samsung Galaxy S7 Edge (Exynos) with Stock Oreo and Magisk 16.7 regularly looses root and says Magisk ain't installed.
Don't find the logs atm (no logs available in MM and on the go) but will attach them later tonight.
However, this happens without any modules installed, usually my only module is V4A but tried now for a week with no modules and still regularly says Magisk isn't installed until a reboot, and then it works for a few hours or so.
Any ideas?

That means that both magiskd and magisklogd are killed off somehow. Otherwise one would respawn the other. If you can pull the Magisk log from /cache after it happens it might show something, but a logcat as it happens would likely be the best...

 

[IzaacJ]

That means that both magiskd and magisklogd are killed off somehow. Otherwise one would respawn the other. If you can pull the Magisk log from /cache after it happens it might show something, but a logcat as it happens would likely be the best...

When this started to happen I tried to see anything in the log inside MM, but since I had to restart to get Magisk to work (and to access the log in MM) it was cleared and only showed since reboot.

Can't access /cache when the root+Magisk ain't working, and after reboot the Magisk log seems to be cleared. The backed up one is only showing init messages and hide_list and proc_monitor messages.

Is there some way to get access to /cache w/o reboot or is it automatically backed up at reboot? If so, there doesn't seem to be any errors.