I must be confusing it with something else then. Sorry for my misinformation.There's no such feature in Magisk... Not yet at least, if ever.
You might be thinking of Magisk in recovery on devices with no ramdisk.
I must be confusing it with something else then. Sorry for my misinformation.There's no such feature in Magisk... Not yet at least, if ever.
You might be thinking of Magisk in recovery on devices with no ramdisk.
Hi,@mohsyn
The exception would be if the device uses full disk encryption as opposed to file based, but I don't know if there's any A/B devices doing that.
He's aware@topjohnwu not a real problem but maybe you want to take a look and implement some solution that keeps Magisk hidden more effectively
https://github.com/KimChangYoun/roo...LibRootbeerFresh/src/main/jni/toolChecker.cpp
Hey guys,
don't know if already mentioned but when I'm charging my OnePlus 7 Pro powered off, so I stick in the boot warning splash screen.
Is there a fix?
That is normal issue for OxygenOS. My OPO with TugaPower P18 don't have this issue, but my OP6 with OxygenOS OB19 have this issue.
So alternative is, enter recovery mode. Charge on that mode (it can turn off screen).
You can search on OxygenOS thread at XDA, they already talking about this issue. This is not Magisk issue, but OxygenOS itself.
Sent from my ONEPLUS A6000 using XDA Labs
this is really an annoying problem. The phone freezes and you have to restart by pressing the volume and power off keys simultaneously. Do all Oxygen users have this problem?
EDIT
without Magisk it works ! the battery symbol appears and the OnePlus 7 Pro charges normally
Me too.......
Uninstalling and reinstalling only fixes it until you install another module
Needs fixing ASAP as if you have an app that needs root and it doesnt display root prompt in a timely manner, or you miss it and the time window to press on prompt to allow, guess what, you have to uninstall magisk again
This is a major bug.......how did this get past the testing stage, oops, are we now the only testers?
From the op:
So the dev will ignore this and without more information, nobody else can help you either....
SafetyNet / CTS / XXX app won't work after enabling MagiskHide:
Ignored
Deleting data/adb/Magisk.db fixed it for me. You will need to re-authorize the su permissions of your apps.
If you're not happy with the software freely made available to you you have tree option to not use it.Me too.......
Uninstalling and reinstalling only fixes it until you install another module
Needs fixing ASAP as if you have an app that needs root and it doesnt display root prompt in a timely manner, or you miss it and the time window to press on prompt to allow, guess what, you have to uninstall magisk again
This is a major bug.......how did this get past the testing stage, oops, are we now the only testers?
... and to reselect the apps you do not like Magisk/root be visible for (aka rebuild your hiding list).Deleting data/adb/Magisk.db fixed it for me. You will need to re-authorize the su permissions of your apps.
Twrp has been the offline charging issue on the marlin and cross hatch, I can confirm that. Patching boot image versus flashing Twrp, offline charging doesn't work when flashing magisk via Twrp. But if you patch the boot image and fastboot flash it, it works great. Been on this issue way that issues was put on github and have been saying this for months. My posts get deleted from Twrp forum and or root guide that says to use Twrp. I have proven this for months. Magisk doesn't touch the system image, so offline charging should work while off. Twrp is what messing with offline. Magsik can not because offline and powered down magisk isn't even running. Twrp overlaps the recovery and boot. So the background of the phone is actually messing up deciding whether to boot into os or offline charging. Magisk isn't even doing anything offline. It doesn't cover your recovery and change how to boot into recovery, which is part of offline charging. I rarely look in the github issues because many many issues are not even issues at. This one is not device specific more of what you used to flash Magisk. So not a magisk problem. Twrp is second choice in rooting your phone. Patch your boot yourself.
Go into settings in the Manager. Under 'Update Settings' what's 'Update Channel' set to?Iam always using stable builds of magisk, but today something happened and i wanted to ask here. I was installing roms, and restoring data on my a5 2017. I was doing it a few times because i wanted to to try something with modifying OMC files, and few times
i had to install magisk after that, allways the latest stable build. You know usual rooting phone stuff. I had some spare time to play with the phone Anyway, one of those times after rooting again and restoring data gain, magisk update was showing so i updated it. The update was Manager 7.3 and after that
Magisk-v19.4-c1602d25(19301).zip. Its 10.63 MB. Everything is working normally, so I wanted to see the changelog, but then i saw it wasnt stable or beta build. This is my first time eveng opening this thread. So my question is how did it update to this canary build?
@mohsyn
Along with this /data/adb/modules should also be unencrypted. Just make sure when you boot up into TWRP when the password/pattern screen comes up you hit cancel. That should give you access to the areas you need.
The exception would be if the device uses full disk encryption as opposed to file based, but I don't know if there's any A/B devices doing that.
Twrp has been the offline charging issue on the marlin and cross hatch, I can confirm that. Patching boot image versus flashing Twrp, offline charging doesn't work when flashing magisk via Twrp. But if you patch the boot image and fastboot flash it, it works great. Been on this issue way that issues was put on github and have been saying this for months. My posts get deleted from Twrp forum and or root guide that says to use Twrp. I have proven this for months. Magisk doesn't touch the system image, so offline charging should work while off. Twrp is what messing with offline. Magsik can not because offline and powered down magisk isn't even running. Twrp overlaps the recovery and boot. So the background of the phone is actually messing up deciding whether to boot into os or offline charging. Magisk isn't even doing anything offline. It doesn't cover your recovery and change how to boot into recovery, which is part of offline charging. I rarely look in the github issues because many many issues are not even issues at. This one is not device specific more of what you used to flash Magisk. So not a magisk problem. Twrp is second choice in rooting your phone. Patch your boot yourself.
A Yes that is exactly what I do now. No problems with offline charging. I had the same issues. Show a fail safe icon instead of the actual charge output. Then would take a long power hold which is resetting everything to boot again. Now that I fastboot flash the boot with no twrp, works great. Twrp is great on some devices, but for some reason lately has had an issue with pie. Twrp is great to just boot to, never install it or use it to root anymore. Only save me if I got a module messing up boot I just installed. No more flashing with twrp for me. I use exkm for kernel and everything else is modules from magisk. No more offline charging issues.On those devices, recovery is in the boot.img ramdisk, I believe and not a separate partition. Have you ever tried, as @topjohnwu recommends and just temp booted twrp with fastboot to flash magisk, instead of installing twrp to the boot partition?
Go into settings in the Manager. Under 'Update Settings' what's 'Update Channel' set to?
I'm on the stable channel. With magisk manager 7.3.0 the list under download g contains only 4 modules.
Someone else?