[CLOSED] [PORT] [v1.2] OxygenOS 3.2.0 Camera for OP3

[matssa]

And this is exactly why I posted these photos. Not so others can say how good they look,
but to show that features ("HDR" and "HQ") do not work. I did not see one single user report this before,
on the other hand there are already multiple posts about manual focus fc and so on which the dev already knows about and mentions in the OP.
Don't get me wrong, I'm not trying to sound mean. I just want to let the dev know because nobody did before.

People who read the first post will think:
"great as long as HDR and HQ work on CM13, I don't care about manual focus fc..."
Some are only holding back to flash cm13 or other roms because of the camera quality
due to these special features.

No worries, didn't want to sound mean either But yeah I didn't even try out other features cause I always touch my screen to focus somewhere isntead of waiting for the app to focus by itself.
What I suggest is you upload a log of the three different photos so that the dev can see the issue maybe, unless you already did it

 

[abhi08638]

Post processing is not handled by the camera app, if you want OOS quality photos, you need to use OOS camera HAL. CM uses its own HAL so naturally the pictures are going to look the same with any camera app

 

[AcmE85]

@abhi08638 Thanks for the info. So this means we will have to wait for custom roms which utilize the OOS camera hal.

 

[ghbuur]

i think it's hal related too, but I'll check. on oneplus 2 there's a big difference on my port compared to cm 13 stock camera and everything works...

 

[matssa]

Post processing is not handled by the camera app, if you want OOS quality photos, you need to use OOS camera HAL. CM uses its own HAL so naturally the pictures are going to look the same with any camera app

Yup thought so too, I hope they will be using the OP3 camera hal since it was fully released, you never have this type of info, or at least that amount, but can't really say if they really want to put extra effort in this...

 

[ghbuur]

so i made a new test zip with hal from op3 oxygen os but be careful as it could end in bootloop:

- make a nandroid backup or be ready to dirty flash rom again!

- if this solution works, it might break stock cam

- let me know if it works or if i should delete this link again

https://www.dropbox.com/s/qfomwur4tgrogis/test with hal.zip?dl=0

 

[Maddinuser]

Stock camera works(beanstalk).
Oos camera FC on focus and switching to frontcam with your newest ZIP. No hdr

 

[AcmE85]

Stock camera works(beanstalk).
Oos camera FC on focus and switching to frontcam with your newest ZIP. No hdr

Did you try HQ mode?
The previous ports did not include the OOS Camera HAL, which caused HQ to have no effect.
It would be great if you could compare auto-mode without HDR and HQ.

Thank you!

 

[nickporwal]

And this is exactly why I posted these photos. Not so others can say how good they look,
but to show that features ("HDR" and "HQ") do not work. I did not see one single user report this before,
on the other hand there are already multiple posts about manual focus fc and so on which the dev already knows about and mentions in the OP.
Don't get me wrong, I'm not trying to sound mean. I just want to let the dev know because nobody did before.

People who read the first post will think:
"great as long as HDR and HQ work on CM13, I don't care about manual focus fc..."
Some are only holding back to flash cm13 or other roms because of the camera quality
due to these special features.

Exactly, because of this i am not flashing cm. Photo quality in oos is much better. Noise is more prominent in cm.
OP is doing great work. I hope he will make it work in CM.

Sent from my ONEPLUS A3003 using Tapatalk

 

[Maddinuser]

Did you try HQ mode?
The previous ports did not include the OOS Camera HAL, which caused HQ to have no effect.
It would be great if you could compare auto-mode without HDR and HQ.

Thank you!

Seems to work,not sure though if i See a difference

 

[AcmE85]

Seems to work,not sure though if i See a difference

Could you post the pics or send me a PM?

 

[Maddinuser]

Now i See a difference!darker image is with HQ on!

 

[Spliffman1]

@ghbuur ok I tested the latest zip on RR official , I can take pics in auto, turn off flash, turn on flash, or put flash on auto, Point and shoot works. AND less noise than CM camera, definitely better. BUT, if I swipe to go to video FC, try to switch to front camera FC, menu will pull out from left but if i touch any option FC. manual focus FC. Seems that anything that involves touching the screen menus produces FC. Top options seem ok, that is flash, HQ, and HDR. Also I can get to Settings okay via gear wheel top right (shutter sound, location, about, save raw..) I know you'll work it out. I loved the port on my OP2. btw the zip i tested the latest test with hal.zip

 

[Signor Rossi]

so i made a new test zip with hal from op3 oxygen os but be careful as it could end in bootloop:

- make a nandroid backup or be ready to dirty flash rom again!

- if this solution works, it might break stock cam

- let me know if it works or if i should delete this link again

https://www.dropbox.com/s/qfomwur4tgrogis/test with hal.zip?dl=0

I will give it a try later tomorrow. Thanks for the effort

Gesendet von meinem OnePlus 3

 

[AcmE85]

@Maddinuser
Thanks for sharing but these photos are not really good for a real comparison,
mostly because the forum adds to much compression and they are not in full resolution.
Best would be clear shots outside uploade to dropbox or other hosters which do not
compress the images.

 

[aosimon]

Installed the latest version with HAL and I can take HQ pics now on the main camera with good quality. Anything touch-wise still causes FC.

One question: does the CM HAL get replaced by the OOS HAL? So if I use another camera app it'll technically use OOS HAL to produce better pictures?

 

[nickporwal]

Installed the latest version with HAL and I can take HQ pics now on the main camera with good quality. Anything touch-wise still causes FC.

One question: does the CM HAL get replaced by the OOS HAL? So if I use another camera app it'll technically use OOS HAL to produce better pictures?

Please check noise in the low light photos.

Sent from my ONEPLUS A3003 using Tapatalk

 

[Maddinuser]

@Maddinuser
Thanks for sharing but these photos are not really good for a real comparison,
mostly because the forum adds to much compression and they are not in full resolution.
Best would be clear shots outside uploade to dropbox or other hosters which do not
compress the images.

PM

 

[ghbuur]

Installed the latest version with HAL and I can take HQ pics now on the main camera with good quality. Anything touch-wise still causes FC.

One question: does the CM HAL get replaced by the OOS HAL? So if I use another camera app it'll technically use OOS HAL to produce better pictures?

yep cm hal gets replaced, that's why i mentioned it could cause issues..

 

[Spliffman1]

yep cm hal gets replaced, that's why i mentioned it could cause issues..

CM camera still running fine after flash of OOS hal