[Dev Help] Is it possible to run an "uninstall script" when removing a module?

[Ssayerr]

[Dev Help] Is it possible to run an "uninstall script" when removing a module?

Hey all. I'm working on a module, and I'm planning on using the late-start service to make some changes to the system to detach the app I'm including in the module from the Play Store to prevent accidental updates or a persistent update nag. This part is working fine. The part I'm having troubles with is the uninstall portion. When removing the module, the changes persist since they weren't systemless. So, my question is this: is it possible to have Magisk run an "uninstall script" when it has been marked for deletion? I've done some digging through the documentation and haven't found anything indicating this is possible, but I'm hoping it's either an undocumented feature or somebody will know a way to achieve the same effect.

 

[Didgeridoohan]

You could let the module also install a boot script in post-fs-data.d or service.d (service.d is preferred, but if that doesn't work try post-fs-data.d). Let that script look for the module folder in /magisk. If it isn't found, let the script revert the changes and then delete itself.

 

[Ssayerr]

You could let the module also install a boot script in post-fs-data.d or service.d (service.d is preferred, but if that doesn't work try post.fs.data.d). Let that script look for the module folder in /magisk. If it isn't found, let the script revert the changes and then delete itself.

You mean in Magisk's core? Yeah, that's a good idea, and probably easily implemented.

 

[Didgeridoohan]

You mean in Magisk's core? Yeah, that's a good idea, and probably easily implemented.

Yes, in /magisk/.core. It's quite simple, but it works... :good:

 

[Ssayerr]

Yes, in /magisk/.core. It's quite simple, but it works... :good:

Cool, I'll give it a shot. Any tricks to getting stuff to run in the core, or do I just drop it in?

 

[Didgeridoohan]

Cool, I'll give it a shot. Any tricks to getting stuff to run in the core, or do I just drop it in?

Don't forget to set the correct permissions on the script or it won't execute... Other than that it's just to drop it in service.d or post-fs-data.d, whichever one fits your needs.

 

[Ssayerr]

Don't forget to set the correct permissions on the script or it won't execute... Other than that it's just to drop it in service.d or post-fs-data.d, whichever one fits your needs.

Great, I'll see what I can do with it. Many thanks for the advice!

 

[Deic]

You could check the file called "remove" in the module folder.

 

[Ssayerr]

You could check the file called "remove" in the module folder.

Unless the "remove" file itself can be set up to run a script, that wouldn't work. If that file is present, the module as a whole would be gone before my script would run. I'm currently planning on just having a script check for the existence of the module itself, once I have time to mess with it some more.

 

[Deic]

Unless the "remove" file itself can be set up to run a script, that wouldn't work. If that file is present, the module as a whole would be gone before my script would run. I'm currently planning on just having a script check for the existence of the module itself, once I have time to mess with it some more.

Must keep in background a loop to check the existence of that file obviously. So in your module script for example:

background function() {
    while :; do
        [ -f /magisk/$MODDIR/remove ] && {
            #here the stuff you want to do
            break
        }
        sleep 1
    done
}

background &

 

[ahrion]

Hey all. I'm working on a module, and I'm planning on using the late-start service to make some changes to the system to detach the app I'm including in the module from the Play Store to prevent accidental updates or a persistent update nag. This part is working fine. The part I'm having troubles with is the uninstall portion. When removing the module, the changes persist since they weren't systemless. So, my question is this: is it possible to have Magisk run an "uninstall script" when it has been marked for deletion? I've done some digging through the documentation and haven't found anything indicating this is possible, but I'm hoping it's either an undocumented feature or somebody will know a way to achieve the same effect.

You could let the module also install a boot script in post-fs-data.d or service.d (service.d is preferred, but if that doesn't work try post-fs-data.d). Let that script look for the module folder in /magisk. If it isn't found, let the script revert the changes and then delete itself.

My Unity (Un)Installer has this includes.

Essentially you can run a .core service.d script to delete any left over files such as scripts if the conditional says that the specified mod folder does not exist, and then have the script delete itself once done.


https://github.com/therealahrion/Audio-Modification-Library
This isn't just for AML or audio projects, as it uses the Unity Installer.

 

[ahrion]

Must keep in background a loop to check the existence of that file obviously. So in your module script for example:

It doesn't have to be that complicated.

 

[Deic]

It doesn't have to be that complicated.

Sure, the Unity stuff (Copyrigth © 1337 Canonical Ltd.) is lesser complicated than a few basic command lines in the module script.

Sarcasm intended.

 

[ahrion]

Sure, the Unity stuff (Copyrigth © 1337 Canonical Ltd.) is lesser complicated than a few basic command lines in the module script.

Sarcasm intended.

That was not my intention. Lol I knew that was gonna happen. Unity has a lot of features that allows people to make quick edits without having to touch the update-binary.

I was using the /common/moddid-service.sh as an example.

Here's a more refined example minus Unity mumbo jumbo:
if [ ! -d /magisk/$MODID ]; then
rm -f /magisk/.core/service.d/$MODID.sh
fi

 

[Didgeridoohan]

My Unity (Un)Installer has this includes.

Essentially you can run a .core service.d script to delete any left over files such as scripts if the conditional says that the specified mod folder does not exist, and then have the script delete itself once done.


https://github.com/therealahrion/Audio-Modification-Library
This isn't just for AML or audio projects, as it uses the Unity Installer.

I do the same on a couple of my own modules. Post-fs-data.d or service.d scripts that doesn't run if the disable file is present in the module folder and cleans up and deletes itself if the folder isn't found, etc. It's really handy...