(DEV-ONLY) discussion about implementing fingerprint when compiling from source code

[twinnfamous]

This thread is so more information about our fingerprint issue when building from source code can reach more devs and enable them to start off without having to research any and all the information that we already have.
The main goal is to share what each one of us knows so far and discuss what may work and won't work.
Share our ideas and thoughts on the subject.

First question is
how many of you still have these files in these locations after flashing source built rom?
system/vendor/lib64/hw/goodix.fingerprint.sdm845.so
system/vendor/lib/hw/goodix.fingerprint.sdm845.so
system/vendor/lib64/hw/goodix.fod.sdm845.so
system/vendor/lib/hw/goodix.fod.sdm845.so
system/vendor/lib/libgoodixfingerprintd_binder.so
system/vendor/lib64/libgoodixfingerprintd_binder.so
system/vendor/lib/[email protected]
system/vendor/lib64/[email protected]

lets start here.

 

[twinnfamous]

Reserved

 

[twinnfamous]

This one too

 

[twinnfamous]

Maybe one more

 

[Zachisimo]

I'm running the latest havoc, and these are the only fingerprint files I have

 

[me2151]

To understand the problem you have to understand how it works in the first place. The fingerprint sensor is actually working, so its not a blob issue. The issue(from what I am seeing at least) is that stock aosp source cannot differentiate between the fingerprint sensor touch vs the regular display touch. After digging through oneplus systemui you will notice that there is quite a few proprietary things in there pertaining to the touch system for fingerprint. All of which is missing from aosp source.

We currently have 2 options for getting FP working. Either OP releases the fingerprint source or someone reverse engineers the code from oneplus(like what was done with the slider).

EDIT: Since it will be asked anyway how i know its not a blob issue... If the fingerprint sensor was not working correctly Roms would not even have the fingerprint option available or it would crash on load.

 

[twinnfamous]

To understand the problem you have to understand how it works in the first place. The fingerprint sensor is actually working, so its not a blob issue. The issue(from what I am seeing at least) is that stock aosp source cannot differentiate between the fingerprint sensor touch vs the regular display touch. After digging through oneplus systemui you will notice that there is quite a few proprietary things in there pertaining to the touch system for fingerprint. All of which is missing from aosp source.

We currently have 2 options for getting FP working. Either OP releases the fingerprint source or someone reverse engineers the code from oneplus(like what was done with the slider).

EDIT: Since it will be asked anyway how i know its not a blob issue... If the fingerprint sensor was not working correctly Roms would not even have the fingerprint option available or it would crash on load.

Thanks for the input.
I believe we have a long road ahead but we have to start somewhere.

 

[shinji257]

To understand the problem you have to understand how it works in the first place. The fingerprint sensor is actually working, so its not a blob issue. The issue(from what I am seeing at least) is that stock aosp source cannot differentiate between the fingerprint sensor touch vs the regular display touch. After digging through oneplus systemui you will notice that there is quite a few proprietary things in there pertaining to the touch system for fingerprint. All of which is missing from aosp source.

We currently have 2 options for getting FP working. Either OP releases the fingerprint source or someone reverse engineers the code from oneplus(like what was done with the slider).

EDIT: Since it will be asked anyway how i know its not a blob issue... If the fingerprint sensor was not working correctly Roms would not even have the fingerprint option available or it would crash on load.

I'm in agreement on this. My LG G5 has a fingerprint sensor and when the battery was getting bloated it was actually lifting the power/fingerprint button off the connector. When it got bad enough the phone just stopped showing the option for the sensor because it no longer detected the presence so even if the files are there Android is smart enough to hide the option if it doesn't see a working sensor.

 

[me2151]

Yep. A lot of times when device bringup is being done if you haven't done fingerprint yet android will just not show the fingerprint options(in setup or in settings). Usually won't until it sees the fingerprint hardware actually working and connected.

 

[twinnfamous]

Yep. A lot of times when device bringup is being done if you haven't done fingerprint yet android will just not show the fingerprint options(in setup or in settings). Usually won't until it sees the fingerprint hardware actually working and connected.

Since you said something about the system Ui I decompiled it.
It looks like everything is in there even the green light.

 

[me2151]

Since you said something about the system Ui I decompiled it.
It looks like everything is in there even the green light.

Yep. Even the code for the face unlock is in there.

 

[twinnfamous]

Yep. Even the code for the face unlock is in there.

So in a sense all it takes is someone capable enough to take the decompiled files and modify the system ui apk source code in the rom they are building?
I have the files if anybody needs them there on afh

 

[twinnfamous]

Yep. Even the code for the face unlock is in there.

So in a sense all it takes is someone capable enough to take the decompiled files and modify the system ui apk source code in the rom they are building?
I have the files if anybody needs them there on afh

 

[me2151]

So in a sense all it takes is someone capable enough to take the decompiled files and modify the system ui apk source code in the rom they are building?
I have the files if anybody needs them there on afh

Yes and no. The main problem is the fact that the code is proprietary. If you release it as is or share it as is you could face legal action from one plus. It has to be completely rewritten. Hence the reverse engineering part. But the yes to it is it just needs someone capable.

 

[cultofluna]

few Devs have the code already ..
But unfortunately can't post a rom with fingerprint fix , cause is proprietary or get DMCA'd
So they're working on a fix that's open source to share it...

 

[Electric1447]

few Devs have the code already ..
But unfortunately can't post a rom with fingerprint fix , cause is proprietary or get DMCA'd
So they're working on a fix that's open source to share it...

Did any dev even got the fingerprint to work?

 

[cultofluna]

Did any dev even got the fingerprint to work?

Not yet

 

[twinnfamous]

few Devs have the code already ..
But unfortunately can't post a rom with fingerprint fix , cause is proprietary or get DMCA'd
So they're working on a fix that's open source to share it...

Systemui in source built roms have fingerprint files in them. May be easier if someone running a open-source rom pulls the apk and decompiles it then edit and put back in device to test? Just a thought but I've been going through everything the only thing I seen so far we need to add is the fingerprint location values and add files to show on screen.
We shouldn't have to rewrite completely as most files are all ready open source and in systemui of aosp source code.
I've been caught up in building a source code rom and trying things but there are far more people that have more experience than I do at the .apk part.
Hope any of this helps.

 

[Electric1447]

Systemui in source built roms have fingerprint files in them. May be easier if someone running a open-source rom pulls the apk and decompiles it then edit and put back in device to test? Just a thought but I've been going through everything the only thing I seen so far we need to add is the fingerprint location values and add files to show on screen.
We shouldn't have to rewrite completely as most files are all ready open source and in systemui of aosp source code.
I've been caught up in building a source code rom and trying things but there are far more people that have more experience than I do at the .apk part.
Hope any of this helps.

This what I thought someone should do. Even if someone uses copyrighted code he could still test and see if it works.

 

[seijinshu]

I want to continue research on this topic. I'll take a look at systemui and framework-res and try to just test if I can get OP code working on AOSP. Then I'll go from there.

Edit: From a quick glance, FP code seems to be also present in framework-res, so that likely will also need to be worked on.