[DEV][Work-In-Progress][C#] Direct Smali to Java converter

[Ricky Divjakovski]

Hey man!

I've been working on merging your new changes and analyzing them. Thanks a lot! you sure did a lot of work there that was really needed, specially with types and arrays. Nice!. I'll see what can I come up with next .

I tried to use VS2012's IDE but man it was hell, they don't have too much documentation, and WPF is kind of a new tech for me so I didn't want to spend much time on that, but hey it's good to know. I see, well, if you ever manage to improve your IDE somehow with some kind of Amend<->Edify converter and Amend syntax highlighting it would be great, as I'm kinda needing a recovery script IDE sometimes xD

I just tipped off XDA portal, hopefully they post it and it attracts more contributors!

 

[darkguy2008]

Hi darkguy2008 !

I'm really interested in your project and wanted to know : do you think we should add an UI to it ? I'm actually working on that (for personnal use )
If you are interested in what I'm doing reply me

Btw really nice project :cyclops:

Hello cadialex!

Well, when I created the project I didn't think it would need an IDE, as what I'm attempting to do is what smali does with jar/apk files, just plain converting them and outputting a whole converted folder. But hey, I wouldn't mind to check what are you working on, who knows, I could like it xD.

Thanks for the support!

 

[darkguy2008]

I just tipped off XDA portal, hopefully they post it and it attracts more contributors!

Awesome! I'll be sure to check regularly for the review they'll surely do good luck too!

 

[Fenny]

Hey man!

I've been working on merging your new changes and analyzing them. Thanks a lot! you sure did a lot of work there that was really needed, specially with types and arrays. Nice!. I'll see what can I come up with next .

This is a good example of the sort of thing that should parse properly now.
Notice that each parameter is just sort of crammed in there:

.method static <init>([BLjava/lang/String;Ljava/lang/String;)V

If anyone is having trouble following my changes it might be important to realize this:
'L' = a java object is about to be listed followed by a semicolon, '[' = an array of whatever the next letter is (this can include 'L') so this function definition would be void (byte[], string, string)

Good stuff is happening here. :F Are you idling any of the IRC channels at the moment? It might be easier to chat there.

 

[yashade2001]

Hey man!

I've been working on merging your new changes and analyzing them. Thanks a lot! you sure did a lot of work there that was really needed, specially with types and arrays. Nice!. I'll see what can I come up with next .

I tried to use VS2012's IDE but man it was hell, they don't have too much documentation, and WPF is kind of a new tech for me so I didn't want to spend much time on that, but hey it's good to know. I see, well, if you ever manage to improve your IDE somehow with some kind of AmendEdify converter and Amend syntax highlighting it would be great, as I'm kinda needing a recovery script IDE sometimes xD

The alpha version of editor with syntax highlighting is ready, check out my google plus post.

 

[yashade2001]

BTW you should make a gui for this, i can help to you. will fork your repo.

 

[darkguy2008]

This is a good example of the sort of thing that should parse properly now.
Notice that each parameter is just sort of crammed in there:

.method static <init>([BLjava/lang/String;Ljava/lang/String;)V

If anyone is having trouble following my changes it might be important to realize this:
'L' = a java object is about to be listed followed by a semicolon, '[' = an array of whatever the next letter is (this can include 'L') so this function definition would be void (byte[], string, string)

Good stuff is happening here. :F Are you idling any of the IRC channels at the moment? It might be easier to chat there.

Hey

Good to know! I kind of realized that looking at each of your commits lol. I tried to do my best at merging all the changes, I hope it's all good

By the way, shouldn't that line be:

.method static <init>([B;Ljava/lang/String;Ljava/lang/String;)V

with the semicolon between B and L ? that makes more sense to me xD

Also, it would be great, but what is the server and/or channels? I usually don't idle, but I can create a channel somewhere where we can exchange ideas a bit faster if you'd like .

The alpha version of editor with syntax highlighting is ready, check out my google plus post.

Oh, I rarely use G+, but I shall check your project and report back

BTW you should make a gui for this, i can help to you. will fork your repo.

About the GUI, well, I would consider it something secondary, and personally I'm very, very picky when it comes to GUIs, as I use the Microsoft guidelines mixed with some of mine when creating UIs, but hey, fork away and show me what you'll do. However, bear in mind that decompiling smali files requires to read other referenced smali files (either by being children of other smali files or referencing anonymous classes and such) so a JD-GUI GUI (lol) wouldn't be ideal in my opinion. A small GUI though, for choosing a folder and setting some options or displaying a single file or two wouldn't be too bad though. I'm open to suggestions, fork away and show me when you have something

 

[Fenny]

Hey

Good to know! I kind of realized that looking at each of your commits lol. I tried to do my best at merging all the changes, I hope it's all good

By the way, shouldn't that line be:

.method static <init>([B;Ljava/lang/String;Ljava/lang/String;)V

with the semicolon between B and L ? that makes more sense to me xD

Also, it would be great, but what is the server and/or channels? I usually don't idle, but I can create a channel somewhere where we can exchange ideas a bit faster if you'd like .

Well, there is #panicroom on Freenode. Lots of good peeps there. If you want to make one, we probably ought to do it on freenode, most of the Android dev stuff from XDA is on there after all.

And probably it would make more sense for smali to have some sort of separator character to split arguments in function signatures, but It totally doesn't. All it has is the semicolon to indicate the end of a type 'L'

*edit* Uhhhh, did you delete your github account or something? I am getting a 404.

 

[Goldie]

A small GUI though, for choosing a folder and setting some options or displaying a single file or two wouldn't be too bad though.

For me personally this would be great. I do all my mods in smali and know little to no java. However being able to convert can be really useful and a simple GUI to do this on a file or two would be great


Sent from my GT-I9305 using Tapatalk

 

[darkguy2008]

For me personally this would be great. I do all my mods in smali and know little to no java. However being able to convert can be really useful and a simple GUI to do this on a file or two would be great


Sent from my GT-I9305 using Tapatalk

Alright then, no worries, the app will have a small 'n nice GUI

Well, there is #panicroom on Freenode. Lots of good peeps there. If you want to make one, we probably ought to do it on freenode, most of the Android dev stuff from XDA is on there after all.

And probably it would make more sense for smali to have some sort of separator character to split arguments in function signatures, but It totally doesn't. All it has is the semicolon to indicate the end of a type 'L'

*edit* Uhhhh, did you delete your github account or something? I am getting a 404.

Ah I see, I thought XDA had their own IRC servers. Well, no prob, I can make a channel somewhere xD. Also thanks for the explanation

About github, sorry... I dunno WTF happened to it, for some reason a github "bot" thinks I'm not human (so what the hell am I then?) and asked me to contact support. I did, but I haven't received any replies yet. This is frustrating...

Edit: It seems they fixed that now. Can you try again please?

Edit2: Alright, channel #smali2java created on Freenode. Have fun!

 

[Ricky Divjakovski]

Alright then, no worries, the app will have a small 'n nice GUI

A GUI would be nice but a console package would be the starting point right! As it could be added to tools etc...?

 

[codelover]

A GUI would be nice but a console package would be the starting point right! As it could be added to tools etc...?

Having the same thought! So once the command line backend is ready, the GUI version can be simply a wrapper that calls the API, or better a seperate project maintained by other users called for Smalli2javaGUI, GUI 4 s2j or anything they like, so you can have better time focusing on the master project.

 

[cadialex]

Having the same thought! So once the command line backend is ready, the GUI version can be simply a wrapper that calls the API, or better a seperate project maintained by other users called for Smalli2javaGUI, GUI 4 s2j or anything they like, so you can have better time focusing on the master project.

Actually I'm working on a UI. It is not ready now, and comes in a new folder (simply called "UI" ^^). I think I'll do something like the JD-GUI UI, with a tree on the left and the code on the rigth. Will update you when It'll be ready (it could take a few days/weeks).

 

[broodplank1337]

I tested it (in VM (win xp) running on linux) and it works, but only for a very small amount of smali files, I have been able to decompile like 2 small files, but all other files failed.

example (first file is small file that is working on decompilation, second one is bigger file that fails)

C:\code>Smali2Java.exe MainActivity$1.smali
Decompiling file: MainActivity$1.smali
[
package com.broodplank.kitkatscreenrecorder;

  class MainActivity$1 extends java.lang.Object implements android.view.View$OnC
lickListener {
 final com.broodplank.kitkatscreenrecorder.MainActivity  synthetic this$0;
  MainActivity$1 (com.broodplank.kitkatscreenrecorder.MainActivity p1) {
thisreturn;
}
public  void onClick (android.view.View p1) {
boolean Boolean1 = android.widget.Button.isPressed(p1);

com.broodplank.kitkatscreenrecorder.MainActivity.startrecord(Boolean1);

return;
}
}
]

C:\code>Smali2Java.exe MainActivity.smali
Decompiling file: MainActivity.smali
[

Unhandled Exception: System.Collections.Generic.KeyNotFoundException: The given
key was not present in the dictionary.
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Smali2Java.SmaliVM.Get(String register)
   at Smali2Java.SmaliVM.Instructions.ParseRegistersAsArgs(Dictionary`2 register
s)
   at Smali2Java.SmaliVM.Instructions.Invoke()
   at Smali2Java.SmaliVM.ProcessInstruction(SmaliMethod m, SmaliLine l)
   at Smali2Java.SmaliMethod.Process()
   at Smali2Java.SmaliClass.LoadMethods()
   at Smali2Java.SmaliEngine.Decompile(String sFilename)
   at Smali2Java.Program.Main(String[] args)

(windows xp error report)

EventType : clr20r3     P1 : smali2java.exe     P2 : 1.0.0.0     P3 : 52c9ba4b
P4 : mscorlib     P5 : 2.0.0.0     P6 : 4889dc80     P7 : dc     P8 : 5     
P9 : a4dh5wwiwww1yjtmp0c0kv4zwcalu4in

What I highly suggest is to implement support for using the ' *.smali ' (all smali files in current dir) prefix as filename, so you don't have to make a loop yourself that performs that task

 

[Fenny]

I tested it (in VM (win xp) running on linux) and it works, but only for a very small amount of smali files, I have been able to decompile like 2 small files, but all other files failed.

example (first file is small file that is working on decompilation, second one is bigger file that fails)

C:\code>Smali2Java.exe MainActivity$1.smali
Decompiling file: MainActivity$1.smali
[
package com.broodplank.kitkatscreenrecorder;

  class MainActivity$1 extends java.lang.Object implements android.view.View$OnC
lickListener {
 final com.broodplank.kitkatscreenrecorder.MainActivity  synthetic this$0;
  MainActivity$1 (com.broodplank.kitkatscreenrecorder.MainActivity p1) {
thisreturn;
}
public  void onClick (android.view.View p1) {
boolean Boolean1 = android.widget.Button.isPressed(p1);

com.broodplank.kitkatscreenrecorder.MainActivity.startrecord(Boolean1);

return;
}
}
]

C:\code>Smali2Java.exe MainActivity.smali
Decompiling file: MainActivity.smali
[

Unhandled Exception: System.Collections.Generic.KeyNotFoundException: The given
key was not present in the dictionary.
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Smali2Java.SmaliVM.Get(String register)
   at Smali2Java.SmaliVM.Instructions.ParseRegistersAsArgs(Dictionary`2 register
s)
   at Smali2Java.SmaliVM.Instructions.Invoke()
   at Smali2Java.SmaliVM.ProcessInstruction(SmaliMethod m, SmaliLine l)
   at Smali2Java.SmaliMethod.Process()
   at Smali2Java.SmaliClass.LoadMethods()
   at Smali2Java.SmaliEngine.Decompile(String sFilename)
   at Smali2Java.Program.Main(String[] args)

(windows xp error report)

EventType : clr20r3     P1 : smali2java.exe     P2 : 1.0.0.0     P3 : 52c9ba4b
P4 : mscorlib     P5 : 2.0.0.0     P6 : 4889dc80     P7 : dc     P8 : 5     
P9 : a4dh5wwiwww1yjtmp0c0kv4zwcalu4in

What I highly suggest is to implement support for using the ' *.smali ' (all smali files in current dir) prefix as filename, so you don't have to make a loop yourself that performs that task

Well it would be easy enough to do that, but for now there are a LOT of things that are not implemented in the actual decoder... I.E. all conditional code branching, certain method call types, etc... I think it would be better to have the application do one file at a time until it is at a more functional state. Same with GUI, maybe later when the application is more feature complete.

Can you upload the file that it is crashing on? As for the crash itself I will add try blocks around the ParseRegistersAsArgs function in my repo... I think when we hit a parse failure or a skip where there should be none we should concatenate a comment into the output code so that we have a better idea where it is happening. What do you think, @darkguy2008 ?

 

[darkguy2008]

Well it would be easy enough to do that, but for now there are a LOT of things that are not implemented in the actual decoder... I.E. all conditional code branching, certain method call types, etc... I think it would be better to have the application do one file at a time until it is at a more functional state. Same with GUI, maybe later when the application is more feature complete.

Can you upload the file that it is crashing on? As for the crash itself I will add try blocks around the ParseRegistersAsArgs function in my repo... I think when we hit a parse failure or a skip where there should be none we should concatenate a comment into the output code so that we have a better idea where it is happening. What do you think, @darkguy2008 ?

Okay, I was gonna do a big multi-quote but Fenny already said a few things I wanted to:

First and foremost, I repeat, the app isn't ready yet for decompiling smali files out of the blue. It is in a very, VERY alpha stage where we don't even have all of the smali functions enumerated or even coded, to have it work on even a simple smali file. In fact, it needs work, but in terms of coding work.

I have to agree with Fenny though. While a GUI is a nice feature to have (and I'm more of a GUI rather than a CLI person and is one of the reasons why I prefer Windows over Linux), I don't think we should focus our work on a GUI, which, more likely than not, will need to be changed a lot through the whole development. Instead, I'd rather get help in coding the needed stuff to make this work nicely and then I promise we'll work toegether to make a good GUI for it. I have plans for a good GUI ! I just don't feel it is the right time to do it with the app not even being able to decompile correctly a smali file yet. Still, if someone does it, the work is appreciated and well if I like it it'll be included, it just isn't the main focus now.

I also agree with the comment thing. I've been working my head around today on how to display some debug info without complicating the working code much. I'm having a bit of a struggle trying to debug some specific smali lines and reaching to them in the debugger is a bit annoying, lol.

I would also like to see what files did broodplank1337 used. I assume they would come in handy in our tests

Keep up the great ideas and contributions!

 

[Fenny]

Okay, I was gonna do a big multi-quote but Fenny already said a few things I wanted to:

First and foremost, I repeat, the app isn't ready yet for decompiling smali files out of the blue. It is in a very, VERY alpha stage where we don't even have all of the smali functions enumerated or even coded, to have it work on even a simple smali file. In fact, it needs work, but in terms of coding work.

I have to agree with Fenny though. While a GUI is a nice feature to have (and I'm more of a GUI rather than a CLI person and is one of the reasons why I prefer Windows over Linux), I don't think we should focus our work on a GUI, which, more likely than not, will need to be changed a lot through the whole development. Instead, I'd rather get help in coding the needed stuff to make this work nicely and then I promise we'll work toegether to make a good GUI for it. I have plans for a good GUI ! I just don't feel it is the right time to do it with the app not even being able to decompile correctly a smali file yet. Still, if someone does it, the work is appreciated and well if I like it it'll be included, it just isn't the main focus now.

I also agree with the comment thing. I've been working my head around today on how to display some debug info without complicating the working code much. I'm having a bit of a struggle trying to debug some specific smali lines and reaching to them in the debugger is a bit annoying, lol.

I would also like to see what files did broodplank1337 used. I assume they would come in handy in our tests

Keep up the great ideas and contributions!

Here is a nice listing of opcodes, btw. Many of them are never seen in 2.0+ though.

https://github.com/JesusFreke/smali...est/resources/LexerTest/InstructionTest.smali

*EDIT* @broodplank1337 The changes I mentioned were just merged back into the main repo, pull em and give it a go. >

*EDIT2* some more light reading for you. @darkguy2008
https://github.com/JesusFreke/smali/blob/master/smali/src/main/antlr3/smaliTreeWalker.g
https://github.com/JesusFreke/smali/blob/master/smali/src/main/antlr3/smaliParser.g

Particularly interesting is the ParseRegister function.

 

[yashade2001]

@darkguy2008 , I made a little gui, will send pull request to you this week. btw check this ( my edify code editor ) http://xdaforums.com/showthread.php?t=2599759

 

[Diego910]

This could be awesome for thousands of mtk devices without cm or aosp!

Enviado desde mi bq Aquaris 5 HD mediante Tapatalk

 

[aashishb4u]

help

Thankfull that u took so much efforts ...!!!
But sir can u make video tutorial so that we can get it more accurately..!!
I tried this I convert .dex files to .smali but didn't get that how to convert .small into java
As well after modifieng it I don't get how to compile it again...!!!
Please help