[FIX] Cell standby/mobile radio active time issue

[orange808]

The Cyanogen Code Review page has become a complete mockery and flame war. In the course of the argument over <snark> "the bestest and smarty-est ever ever" </snark>, everyone involved embarrassed themselves.

The page looks like a chatroom of warez scriptz kiddiez..

Get yourselves together. Everyone is watching.

 

[StewieTech]

The Cyanogen Code Review page has become a complete mockery and flame war. In the course of the argument over <snark> "the bestest and smarty-est ever ever" </snark>, everyone involved embarrassed themselves.

The page looks like a chatroom of warez scriptz kiddiez..

Get yourselves together. Everyone is watching.

Yeah i noticed that. Here the poll says it works, there not so much. I´m testing it on AOSP rom now.

 

[optimumpro]

Here is Sony Xperia Z1 input: I did not use the xposed module, but rather made changes directly in sources and recompiled the rom. This positively does not affect battery drain in any way. This just masks the drain, which is now reported under miscellaneous, which is the difference between actual drain and estimated. It is a classical placebo: when your phone is sleeping, you will have 100% battery for 2-3 hours, but once you start using it, the procentage would drop like a rock in minutes to compensate for phoney reporting in the first hours.. Then look at your battery stats and you will see 30-40% drain under miscellanesous. . It is no fix at all, it "fixes" battery stats reporting...

 

[Bazoocaze]

Here is Sony Xperia Z1 input: I did not use the xposed module, but rather made changes directly in sources and recompiled the rom. This positively does not affect battery drain in any way. This just masks the drain, which is now reported under miscellaneous, which is the difference between actual drain and estimated. It is a classical placebo: when your phone is sleeping, you will have 100% battery for 2-3 hours, but once you start using it, the procentage would drop like a rock in minutes to compensate for phoney reporting in the first hours.. Then look at your battery stats and you will see 30-40% drain under miscellanesous. . It is no fix at all, it "fixes" battery stats reporting...

There is no "miscellaneous" item on my device on BatteryStats.

I am sorry for you, but "miscellaneous" indicates a bug in your RIL module which this patch not solve.

 

[bdasmith]

Been using this patch 2 days.....no miscellaneous or fast drops

Nexus 4

 

[optimumpro]

There is no "miscellaneous" item on my device on BatteryStats.

I am sorry for you, but "miscellaneous" indicates a bug in your RIL module which this patch not solve.

You don't have miscellaneous because this feature is optional and has to be enabled in settings, so that the phone starts calculating the difference between actual and estimated drain. If you enable it, you'll have it.

Your feature does not do anything to actual draining, it just fools the estimate and the user too.

I don't like cyanogen people: they are rude, arrogant and treated you badly, but in this case they are absolutely right on point: the fix fixes nothing...

Edit: You say in your OP that "This fix the "high cell standby mobile radio active time" bug."
It does not fix the bug, it alters the reporting of it, sort of like when someone has 40 degree temperature, you fix the thermometer to show 36.9...

 

[Bazoocaze]

You don't have miscellaneous because this feature is optional and has to be enabled in settings, so that the phone starts calculating the difference between actual and estimated drain. If you enable it, you'll have it.

Don't know where did you get this, because the "mischellaneous" feature is already in the code:
File: BatteryStatsHelper.java

        processMiscUsage();

        if (DEBUG) {
            Log.d(TAG, "Accuracy: total computed=" + makemAh(mComputedPower) + ", min discharge="
                    + makemAh(mMinDrainedPower) + ", max discharge=" + makemAh(mMaxDrainedPower));
        }
        mTotalPower = mComputedPower;
        if (mStats.getLowDischargeAmountSinceCharge() > 1) {
            if (mMinDrainedPower > mComputedPower) {
                double amount = mMinDrainedPower - mComputedPower;
                mTotalPower = mMinDrainedPower;
                [COLOR="Red"]addEntryNoTotal(BatterySipper.DrainType.UNACCOUNTED, 0, amount);[/COLOR]
            } else if (mMaxDrainedPower < mComputedPower) {
                double amount = mComputedPower - mMaxDrainedPower;
                [COLOR="Red"]addEntryNoTotal(BatterySipper.DrainType.OVERCOUNTED, 0, amount);[/COLOR]
            }
        }

        Collections.sort(mUsageList);

Your feature does not do anything to actual draining, it just fools the estimate and the user too.

This is not a patch for the drain. Please read the topic.

I don't like cyanogen people: they are rude, arrogant and treated you badly, but in this case they are absolutely right on point: the fix fixes nothing...

Edit: You say in your OP that "This fix the "high cell standby mobile radio active time" bug."
It does not fix the bug, it alters the reporting of it, sort of like when someone has 40 degree temperature, you fix the thermometer to show 36.9...

[/QUOTE]

No, it's working as expected, because the battery stats is notified when the radio is connected and disconnected. There is no timer or something simulating the notifications. If you wish, please I invite you to put some logs on the notifications (file NetworkManagementService.java), and then you will see the notifications showing correctly when the mobile data link switchs from connected to unconnected and vice-versa.

 

[optimumpro]

Don't know where did you get this, because the "mischellaneous" feature is already in the code:
File: BatteryStatsHelper.java
No, it's working as expected, because the battery stats is notified when the radio is connected and disconnected. There is no timer or something simulating the notifications. If you wish, please I invite you to put some logs on the notifications (file NetworkManagementService.java), and then you will see the notifications showing correctly when the mobile data link switchs from connected to unconnected and vice-versa.

It is in the code, but you have to enable it in developer settings: Showunaccounted/overcounted stats/show in battery statistics unaccounted and overcounted usage. If you didn't enable it, you won't see it.

You are misleading people. You say this:

"I'm working on a fix to the infamous Cell standby / Mobile radio active time issue.

Android issue 165558
- Mobile radio active battery drain in all internet apps
- https://code.google.com/p/android/is...tail?id=165558

Android issue 2556
- When mobile radio is active, battery drain in all internet apps
- https://code.google.com/p/android-de...detail?id=2556"

The issue you referenced above are about actual battery drain, but your patch does not affect any battery drain, it just changes the way radio is reported to battery stats.

Then you go on to say that you compiled a rom with the patch and on your device the issue is fixed. You seem like a person who knows a bit about coding. You can't really believe that this patch could affect the battery drain mentioned in Android Issues above..

You have to tell people more prominently that this patch in not about actual battery drain, but rather about changing the way it is shown in battery stats. . I bet 90% of your downloads are from confused users who think this fixes cell radio battery drain.

 

[Bazoocaze]

Please read #8 and #10

 

[sh4d1t0]

So nobody knows what is this patch..

I'm confusing about this patch

 

[venky716]

This is a real 'Fix' !

Like OP says it does nothing related to drain, it fixes the incorrect reporting of battery stats.

Mobile radio will drain way more battery than when on WiFi , its common knowledge.
Everyone started panicking after seeing the battery stats, if it was fixed from the beginning I doubt there would've been such panic .


Don't know why everyone is giving him such a hard time, for once someone tried to fix the issue and came out with something substantial.
Thanks for the fix.

 

[optimumpro]

This is a real 'Fix' !

Like OP says it does nothing related to drain, it fixes the incorrect reporting of battery stats.

Mobile radio will drain way more battery than when on WiFi , its common knowledge.
Everyone started panicking after seeing the battery stats, if it was fixed from the beginning I doubt there would've been such panic .


Don't know why everyone is giving him such a hard time, for once someone tried to fix the issue and came out with something substantial.
Thanks for the fix.

He is given hard time, because he misleads people into beleiving he fixed android infamous issue 16558 with high battery drain when apps continue to use data even if radio is off. His fix does not address actual draining and he knows it. Yet he posts here that he fixed that bug, he goes to CM gerrit and does the same, and he even posts the same on google code in that 16558 issue thread, again knowing well his patch does nothing to fix battery draining. That's deceptive at the least and he is surprised he is given a hard time?

 

[pcarenza]

Nothing deserves that kind of immature snark.

Sent from my A0001 using XDA Free mobile app

 

[imcrazyz]

Just to clear something out, this fix does make us see the mobile radio active time decreased. Yes, it does work. Yet it still doesn't fix the DRAIN. I don't know what Google has done with those codes, it just simply drains the battery life for no apparent reason. I started to doubt how well will be the battery life in android M.. Google said they had the fix already.. well....

 

[StewieTech]

After testing with AOSP rom my conclusion is that it improves the battery stats but it doesn´t fix the drain. It does improve the battery a little though.

I wonder, why do so "few" suffer with this bug? I mean a person can have the same phone, rom and settings as me and not suffer from it. Surely there has to be something to do other than coding right? I can´t get rid of the bug though, tried just about everthing.

 

[Bazoocaze]

There is absolutely no hard time.

I just laught on the face of people that think they are smart but don't know how the inner core of Android works nor how to debug the inner core.

I do not have the drain on my device (read post #8 and #10), I have only the active time issue, that is now gone on my device thanks to my researching. Unfortunatelly the active time issue is present on ALL androids LP, because it's on the inner core of Android. Regarding the drain, can't debug and fix an issue not present on my device.

For you that think you are smart, why did you not fixed the LP drain for us (but not for me, because my LP device is now working fine)? After several months there is nothing about that. Oh, I know, you want badly to contribute to xml translations.

Anyway, this is the nice part on Android: people can contribute where they want, other people test and if it works people will use it. If it not works or people do not want then they will not use it. And if people fells unconfortable people will blame the voluntary contributions.

Take a lesson on how to help people knowing more about what I am used to contribute fo fix droids: http://forum.xda-developers.com/showthread.php?t=1312398

PS: 10,340 downloads of the Xposed module.

 

[StewieTech]

Bazoocaze, is that last message of yours directed at me?

 

[Bazoocaze]

You have to tell people more prominently that this patch in not about actual battery drain, but rather about changing the way it is shown in battery stats. . I bet 90% of your downloads are from confused users who think this fixes cell radio battery drain.

Ok, so please, guide me: how do you think I must annouce this fix on the thread post?

 

[Bazoocaze]

Bazoocaze, is that last message of yours directed at me?

Of course it is not!!!!!! Please! It's for harsh people sending me messages.

 

[vivekchamoli]

Of course it is not!!!!!! Please! It's for harsh people sending me messages.

Right ..i gone through the CM post and seen the worst ever response from the so called developers n evaluators ...towards their contributor. Instead of accepting it they seems to hv taken up with their egoes n said no ..i m using patch via expose over OPO ..n its under observation.. Will update...keep doing your best ..XDA and its users are backing you ..what if they don't include .. Ppl here will surely cherry pick your commits in their respective ROMs ..have a great week ahead.