Getting magisk to mirror optics and prism in samsung devices

[exocetdj]

Hi all i have recently moved to Note 20 Ultra and i want to Port my rom module over however i noticed that Prism and Optics partitions on the root of the device are not mirrored by magisk when going to sbin/.magisk/mirror. this is potentially going to cause some major issues unless i can get these paritions mirrored in this folder (see below)

Does anyone know if this can be done?

 

[Didgeridoohan]

That would be something @topjohnwu (or anyone who feels like creating a PR) would have to deal with. Could be worth it opening a feature request Github issue...

 

[exocetdj]

That would be something @topjohnwu (or anyone who feels like creating a PR) would have to deal with. Could be worth it opening a feature request Github issue...

Just saw this. So may be worth it then?

I'll have a look at getting one raised

I have done a mount --bind for now to install the csc features on optics for now but would be awesome to have

 

[exocetdj]

That would be something @topjohnwu (or anyone who feels like creating a PR) would have to deal with. Could be worth it opening a feature request Github issue...

Request for Optics and Prism support raised
:good:

 

[hkjo]

Trying to override stuff there as well.

Is there somewhere a detailed explanation on what purpose mirroring serves, and how it fits into the "systemless" overlay idea?

moved to Note 20 Ultra and i want to Port my rom module over

Is your Note 20 code available somewhere? (I guess based on your 420rom.)

For future reference, this is the Github issue:

Request for root directory partition support: odm (all), optics and prism (Samsung), my_* (OPPO/OnePlus), vendor_dlkm (Android 12+) · Issue #3338 · topjohnwu/Magisk

Hi - I am following on from Didgeridoohan's suggestion that i should raise a request to see if we can get Optics and Prism partitions mirrored on Samsung devices. The CSC features and the accompany...

github.com

 

[markpanget1]

Just saw this. So may be worth it then?

I'll have a look at getting one raised

I have done a mount --bind for now to install the csc features on optics for now but would be awesome to have

How you do mount --bind?