Google Camera Mod Thread for OnePlus 5/T [OFFICIAL]

rohitvaranasi23

Senior Member
May 18, 2015
95
14
38
Hyderabad
Btw, in case people haven't noticed yet, the Magisk modules (CameraLibFix/DotFix and Pixel 2 Colours) are now both available in Magisk's Repo to download. I will be updating them there (in addition to my my summary post too) so that you can straight away update from Magisk itself. :)
Do they support Treble now? Or do we still have to use the TWRP zips? Just curious.
 

shadowstep

Forum Moderator
Staff member
Jun 6, 2014
4,292
8,105
263
30
Ambala
Do they support Treble now? Or do we still have to use the TWRP zips? Just curious.
Are you referring to the Magisk modules? Because Magisk has handled Treble since a long time now and modules are automatically handled based on Treble/Non-Treble availability by it. There aren't (and haven't been in the past too) separate modules for Treble compatibility because of this reason. They work fine in both Treble and Non-Treble ROMs.
 

IAMAB

Senior Member
Jan 14, 2013
112
27
48
Are you referring to the Magisk modules? Because Magisk has handled Treble since a long time now and modules are automatically handled based on Treble/Non-Treble availability by it. There aren't (and haven't been in the past too) separate modules for Treble compatibility because of this reason. They work fine in both Treble and Non-Treble ROMs.

Actually since the 5.1.5 upgrade, the magisk module used to crash the gcam app, so I had to install the twrp zip for treble. I tried it again now, and it still crashes maybe because I already have the twrp zip installed and there is no way to remove it other than flashing the ROM again.
 
  • Like
Reactions: rohitvaranasi23

shadowstep

Forum Moderator
Staff member
Jun 6, 2014
4,292
8,105
263
30
Ambala
Actually since the 5.1.5 upgrade, the magisk module used to crash the gcam app, so I had to install the twrp zip for treble. I tried it again now, and it still crashes maybe because I already have the twrp zip installed and there is no way to remove it other than flashing the ROM again.
That definitely shouldn't be happening. I'm not on OOS, so I can't even check myself, but I am pretty sure that the module works fine because there are people who've been using on on Treble/Non-Treble ROMs (including custom ROMs) and it's been working fine. Could have something to do with your setup/Magisk itself. Can't pinpoint without logs though.

The good thing is that the flashable zip is working fine for you. :) If you want, I can just create a revert zip for you (which will contain original, unmodified libs) which will save you the hassle of dirty flashing your ROM (OOS 5.1.5) if you want to revert the changes made by my flashable zip. Let me know.
 
  • Like
Reactions: BigTurboSkipper

aillez

Senior Member
Jun 28, 2010
526
346
93
Bangkok
That definitely shouldn't be happening. I'm not on OOS, so I can't even check myself, but I am pretty sure that the module works fine because there are people who've been using on on Treble/Non-Treble ROMs (including custom ROMs) and it's been working fine. Could have something to do with your setup/Magisk itself. Can't pinpoint without logs though.

The good thing is that the flashable zip is working fine for you. :) If you want, I can just create a revert zip for you (which will contain original, unmodified libs) which will save you the hassle of dirty flashing your ROM (OOS 5.1.5) if you want to revert the changes made by my flashable zip. Let me know.
Actually since the 5.1.5 upgrade, the magisk module used to crash the gcam app, so I had to install the twrp zip for treble. I tried it again now, and it still crashes maybe because I already have the twrp zip installed and there is no way to remove it other than flashing the ROM again.
I think it because you install Audio mod.

I face this issue too.

For me I have Viper4android and if I want to use magisk module I need to set kernel to permissive mode (which always cause my phone to force reboot and kinda bootloop.)

It's not good for security perspective by the way.

So, I use TRWP zip rather than Magisk.

And it's working fine.



Sent from my ONEPLUS A5010 using Tapatalk
 

shadowstep

Forum Moderator
Staff member
Jun 6, 2014
4,292
8,105
263
30
Ambala
I think it because you install Audio mod.

I face this issue too.

For me I have Viper4android and if I want to use magisk module I need to set kernel to permissive mode (which always cause my phone to force reboot and kinda bootloop.)

It's not good for security perspective by the way.

So, I use TRWP zip rather than Magisk.

And it's working fine.
I'm on a custom ROM and I've been using ViPER4Android perfectly fine without setting the kernel to permissive along with the DotFix/CameraLibFix Magisk module.
 

IAMAB

Senior Member
Jan 14, 2013
112
27
48
I think it because you install Audio mod.

I face this issue too.

For me I have Viper4android and if I want to use magisk module I need to set kernel to permissive mode (which always cause my phone to force reboot and kinda bootloop.)

It's not good for security perspective by the way.

So, I use TRWP zip rather than Magisk.

And it's working fine.

I have the exact same setup. Except I have installed Dolby and not viper with audio mod
 

aillez

Senior Member
Jun 28, 2010
526
346
93
Bangkok
I'm on a custom ROM and I've been using ViPER4Android perfectly fine without setting the kernel to permissive along with the DotFix/CameraLibFix Magisk module.
so this issue might relate to only oos then.
I have the exact same setup. Except I have installed Dolby and not viper with audio mod
you can try my explain and report if it working.

Sent from my ONEPLUS A5010 using Tapatalk
 

rohitvaranasi23

Senior Member
May 18, 2015
95
14
38
Hyderabad
So, the newest Gcam ports from the Pixel 3 have popped up. Is it safe to assume they're compatible with only Android P? I tried installing the test-3 version only to have package installer FC. I'm on OnePlus 5 OB19.
Edit: It installed, and when I try to open it, both camera and Package Installer FC.
 
Last edited:
  • Like
Reactions: BigTurboSkipper
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone