Google Camera pink tint fix for Omnivision sensors(MIDO)

chickentuna · Oct 29, 2017 at 5:10 AM

SamYang said:
HDR+ is work, and photos no pink, but unfortunately the photo's quality is not so good
The photos get a lot noise even during the day only myself get this??

This is where MIUI cam beats gcam. Normal shots during day time has lots of noise. Unfortunately even in the modded gcam that I have, you cannot force enable HDR+ as it force closes the app when photos are taken in good lighting conditions(i.e. outside during daytime). HDR+ shots is where gcam shines

febry_valdy · Oct 29, 2017 at 9:24 AM

Nice info for those who has the same cam sensor.

Sent from my Redmi Note 4 using Tapatalk

SamYang · Sep 19, 2016 45 6 0

chickentuna said:
This is where MIUI cam beats gcam. Normal shots during day time has lots of noise. Unfortunately even in the modded gcam that I have, you cannot force enable HDR+ as it force closes the app when photos are taken in good lighting conditions(i.e. outside during daytime). HDR+ shots is where gcam shines

ok, i got it.yesterday i use lineageos,and now i have changed to aosp extended,it's look like the gcam work more better(maybe).thx anyway.:highfive:

romeocharliegolf · Oct 29, 2017

chickentuna said:
I have a modified apk(gcam 4.2) which came from GeorgeKiarie that has the fix hardcoded in it. I'm currently testing it and it seems that it produces much sharper HDR+ images. However there are no extra settings and you use is as it is. No HDR+ configurations just HDR+ OFF, AUTO and ON. It still crashes randomly but I think it's much stable than modifying the camera libs. Colors are rich and look better too. Perhaps I should add it in the OP for you guys to test?
.

@chickentuna
I asked GeorgeKiarie to hardcoded the change into Gcam 5.1. As far as I tried it, no force close when taking picture in good light condition. You can enable/disable the HDR+ too.

Currently I am on AEX 4.6.

Link:

Code:

https://drive.google.com/file/d/0B5NJTB9bLPdsWmVJUFFiZ01CNFk/view

Sample Pic:

chickentuna · Oct 29, 2017 at 11:18 AM

romeocharliegolf said:
@chickentuna
I asked GeorgeKiarie to hardcoded the change into Gcam 5.1. As far as I tried it, no force close when taking picture in good light condition. You can enable/disable the HDR+ too.

Link:

Code:

https://drive.google.com/file/d/0B5NJTB9bLPdsWmVJUFFiZ01CNFk/view

Sample Pic:

https://i.imgur.com/wQvMQuz.jpg

Yeah I saw that in reddit this morning but after extensive testing, I can say that it doesn't matter if the fix is hardcoded or not.

There are no crashes in the latest gcam 5.1 because HDR+ is auto-enabled. The app determines the lighting condition and decides if HDR+ will be enabled or not. Try version 4.0 or any version that you can force enable HDR+ and take a pic outside during daytime and you'll see what I mean. The camera will either crash or get buggy and the only solution is to force close it.

For those using gcam 4.0 or any version that lets you to force enable HDR+, just leave HDR+ in auto and let the app determine if HDR+ is needed or not otherwise you'll just end up crashing your camera.

I am using the latest gcam version together with the pink tint fix and I'm rarely getting camera crashes.

BTW, nice pic. The photo is a lot clearer and sharper than the MIUI camera.

Sent from my Redmi Note 4 using Tapatalk

romeocharliegolf · Sep 29, 2017 37 10 0

chickentuna said:
Yeah I saw that in reddit this morning but after extensive testing, I can say that it doesn't matter if the fix is hardcoded or not.

There are no crashes in the latest gcam 5.1 because HDR+ is auto-enabled. The app determines the lighting condition and decides if HDR+ will be enabled or not. Try version 4.0 or any version that you can force enable HDR+ and take a pic outside during daytime and you'll see what I mean. The camera will either crash or get buggy and the only solution is to force close it.

For those using gcam 4.0 or any version that lets you to force enable HDR+, just leave HDR+ in auto and let the app determine if HDR+ is needed or not otherwise you'll just end up crashing your camera.

I am using the latest gcam version together with the pink tint fix and I'm rarely getting camera crashes.

BTW, nice pic. The photo is a lot clearer and sharper than the MIUI camera.

Sent from my Redmi Note 4 using Tapatalk

Yup, that's me asking on reddit

So, basically there is no difference between pinktint fix + Gcam 5.1, and hardcoded default lib + Gcam 5.1?

Thank you, but there are a lot of noises outside of focus range (at the background for example), but if compared to before, it was a lot better. I'm using Pixel XL (corr) for the model, PIXEL for the Config Camera HDR+, and High HDR+ parameters.

Before this fix, I'm using Bacon Camera. The pic is good, but they have problem in the touch focus.

chickentuna · Oct 29, 2017 at 11:44 AM

romeocharliegolf said:
Yup, that's me asking on reddit
So, basically there is no difference between pinktint fix + Gcam 5.1, and hardcoded default lib + Gcam 5.1?

Thank you, but there are a lot of noises outside of focus range (at the background for example), but if compared to before, it was a lot better. I'm using Pixel XL (corr) for the model, PIXEL for the Config Camera HDR+, and High HDR+ parameters.

Before this fix, I'm using Bacon Camera. The pic is good, but they have problem in the touch focus.

In terms of photo quality and stability? No, I don't think so. Then again, I don't have keen eyes in differentiating a good photo from a bad photo quality wise. As long as the photo is clear and colors are rich, I'm fine with it.

I'm using almost the same config as yours, the only difference is I'm using Nexus 6p for Config Camera HDR+. I've tried different settings and personally, I don't see much difference. Maybe there's something that we can tweak in the settings to minimize background noise or maybe Omnivision is just that bad?

Sent from my Redmi Note 4 using Tapatalk

romeocharliegolf · Sep 29, 2017 37 10 0

chickentuna said:
In terms of photo quality and stability? No, I don't think so. Then again, I don't have keen eyes in differentiating a good photo from a bad photo quality wise. As long as the photo is clear and colors are rich, I'm fine with it.

I'm using almost the same config as yours, the only difference is I'm using Nexus 6p for Config Camera HDR+. I've tried different settings and personally, I don't see much difference. Maybe there's something that we can tweak in the settings to minimize background noise or maybe Omnivision is just that bad?

Sent from my Redmi Note 4 using Tapatalk

I agree with you. The photo is clear and sharp, also the colors are rich. My problem with snapdragon camera is the image is not that sharp - too much smoothing. I don't know, maybe there is a problem with the OV driver?

My guess is the OV sensor's quality. My friend who own the same RN4X but got the Sony sensor, the image is not that worst if I compare it to my GCam HDR+. From what I have read, the quality of sensor rank (from good to bad) is: Sony - Samsung - OV.

When I compare the size of the same image taken with SD camera, mine is less than 1 MB, while my friend's is almost 5 MB.

LilBlinx · Oct 29, 2017

romeocharliegolf said:
I agree with you. The photo is clear and sharp, also the colors are rich. My problem with snapdragon camera is the image is not that sharp - too much smoothing. I don't know, maybe there is a problem with the OV driver?

My guess is the OV sensor's quality. My friend who own the same RN4X but got the Sony sensor, the image is not that worst if I compare it to my GCam HDR+. From what I have read, the quality of sensor rank (from good to bad) is: Sony - Samsung - OV.

When I compare the size of the same image taken with SD camera, mine is less than 1 MB, while my friend's is almost 5 MB.

That's called picture compression.

---------- Post added at 03:36 PM ---------- Previous post was at 03:24 PM ----------

I am guessing that the hard coded APKs are to be used without touching the lib that's why there is no difference. If you have the modded lib the hardcoded app and the official gcam will behave exactly the same. If you have the original lib and the hardcoded app and the official gcam, you will experience pink tint on official gcam, but not on hardcoded

romeocharliegolf · Sep 29, 2017 37 10 0

LilBlinx said:
That's called picture compression

Well, the problem is when I took them using the same settings, the result is different. That's why I'm guessing there is a problem with the OV lib.

LilBlinx said:
I am guessing that the hard coded APKs are to be used without touching the lib that's why there is no difference. If you have the modded lib the hardcoded app and the official gcam will behave exactly the same. If you have the original lib and the hardcoded app and the official gcam, you will experience pink tint on official gcam, but not on hardcoded

Seconded.

fatfoot · Nov 2, 2017

I heard the high light issue persists due to wrong white balance of the Omni driver or Gcam itself.
Sometimes GCamera crashes "on the light" with the following errors:

yellowpage · Oct 30, 2017 at 3:24 PM

romeocharliegolf said:
Link:

Code:

https://drive.google.com/file/d/0B5NJTB9bLPdsWmVJUFFiZ01CNFk/view

Thank you for the apk. It works fine on my Note 4.

romeocharliegolf · Sep 29, 2017 37 10 0

yellowpage said:
Thank you for the apk. It works fine on my Note 4.

You're welcome!

Stidza · Oct 31, 2017

So which version of the Google Camera should I install?
Btw, thank you so much!

EDIT: I've just installed version 5.1 and the difference between the stock camera is amazing! I have 2 questions though: 1. What value of HDR+ parameters should I set? 2. What is the difference between HDR+ and HDR+ Enhanced, and when should I use the first and when the second?

fatfoot · Oct 29, 2017 21 0 0

Stidza said:
What is the difference between HDR+ and HDR+ Enhanced

"Enhanced" mode makes HDR+ forcibly in any light condition... or at least trying to do so.
And simple HDR+ is auto mode which works only in low light, it shows the check mark in the little white circle when ready and don't work with high brightness.
As for options - just try different ones and look at photos.

And by the way, do you really able to make HDR+ photos (with the snapshot circle) in good light?

NemanjaS23 · Mar 24, 2015 25 3 0

does somebody have little dots, only visible when picture is zoomed pretty much, like some kind of some dot pattern visible in darker(noisier) areas? I'm using MGC_5.1.014_7.0H_C2API_v.1.3_AllinOne_HBL64 with hardcoded libraries, and everything else really works like a charm, no FC in photo mode, just that tiny pattern of dots when picture is zoomed in

fatfoot · Oct 29, 2017 21 0 0

NemanjaS23 said:
does somebody have little dots

Yes I see them too. And I think it's not bad, to do so zoom level must be really high.

So you make photos in good light without any problems?

NemanjaS23 · Mar 24, 2015 25 3 0

Yes, no problems at all, this Gcam is doing really remarkable job

ImQseft · Oct 31, 2017 at 11:47 PM

Is the camera crash when forced HDR+ on good lighting omnivision specific bug or does it affect all mido devices?

chickentuna · Nov 1, 2017 at 12:16 AM

ImQseft said:
Is the camera crash when forced HDR+ on good lighting omnivision specific bug or does it affect all mido devices?

My front camera is Samsung and I have a modded gcam with HDR+ enabled in front camera. Based on my tests, force enabled HDR+ on a Samsung sensor does not crash the camera even in good lightning conditions.

Google Camera pink tint fix for Omnivision sensors(MIDO)

Senior Member

Senior Member

Member

Member

Senior Member

Member

Senior Member

Member

Recognized Contributor

Member

Member

Senior Member

Member

Senior Member

Member

Member

Member

Member

Senior Member

Senior Member