Google Camera pink tint fix for Omnivision sensors(MIDO)

ImQseft

Senior Member
Jul 12, 2016
165
98
28
My front camera is Samsung and I have a modded gcam with HDR+ enabled in front camera. Based on my tests, force enabled HDR+ on a Samsung sensor does not crash the camera even in good lightning conditions.
Would it help if I send you a logcat of the crash?
 

aabenroi

Senior Member
Dec 6, 2011
353
210
63
Pontianak
Is the camera crash when forced HDR+ on good lighting omnivision specific bug or does it affect all mido devices?
I have mido with sony and omni...
In sony you can force hdr+ in any light condition without problem
In omni, it doesn't work on bright light... Its funny that low light picture is better than bright light.
 

fatfoot

Member
Oct 29, 2017
21
0
0
My Omni works great with HDR+ in good light on HBL64 gcam with stock library. And that's completely unclear, why it crashes or freezes for other guys?
 

chickentuna

Senior Member
Feb 13, 2012
1,464
576
133
My Omni works great with HDR+ in good light on HBL64 gcam with stock library. And that's completely unclear, why it crashes or freezes for other guys?
Cause HDR+ is set to auto by default. The app checks the lighting condition before taking a shot and automatically turns off HDR+ when lighting condition is good.

Here's a good way to test it: Set HDR+ to enhanced and it will force HDR+ to always ON. Take a direct shot of a white light bulb (while it's turned on obviously) and you'll see that the shutter button gets stuck and not respond. Restarting the app is the only way to fix it.
 

fatfoot

Member
Oct 29, 2017
21
0
0
Cause HDR+ is set to auto...
No, it isn't, I need HDR+ so I always set it to Enhanced to make HDR+ forcibly anyway.

And my gcam really makes it in good light, with the capture cycle and photo processing afterwards.

---------- Post added at 09:45 AM ---------- Previous post was at 09:42 AM ----------

Restarting the app is the only way to fix it.
No, you may go to frontal or to video, or to settings and then return back. It unfreezes the capture button without the app restarting.
 
Last edited:

chickentuna

Senior Member
Feb 13, 2012
1,464
576
133
No, it isn't, I need HDR+ so I always set it to Enhanced to make HDR+ forcibly anyway.

And my gcam really makes it in good light, with the capture cycle and photo processing afterwards.
So yours doesn't get stuck when taking a direct shot of a white light bulb?

Mine doesn't really crash in every good lighting condition but it crashes when pictures are taken on subjects that are against bright lights example: pics taken outside on a bright sunny day.



Sent from my Redmi Note 4 using Tapatalk
 

vetefan

Senior Member
Mar 21, 2011
85
12
28
After install the pink tint fix, the google camera app and some other apps' data will gone after killing the app or reboot the phone. The problem solved after wipe the data partition. Maybe can try to wipe cache or data for app crash or other strange problem. (I'm installing this on LOS 14.1)
 

sheeeple00

Member
Aug 23, 2017
38
10
0
Here's a good way to test it: Set HDR+ to enhanced and it will force HDR+ to always ON. Take a direct shot of a white light bulb (while it's turned on obviously) and you'll see that the shutter button gets stuck and not respond. Restarting the app is the only way to fix it.
I just tried this using the app posted by user romeocharliegolf and I didn't experience any problem.

Mido on miui 8.5.4.0 and Omnivision sensor.

?
 

sheeeple00

Member
Aug 23, 2017
38
10
0
May I ask what your config is?
Model: pixel XL (Corr)
Config: Nexus 6p
HDR params: super high

Though I've tried other configurations too (with hdr enhanced always on).

Are you having the crashing problem too? Can you post your config? I'll test it out on my device.
 

ImQseft

Senior Member
Jul 12, 2016
165
98
28
Model: pixel XL (Corr)
Config: Nexus 6p
HDR params: super high

Though I've tried other configurations too (with hdr enhanced always on).

Are you having the crashing problem too? Can you post your config? I'll test it out on my device.
Yeah I am. I am constantly changing configs to try and fix the issue and as of now, gcam is not my primary cam yet because of this issue so I can't really give you an exact params to check. If you use the flashable zip fix instead of the hard codes fix, does it still work? No crashes?
 

chickentuna

Senior Member
Feb 13, 2012
1,464
576
133
Yeah I am. I am constantly changing configs to try and fix the issue and as of now, gcam is not my primary cam yet because of this issue so I can't really give you an exact params to check. If you use the flashable zip fix instead of the hard codes fix, does it still work? No crashes?
Regardless of the fix, I still get crashes in good lighting conditions. Issue persists even if cam libs are not modified. I have yet to test in MIUI though.

Again it only crashes/gets stucked if the subject is under a bright light i.e. taking a photo of a person against under direct sunlight. If it's not bright enough, it will not crash and HDR+(forced) functions properly.

Sent from my Redmi Note 4 using Tapatalk
 

aabenroi

Senior Member
Dec 6, 2011
353
210
63
Pontianak
Custom ROM are still using old omnivision blobs because of kernel imcompatibility with the new blobs in recent version of MIUI.
I think thats the problem...

We need to get the updated kernel changes, so dev can use new omnivision blobs
We can push xiaomi to release the updated source, @highwaystar_ru already ask for it but seems like it's useless.
I've created query about this pink problem in MIUI bugs months ago, it gets many support but those miui guys does not care...

Hopefully someone smarter jump again to correct the blobs / kernel source ...