I've just read the whole topic and wonder: why are you using post-fs-data scripts rather creating a simple module with proper system.prop value?
Anyway - I tried to do it - and it doesn't work on MIUI 9 (Android 7.1.2) with Magisk 16.0. Also the module "Extend WiFi channels" by Thomasvt als fails because it uses the same way.
Resetprop doesn't work?
#!/system/bin/sh resetprop persist.camera.HAL3.enabled 1
How does it prevent the system partition being marked as changed, if build.prop really gets modified? (avoiding this is the point of this thread)
It doesn't. Editing prop values systemlessly means you'll have to use the Magisk resetprop tool somehow. Either with a boot script (relatively simple), a Magisk module (might be a bit overkill), or use one of the modules already available that do what you're looking for. If there aren't any module available that sets the props you want, the MagiskHide Props Config module (shameless advertising ) can set the prop for you.
I created the custom prop function in that module to make it easy for the average user to change prop values systemlessly. Unfortunately it's been kind of overlooked with the popularity of other functions of the module (changing the build fingerprint to pass the ctsProfile check, which in itself is just a systemlessly changing of a prop value)...
As it seems from @jaager's report though, doing it systemlessly might not always be enough...
im in the process of porting my rom over to the MNT extended template.
I have got everthing over and working but want to change the ro.build.display.id on the build prop
i have read that we need to add a file in .core/img/.core/service.d or post-fs-data.d
how can we get this to show when the module is installed?
Your info is out of date. The paths you want are:
If you're not using a module that is, since then you'd use the post-fd-data.sh and service.sh files in the module. But if you're using a module you should be using the system.prop file to make prop changes anyway...
Actually the first way worked lol! Although if it's dated I'll stick to the new path under data/adb, I can see these folders there.
So yes the changes I am making are via a module. I tried adding a system.prop with
In the common folder but that didn't make any changes and I'm unsure what else I need to change in the module to call this from the system.prop.
The paths you used are old and current Magisk releases have them symlinked (for backwards compatibility), but they will be dropped in the next release.
The system.prop file needs to be in the root of the module directory. Take a look in the Magisk docs for details on how modules work:
Ok that's a bit clearer, apologies, having ADHD means that anything that isn't clear, leads to massive overthinking and going on random tangents with working :laugh:
I can see that the file I placed is in that newer folder too so that makes sense
So looking at that guide, the changes in system.prop are loaded by resetprop as system values.
I came across some files, resetprop.cpp and a couple of other .cpp files which iv stored in my working folder but it lacked instruction on use for these.
Yes, Magisk will run resetprop during boot an load the system.prop file.
The .cpp files are part of the code and used when building the tools. The actual tool is an applet of the Magisk binary, although I believe you can build the resetprop tool separately (outside my skillset).
Affirmative on both.
It is easiest to just start with a fresh template and make a module. The template does most the work for a prop change, you just have to add the values you want and it will work.
Respect to you mate
---------- Post added at 10:40 AM ---------- Previous post was at 10:27 AM ----------
I butchered my first zip template with my overthinking.
I'll start again, this time with system.prop on root of module zip with prop tweaks in
well after playing with your Module!!! Between 2 pixel 2 xl devices 1 on 10 and second on 11 beta 3 i was using Solid Explorer and went into files and added fingerprint info manually and wifi calling props, and tethering prop. everything is working. Thanks for Your FAST Answers.What is it that doesn't work on 11 (I don't have any 11 devices, so if there's something that isn't working it would be great to know)?
If you mean the SafetyNet CTS check, it's no use updating the fingerprint just yet. If it doesn't work now, it's not gonna work until Google certifies the build.
Thanks this seems promising, however i don't understand the syntax. If you have time could you tell me what to add with the build prop changes i wanted earlier in the thread. Thanks a lot for all the help