Is it safe to flash Project Treble on rooted phone + Magisk?

[Handsome Jack]

My phone Sprint/XT1922-7_JETER_SPRINT_8.0.0 (16gb model)

I just root it and flash Disable_Dm-Verity_ForceEncrypt + Magisk
Until I saw this:

[AOSP 9.0] [2019-08-25] Phh-Treble

WARNING: You'll most probably loose ALL your data, and might break your phone. Please use with extreme caution! The goal of this ROM is to provide maximum hardware compatibility inside a Generic System Image. No feature will be added. This will...

forum.xda-developers.com

The instructions say: Flash GSI first.
Then flash Magisk.
I also don't know if Disable_Dm-Verity_ForceEncrypt would mess up?

 

[alecxs]

either your device is Treble or not. check with this app
http://play.google.com/store/apps/details?id=com.kevintresuelo.treble

if yes you can flash any GSI
https://forum.xda-developers.com/t/gsi-10-lineageos-17-x-gsi-all-archs.4004673

you don't need encryption disabler, but sure you must factory reset device every time you switch ROM.

 

[Handsome Jack]

either your device is Treble or not. check with this app
http://play.google.com/store/apps/details?id=com.kevintresuelo.treble

if yes you can flash any GSI
https://forum.xda-developers.com/t/gsi-10-lineageos-17-x-gsi-all-archs.4004673

you don't need encryption disabler, but sure you must factory reset device every time you switch ROM.

I already flashed Disable_Dm-Verity_ForceEncrypt + Magisk on the phone.

Do I Need to remove those before I flash GSI?

 

[alecxs]

No, how would you? It's too late. To undo modifications of Disable_Dm-Verity_ForceEncrypt you need to restore backup of vendor (sometimes nvram)

 

[Handsome Jack]

Is it possible/safe to flash GSI on phone that was already flashed Disable_Dm-Verity_ForceEncrypt + Magisk?

 

[jwoegerbauer]

either your device is Treble or not. check with this app
http://play.google.com/store/apps/details?id=com.kevintresuelo.treble

if yes you can flash any GSI
https://forum.xda-developers.com/t/gsi-10-lineageos-17-x-gsi-all-archs.4004673

...

May be I'm mistaken but you can't flash ANY GSI even if device is Project Treble enabled: Read here:

Generic System Images (GSIs) | Android Developers

developer.android.com

 

[alecxs]

of course I referred to builds that are built for the proper SoC (aarch64). In theory one can use "any" of these GSIs here:
https://forum.xda-developers.com/f/treble-enabled-device-development-a-ab-roms.7260
(as always: read OP for restrictions)

 

[Handsome Jack]

Is it possible/safe to flash GSI on phone that was already flashed Disable_Dm-Verity_ForceEncrypt + Magisk?

 

[alecxs]

what do you mean with safe? no, you will lose all data each time you format data (which is required step for every ROM installation).

as I said if your device is treble enabled it is possible to flash GSI. doesn't matter if encryption already has been disabled or phone was rooted with Magisk previously. Magisk lives in boot partition. if you install custom ROM it will overwrite boot + system anyway (sometimes even vendor, where encryption was patched)

GSI only overwrites system partition, it won't touch boot or vendor therefore all modifications preserved.

 

[Handsome Jack]

what do you mean with safe? no, you will lose all data each time you format data (which is required step for every ROM installation).

as I said if your device is treble enabled it is possible to flash GSI. doesn't matter if encryption already has been disabled or phone was rooted with Magisk previously. Magisk lives in boot partition. if you install custom ROM it will overwrite boot + system anyway (sometimes even vendor, where encryption was patched)

GSI only overwrites system partition, it won't touch boot or vendor therefore all modifications preserved.

I don't care about data. I understand that each time flash a new rom --> all data in the phone would be erased.
I am asking because the guide show flash GSI first.
Then install Magisk later.
It also doesn't mention anything about Disable_Dm-Verity_ForceEncrypt. That why I worry if Disable_Dm-Verity_ForceEncrypt would mess everything up.

phone Sprint/XT1922-7_JETER_SPRINT_8.0.0 (16gb model)

 

[alecxs]

I understand that each time flash a new rom --> all data in the phone would be erased.

not exactly. you should care about that last step yourself, it is highly recommended.

It also doesn't mention anything about Disable_Dm-Verity_ForceEncrypt. That why I worry if Disable_Dm-Verity_ForceEncrypt would mess everything up.

In this guide there are quick fastboot commands to revert back to stock. probably vendor is enough to repair encryption.

[guide] [root] [oreo&pie] [jeter/aljeter] [twrp, decrypt, magisk] [stock firmware]

* Your warranty is now void. * * I am not responsible for bricked devices, dead SD cards, fires, rigged elections, ligma, * thermonuclear war, or your mom getting upset with you for being on the computer all day Please * Ensure you have an...

forum.xda-developers.com

 

[Handsome Jack]

yeah, I used that guide to flashed Disable_Dm-Verity_ForceEncrypt + Magisk.
After that I found out it doesn't need those two... to flash GSI.